device vxcan0 entered promiscuous mode ====================================================== WARNING: possible circular locking dependency detected 5.17.0-rc6-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/3710 is trying to acquire lock: ffff888112fbf5c0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_drop_all+0x2b/0xd0 net/can/j1939/socket.c:139 but task is already holding lock: ffff888112fe90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] ffff888112fe90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_netdev_event_netdown+0x1f/0x90 net/can/j1939/socket.c:1266 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&priv->j1939_socks_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_errqueue+0x49/0xa0 net/can/j1939/socket.c:1078 j1939_session_destroy+0xc0/0xe0 net/can/j1939/transport.c:269 __j1939_session_release net/can/j1939/transport.c:288 [inline] kref_put include/linux/kref.h:65 [inline] j1939_session_put net/can/j1939/transport.c:293 [inline] j1939_session_deactivate_locked net/can/j1939/transport.c:1075 [inline] j1939_session_deactivate_locked+0x9f/0xb0 net/can/j1939/transport.c:1063 j1939_cancel_active_session+0x95/0x130 net/can/j1939/transport.c:2183 j1939_netdev_notify+0x104/0x160 net/can/j1939/main.c:371 notifier_call_chain+0x59/0x90 kernel/notifier.c:84 call_netdevice_notifiers_info net/core/dev.c:1940 [inline] call_netdevice_notifiers_info net/core/dev.c:1925 [inline] call_netdevice_notifiers_extack net/core/dev.c:1978 [inline] call_netdevice_notifiers net/core/dev.c:1992 [inline] __dev_notify_flags+0xd8/0x180 net/core/dev.c:8451 dev_change_flags+0x46/0x50 net/core/dev.c:8487 do_setlink+0x31d/0x1230 net/core/rtnetlink.c:2731 __rtnl_newlink+0x592/0x9d0 net/core/rtnetlink.c:3416 rtnl_newlink+0x3e/0x60 net/core/rtnetlink.c:3531 rtnetlink_rcv_msg+0x156/0x4e0 net/core/rtnetlink.c:5979 netlink_rcv_skb+0x49/0xf0 net/netlink/af_netlink.c:2494 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x1af/0x280 net/netlink/af_netlink.c:1343 netlink_sendmsg+0x23f/0x4a0 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg+0x2b/0x40 net/socket.c:725 ____sys_sendmsg+0x246/0x260 net/socket.c:2413 ___sys_sendmsg+0x92/0xd0 net/socket.c:2467 __sys_sendmsg+0x71/0xc0 net/socket.c:2496 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x34/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae -> #1 (&priv->active_session_list_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x26/0x130 net/can/j1939/transport.c:1553 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0xd2/0x110 net/can/j1939/socket.c:205 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1384 [inline] j1939_xtp_rx_eoma+0xbf/0x160 net/can/j1939/transport.c:1399 j1939_tp_cmd_recv net/can/j1939/transport.c:2088 [inline] j1939_tp_recv+0x2b6/0x3b0 net/can/j1939/transport.c:2133 j1939_can_recv+0x183/0x240 net/can/j1939/main.c:108 deliver net/can/af_can.c:574 [inline] can_rcv_filter+0x79/0x190 net/can/af_can.c:608 can_receive+0xbe/0x190 net/can/af_can.c:665 can_rcv+0x2b/0x60 net/can/af_can.c:696 __netif_receive_skb_one_core+0x4f/0x70 net/core/dev.c:5393 process_backlog+0x6a/0x230 net/core/dev.c:5835 __napi_poll.constprop.0+0x20/0x110 net/core/dev.c:6401 napi_poll net/core/dev.c:6468 [inline] net_rx_action+0x26f/0x340 net/core/dev.c:6555 __do_softirq+0x167/0x4fa kernel/softirq.c:558 run_ksoftirqd kernel/softirq.c:921 [inline] run_ksoftirqd+0x2d/0x40 kernel/softirq.c:913 smpboot_thread_fn+0x171/0x210 kernel/smpboot.c:164 kthread+0xcf/0xf0 kernel/kthread.c:377 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 -> #0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain kernel/locking/lockdep.c:3801 [inline] __lock_acquire+0x1114/0x1b60 kernel/locking/lockdep.c:5027 lock_acquire kernel/locking/lockdep.c:5639 [inline] lock_acquire+0xc7/0x2f0 kernel/locking/lockdep.c:5604 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_queue_drop_all+0x2b/0xd0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x44/0x90 net/can/j1939/socket.c:1272 j1939_netdev_notify+0x10c/0x160 net/can/j1939/main.c:372 notifier_call_chain+0x59/0x90 kernel/notifier.c:84 call_netdevice_notifiers_info net/core/dev.c:1940 [inline] call_netdevice_notifiers_info net/core/dev.c:1925 [inline] call_netdevice_notifiers_extack net/core/dev.c:1978 [inline] call_netdevice_notifiers net/core/dev.c:1992 [inline] __dev_notify_flags+0xd8/0x180 net/core/dev.c:8451 dev_change_flags+0x46/0x50 net/core/dev.c:8487 do_setlink+0x31d/0x1230 net/core/rtnetlink.c:2731 __rtnl_newlink+0x592/0x9d0 net/core/rtnetlink.c:3416 rtnl_newlink+0x3e/0x60 net/core/rtnetlink.c:3531 rtnetlink_rcv_msg+0x156/0x4e0 net/core/rtnetlink.c:5979 netlink_rcv_skb+0x49/0xf0 net/netlink/af_netlink.c:2494 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x1af/0x280 net/netlink/af_netlink.c:1343 netlink_sendmsg+0x23f/0x4a0 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg+0x2b/0x40 net/socket.c:725 ____sys_sendmsg+0x246/0x260 net/socket.c:2413 ___sys_sendmsg+0x92/0xd0 net/socket.c:2467 __sys_sendmsg+0x71/0xc0 net/socket.c:2496 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x34/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae other info that might help us debug this: Chain exists of: &jsk->sk_session_queue_lock --> &priv->active_session_list_lock --> &priv->j1939_socks_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&priv->j1939_socks_lock); lock(&priv->active_session_list_lock); lock(&priv->j1939_socks_lock); lock(&jsk->sk_session_queue_lock); *** DEADLOCK *** 2 locks held by syz-executor.3/3710: #0: ffffffff83f7f448 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:72 [inline] #0: ffffffff83f7f448 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x12e/0x4e0 net/core/rtnetlink.c:5976 #1: ffff888112fe90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline] #1: ffff888112fe90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_netdev_event_netdown+0x1f/0x90 net/can/j1939/socket.c:1266 stack backtrace: CPU: 0 PID: 3710 Comm: syz-executor.3 Not tainted 5.17.0-rc6-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x6a/0x9b lib/dump_stack.c:106 check_noncircular+0xf2/0x110 kernel/locking/lockdep.c:2143 check_prev_add kernel/locking/lockdep.c:3063 [inline] check_prevs_add kernel/locking/lockdep.c:3186 [inline] validate_chain kernel/locking/lockdep.c:3801 [inline] __lock_acquire+0x1114/0x1b60 kernel/locking/lockdep.c:5027 lock_acquire kernel/locking/lockdep.c:5639 [inline] lock_acquire+0xc7/0x2f0 kernel/locking/lockdep.c:5604 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:354 [inline] j1939_sk_queue_drop_all+0x2b/0xd0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x44/0x90 net/can/j1939/socket.c:1272 j1939_netdev_notify+0x10c/0x160 net/can/j1939/main.c:372 notifier_call_chain+0x59/0x90 kernel/notifier.c:84 call_netdevice_notifiers_info net/core/dev.c:1940 [inline] call_netdevice_notifiers_info net/core/dev.c:1925 [inline] call_netdevice_notifiers_extack net/core/dev.c:1978 [inline] call_netdevice_notifiers net/core/dev.c:1992 [inline] __dev_notify_flags+0xd8/0x180 net/core/dev.c:8451 dev_change_flags+0x46/0x50 net/core/dev.c:8487 do_setlink+0x31d/0x1230 net/core/rtnetlink.c:2731 __rtnl_newlink+0x592/0x9d0 net/core/rtnetlink.c:3416 rtnl_newlink+0x3e/0x60 net/core/rtnetlink.c:3531 rtnetlink_rcv_msg+0x156/0x4e0 net/core/rtnetlink.c:5979 netlink_rcv_skb+0x49/0xf0 net/netlink/af_netlink.c:2494 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline] netlink_unicast+0x1af/0x280 net/netlink/af_netlink.c:1343 netlink_sendmsg+0x23f/0x4a0 net/netlink/af_netlink.c:1919 sock_sendmsg_nosec net/socket.c:705 [inline] sock_sendmsg+0x2b/0x40 net/socket.c:725 ____sys_sendmsg+0x246/0x260 net/socket.c:2413 ___sys_sendmsg+0x92/0xd0 net/socket.c:2467 __sys_sendmsg+0x71/0xc0 net/socket.c:2496 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x34/0x80 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x55eca035cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe529a580c8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 000055eca047c050 RCX: 000055eca035cae9 RDX: 0000000000000000 RSI: 0000000020000140 RDI: 0000000000000003 RBP: 000055eca03a847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 000055eca047c050 R15: 00007ffe25d83dc8