====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc7-syzkaller-gf5837722ffec #0 Not tainted ------------------------------------------------------ syz-executor.0/5469 is trying to acquire lock: ffff88806c9987c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x217/0x1b70 fs/hfsplus/extents.c:457 but task is already holding lock: ffff88806c9960b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd60 kernel/locking/mutex.c:747 hfsplus_file_truncate+0x80d/0xb40 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1b9/0x250 fs/hfsplus/inode.c:269 notify_change+0xb95/0xe60 fs/attr.c:499 do_truncate+0x21c/0x300 fs/open.c:66 handle_truncate fs/namei.c:3280 [inline] do_open fs/namei.c:3626 [inline] path_openat+0x29d9/0x3280 fs/namei.c:3779 do_filp_open+0x230/0x480 fs/namei.c:3809 do_sys_openat2+0x13a/0x1c0 fs/open.c:1437 do_sys_open fs/open.c:1452 [inline] __do_sys_creat fs/open.c:1528 [inline] __se_sys_creat fs/open.c:1522 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1522 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3a1d/0x7fb0 kernel/locking/lockdep.c:5137 lock_acquire+0x1df/0x520 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd60 kernel/locking/mutex.c:747 hfsplus_file_extend+0x217/0x1b70 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1cc/0x1050 fs/hfsplus/catalog.c:456 hfsplus_rename+0x12a/0x1b0 fs/hfsplus/dir.c:552 vfs_rename+0xab6/0xde0 fs/namei.c:4844 do_renameat2+0xd56/0x1390 fs/namei.c:4996 __do_sys_rename fs/namei.c:5042 [inline] __se_sys_rename fs/namei.c:5040 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5040 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz-executor.0/5469: #0: ffff88806c992418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:404 #1: ffff88806c999e00 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #1: ffff88806c999e00 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3046 [inline] #1: ffff88806c999e00 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: do_renameat2+0x5fd/0x1390 fs/namei.c:4935 #2: ffff88806d0b09c0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #2: ffff88806d0b09c0 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: lock_two_inodes+0xfc/0x180 fs/inode.c:1129 #3: ffff88806d0b1740 (&sb->s_type->i_mutex_key#21/4){+.+.}-{3:3}, at: vfs_rename+0x5e7/0xde0 fs/namei.c:4816 #4: ffff88806c9960b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 stack backtrace: CPU: 1 PID: 5469 Comm: syz-executor.0 Not tainted 6.7.0-rc7-syzkaller-gf5837722ffec #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x371/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3a1d/0x7fb0 kernel/locking/lockdep.c:5137 lock_acquire+0x1df/0x520 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd60 kernel/locking/mutex.c:747 hfsplus_file_extend+0x217/0x1b70 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1cc/0x1050 fs/hfsplus/catalog.c:456 hfsplus_rename+0x12a/0x1b0 fs/hfsplus/dir.c:552 vfs_rename+0xab6/0xde0 fs/namei.c:4844 do_renameat2+0xd56/0x1390 fs/namei.c:4996 __do_sys_rename fs/namei.c:5042 [inline] __se_sys_rename fs/namei.c:5040 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5040 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f10be27cce9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f10bf0b00c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f10be39bf80 RCX: 00007f10be27cce9 RDX: 0000000000000000 RSI: 0000000020000300 RDI: 0000000020000b00 RBP: 00007f10be2c947a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f10be39bf80 R15: 00007ffca0e16a68