syzbot


INFO: trying to register non-static key in uhid_dev_destroy

Status: fixed on 2020/09/20 13:43
Reported-by: syzbot+4a54b9a2797163403267@syzkaller.appspotmail.com
Fix commit: abae259fdccc HID: core: Correctly handle ReportSize being zero
First crash: 1550d, last: 1382d
Fix bisection: fixed by (bisect log) :
commit abae259fdccc5e41ff302dd80a2b944ce385c970
Author: Marc Zyngier <maz@kernel.org>
Date: Sat Aug 29 11:26:01 2020 +0000

  HID: core: Correctly handle ReportSize being zero

  
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream INFO: trying to register non-static key in uhid_dev_destroy input C unreliable done 40 1377d 1549d 15/26 fixed on 2020/11/16 12:12
linux-4.14 INFO: trying to register non-static key in uhid_dev_destroy C error 10 1469d 1543d 0/1 upstream: reported C repro on 2020/03/13 03:28
Fix bisection attempts (4)
Created Duration User Patch Repo Result
2020/09/19 18:55 3h19m bisect fix linux-4.19.y job log (1)
2020/08/20 18:25 30m bisect fix linux-4.19.y job log (0) log
2020/07/21 17:57 27m bisect fix linux-4.19.y job log (0) log
2020/05/24 14:23 25m bisect fix linux-4.19.y job log (0) log

Sample crash report:
hid-generic 0000:4000:0000.0580: ignoring exceeding usage max
hid-generic 0000:4000:0000.057F: hidraw1: <UNKNOWN> HID v0.00 Device [syz1] on sz1
hid-generic 0000:4000:0000.0580: hidraw2: <UNKNOWN> HID v0.00 Device [syz1] on sz1
hid-generic 0000:4000:0000.0581: ignoring exceeding usage max
hid-generic 0000:4000:0000.0581: hidraw0: <UNKNOWN> HID v0.00 Device [syz1] on sz1
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 1 PID: 24916 Comm: syz-executor134 Not tainted 4.19.118-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x188/0x20d lib/dump_stack.c:118
 assign_lock_key kernel/locking/lockdep.c:727 [inline]
 register_lock_class+0x14d0/0x16f0 kernel/locking/lockdep.c:753
 __lock_acquire+0x154/0x49c0 kernel/locking/lockdep.c:3303
 lock_acquire+0x170/0x400 kernel/locking/lockdep.c:3907
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0x8c/0xbf kernel/locking/spinlock.c:152
 __wake_up_common_lock+0xb0/0x170 kernel/sched/wait.c:120
 uhid_dev_destroy+0x6f/0x100 drivers/hid/uhid.c:566
 uhid_char_release+0x4e/0xb0 drivers/hid/uhid.c:645
 __fput+0x2cd/0x890 fs/file_table.c:278
 task_work_run+0x13f/0x1b0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0xbcd/0x2f30 kernel/exit.c:880
 do_group_exit+0x125/0x350 kernel/exit.c:983
 __do_sys_exit_group kernel/exit.c:994 [inline]
 __se_sys_exit_group kernel/exit.c:992 [inline]
 __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:992
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x43ff88
Code: Bad RIP value.
RSP: 002b:00007ffd7d665288 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000000000043ff88
RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000
RBP: 00000000004bfad0 R08: 00000000000000e7 R09: ffffffffffffffd0
R10: 00000000004002c8 R11: 0000000000000246 R12: 0000000000000001
R13: 00000000006d2180 R14: 0000000000000000 R15: 0000000000000000
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 24916 Comm: syz-executor134 Not tainted 4.19.118-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__wake_up_common+0xdf/0x640 kernel/sched/wait.c:85
Code: 05 00 00 4c 8b 43 38 49 83 e8 18 49 8d 78 18 48 39 3c 24 0f 84 6a 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 f9 48 c1 e9 03 <80> 3c 01 00 0f 85 3b 05 00 00 49 8b 40 18 89 54 24 10 31 db 48 bd
RSP: 0018:ffff888095dafb68 EFLAGS: 00010046
RAX: dffffc0000000000 RBX: ffff88809783c608 RCX: 0000000000000000
RDX: 0000000000000001 RSI: 1ffffffff12389f0 RDI: 0000000000000000
RBP: 0000000000000001 R08: ffffffffffffffe8 R09: ffff888095dafc08
R10: ffffed1012f078c1 R11: ffff88809783c60b R12: 0000000000000001
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000043ff5e CR3: 0000000008c6d000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __wake_up_common_lock+0xcd/0x170 kernel/sched/wait.c:121
 uhid_dev_destroy+0x6f/0x100 drivers/hid/uhid.c:566
 uhid_char_release+0x4e/0xb0 drivers/hid/uhid.c:645
 __fput+0x2cd/0x890 fs/file_table.c:278
 task_work_run+0x13f/0x1b0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0xbcd/0x2f30 kernel/exit.c:880
 do_group_exit+0x125/0x350 kernel/exit.c:983
 __do_sys_exit_group kernel/exit.c:994 [inline]
 __se_sys_exit_group kernel/exit.c:992 [inline]
 __x64_sys_exit_group+0x3a/0x50 kernel/exit.c:992
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x43ff88
Code: Bad RIP value.
RSP: 002b:00007ffd7d665288 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000000000043ff88
RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000
RBP: 00000000004bfad0 R08: 00000000000000e7 R09: ffffffffffffffd0
R10: 00000000004002c8 R11: 0000000000000246 R12: 0000000000000001
R13: 00000000006d2180 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace bed2bec6f7e735ba ]---
RIP: 0010:__wake_up_common+0xdf/0x640 kernel/sched/wait.c:85
Code: 05 00 00 4c 8b 43 38 49 83 e8 18 49 8d 78 18 48 39 3c 24 0f 84 6a 02 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 f9 48 c1 e9 03 <80> 3c 01 00 0f 85 3b 05 00 00 49 8b 40 18 89 54 24 10 31 db 48 bd
RSP: 0018:ffff888095dafb68 EFLAGS: 00010046
RAX: dffffc0000000000 RBX: ffff88809783c608 RCX: 0000000000000000
RDX: 0000000000000001 RSI: 1ffffffff12389f0 RDI: 0000000000000000
RBP: 0000000000000001 R08: ffffffffffffffe8 R09: ffff888095dafc08
R10: ffffed1012f078c1 R11: ffff88809783c60b R12: 0000000000000001
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000043ff5e CR3: 0000000008c6d000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (14):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/04/24 14:23 linux-4.19.y 7edd66cf6167 03d97a1b .config console log report syz C ci2-linux-4-19
2020/04/04 05:47 linux-4.19.y dda0e2920330 ef26b610 .config console log report syz C ci2-linux-4-19
2020/03/26 20:53 linux-4.19.y 54b4fa6d3955 6d25c5a0 .config console log report syz C ci2-linux-4-19
2020/03/26 08:53 linux-4.19.y 54b4fa6d3955 e8e6c7d2 .config console log report syz C ci2-linux-4-19
2020/03/24 22:55 linux-4.19.y 14cfdbd39e31 68660b21 .config console log report syz C ci2-linux-4-19
2020/03/24 11:45 linux-4.19.y 14cfdbd39e31 33e14df3 .config console log report syz C ci2-linux-4-19
2020/03/13 02:02 linux-4.19.y 569209711609 d850e9d0 .config console log report syz C ci2-linux-4-19
2020/03/06 07:23 linux-4.19.y 7472c4028e23 b655d91b .config console log report syz C ci2-linux-4-19
2020/03/26 09:28 linux-4.19.y 54b4fa6d3955 e8e6c7d2 .config console log report syz ci2-linux-4-19
2020/03/19 17:58 linux-4.19.y 93556fb211fa 2c31c529 .config console log report syz ci2-linux-4-19
2020/03/13 18:14 linux-4.19.y 569209711609 fd69032d .config console log report syz ci2-linux-4-19
2020/06/21 17:56 linux-4.19.y 3fc898571b97 4f2acff9 .config console log report ci2-linux-4-19
2020/06/06 11:34 linux-4.19.y 4707d8e57273 c3e9afb3 .config console log report ci2-linux-4-19
2020/04/24 11:59 linux-4.19.y 7edd66cf6167 03d97a1b .config console log report ci2-linux-4-19
* Struck through repros no longer work on HEAD.