syzbot


possible deadlock in j1939_sk_errqueue

Status: upstream: reported C repro on 2023/07/09 02:39
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+0fcac9a36f660a71acdd@syzkaller.appspotmail.com
First crash: 351d, last: 122d
Fix bisection: failed (error log, bisect log)
  
Bug presence (2)
Date Name Commit Repro Result
2024/04/28 linux-6.1.y (ToT) f2295faba5e8 C [report] INFO: rcu detected stall in corrupted
2024/04/28 upstream (ToT) 2c8159388952 C Didn't crash
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in j1939_sk_errqueue origin:upstream C error 6 156d 332d 0/3 upstream: reported C repro on 2023/07/28 13:47
upstream possible deadlock in j1939_sk_errqueue can C unreliable 227 453d 990d 22/27 fixed on 2023/06/08 14:41
upstream possible deadlock in j1939_sk_errqueue (2) can C done 24 130d 356d 26/27 fixed on 2024/03/26 17:39
Fix bisection attempts (2)
Created Duration User Patch Repo Result
2023/11/24 15:48 2h04m fix candidate upstream job log (0)
2023/10/02 23:31 10m bisect fix linux-6.1.y error job log (0)

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.43-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor108/4433 is trying to acquire lock:
ffff0000e05690d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
ffff0000e05690d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0x90/0x144 net/can/j1939/socket.c:1081

but task is already holding lock:
ffff0000e0569088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
ffff0000e0569088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff0000e0569088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_cancel_active_session+0x54/0x414 net/can/j1939/transport.c:2183

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&priv->active_session_list_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x54/0x6c kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:355 [inline]
       j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
       j1939_session_activate+0x60/0x378 net/can/j1939/transport.c:1564
       j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
       j1939_sk_queue_activate_next+0x230/0x3b4 net/can/j1939/socket.c:208
       j1939_session_deactivate_activate_next net/can/j1939/transport.c:1108 [inline]
       j1939_session_completed net/can/j1939/transport.c:1222 [inline]
       j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1395 [inline]
       j1939_xtp_rx_eoma+0x2c0/0x4c0 net/can/j1939/transport.c:1410
       j1939_tp_cmd_recv net/can/j1939/transport.c:2099 [inline]
       j1939_tp_recv+0x714/0xe14 net/can/j1939/transport.c:2144
       j1939_can_recv+0x5d0/0x948 net/can/j1939/main.c:112
       deliver net/can/af_can.c:573 [inline]
       can_rcv_filter+0x308/0x714 net/can/af_can.c:607
       can_receive+0x338/0x498 net/can/af_can.c:664
       can_rcv+0x128/0x240 net/can/af_can.c:688
       __netif_receive_skb_one_core net/core/dev.c:5496 [inline]
       __netif_receive_skb+0x18c/0x400 net/core/dev.c:5610
       process_backlog+0x410/0x784 net/core/dev.c:5938
       __napi_poll+0xb4/0x3f0 net/core/dev.c:6505
       napi_poll net/core/dev.c:6572 [inline]
       net_rx_action+0x5cc/0xd3c net/core/dev.c:6683
       __do_softirq+0x30c/0xea0 kernel/softirq.c:571
       run_ksoftirqd+0x68/0x258 kernel/softirq.c:934
       smpboot_thread_fn+0x4b0/0x96c kernel/smpboot.c:164
       kthread+0x250/0x2d8 kernel/kthread.c:376
       ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860

-> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x54/0x6c kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:355 [inline]
       j1939_sk_queue_drop_all+0x4c/0x200 net/can/j1939/socket.c:139
       j1939_sk_netdev_event_netdown+0xe0/0x144 net/can/j1939/socket.c:1280
       j1939_netdev_notify+0xf0/0x144 net/can/j1939/main.c:381
       notifier_call_chain kernel/notifier.c:87 [inline]
       raw_notifier_call_chain+0xd4/0x164 kernel/notifier.c:455
       __dev_notify_flags+0x2ac/0x534
       dev_change_flags+0xc8/0x154 net/core/dev.c:8626
       do_setlink+0xc70/0x3328 net/core/rtnetlink.c:2794
       __rtnl_newlink net/core/rtnetlink.c:3559 [inline]
       rtnl_newlink+0x13b8/0x1b04 net/core/rtnetlink.c:3606
       rtnetlink_rcv_msg+0x72c/0xd94 net/core/rtnetlink.c:6103
       netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2525
       rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:6121
       netlink_unicast_kernel net/netlink/af_netlink.c:1328 [inline]
       netlink_unicast+0x660/0x8d4 net/netlink/af_netlink.c:1354
       netlink_sendmsg+0x834/0xb18 net/netlink/af_netlink.c:1903
       sock_sendmsg_nosec net/socket.c:716 [inline]
       sock_sendmsg net/socket.c:736 [inline]
       ____sys_sendmsg+0x558/0x844 net/socket.c:2482
       ___sys_sendmsg net/socket.c:2536 [inline]
       __sys_sendmsg+0x26c/0x33c net/socket.c:2565
       __do_sys_sendmsg net/socket.c:2574 [inline]
       __se_sys_sendmsg net/socket.c:2572 [inline]
       __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2572
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x54/0x6c kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:355 [inline]
       j1939_sk_errqueue+0x90/0x144 net/can/j1939/socket.c:1081
       __j1939_session_release net/can/j1939/transport.c:294 [inline]
       kref_put include/linux/kref.h:65 [inline]
       j1939_session_put+0xf0/0x4b4 net/can/j1939/transport.c:299
       j1939_session_deactivate_locked net/can/j1939/transport.c:1086 [inline]
       j1939_cancel_active_session+0x2ec/0x414 net/can/j1939/transport.c:2194
       j1939_netdev_notify+0xe8/0x144 net/can/j1939/main.c:380
       notifier_call_chain kernel/notifier.c:87 [inline]
       raw_notifier_call_chain+0xd4/0x164 kernel/notifier.c:455
       __dev_notify_flags+0x2ac/0x534
       dev_change_flags+0xc8/0x154 net/core/dev.c:8626
       do_setlink+0xc70/0x3328 net/core/rtnetlink.c:2794
       __rtnl_newlink net/core/rtnetlink.c:3559 [inline]
       rtnl_newlink+0x13b8/0x1b04 net/core/rtnetlink.c:3606
       rtnetlink_rcv_msg+0x72c/0xd94 net/core/rtnetlink.c:6103
       netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2525
       rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:6121
       netlink_unicast_kernel net/netlink/af_netlink.c:1328 [inline]
       netlink_unicast+0x660/0x8d4 net/netlink/af_netlink.c:1354
       netlink_sendmsg+0x834/0xb18 net/netlink/af_netlink.c:1903
       sock_sendmsg_nosec net/socket.c:716 [inline]
       sock_sendmsg net/socket.c:736 [inline]
       ____sys_sendmsg+0x558/0x844 net/socket.c:2482
       ___sys_sendmsg net/socket.c:2536 [inline]
       __sys_sendmsg+0x26c/0x33c net/socket.c:2565
       __do_sys_sendmsg net/socket.c:2574 [inline]
       __se_sys_sendmsg net/socket.c:2572 [inline]
       __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2572
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

other info that might help us debug this:

Chain exists of:
  &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&priv->active_session_list_lock);
                               lock(&jsk->sk_session_queue_lock);
                               lock(&priv->active_session_list_lock);
  lock(&priv->j1939_socks_lock);

 *** DEADLOCK ***

2 locks held by syz-executor108/4433:
 #0: ffff800017e6fac8 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:74 [inline]
 #0: ffff800017e6fac8 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x6e8/0xd94 net/core/rtnetlink.c:6100
 #1: ffff0000e0569088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
 #1: ffff0000e0569088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
 #1: ffff0000e0569088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_cancel_active_session+0x54/0x414 net/can/j1939/transport.c:2183

stack backtrace:
CPU: 0 PID: 4433 Comm: syz-executor108 Not tainted 6.1.43-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x54/0x6c kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:355 [inline]
 j1939_sk_errqueue+0x90/0x144 net/can/j1939/socket.c:1081
 __j1939_session_release net/can/j1939/transport.c:294 [inline]
 kref_put include/linux/kref.h:65 [inline]
 j1939_session_put+0xf0/0x4b4 net/can/j1939/transport.c:299
 j1939_session_deactivate_locked net/can/j1939/transport.c:1086 [inline]
 j1939_cancel_active_session+0x2ec/0x414 net/can/j1939/transport.c:2194
 j1939_netdev_notify+0xe8/0x144 net/can/j1939/main.c:380
 notifier_call_chain kernel/notifier.c:87 [inline]
 raw_notifier_call_chain+0xd4/0x164 kernel/notifier.c:455
 __dev_notify_flags+0x2ac/0x534
 dev_change_flags+0xc8/0x154 net/core/dev.c:8626
 do_setlink+0xc70/0x3328 net/core/rtnetlink.c:2794
 __rtnl_newlink net/core/rtnetlink.c:3559 [inline]
 rtnl_newlink+0x13b8/0x1b04 net/core/rtnetlink.c:3606
 rtnetlink_rcv_msg+0x72c/0xd94 net/core/rtnetlink.c:6103
 netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2525
 rtnetlink_rcv+0x28/0x38 net/core/rtnetlink.c:6121
 netlink_unicast_kernel net/netlink/af_netlink.c:1328 [inline]
 netlink_unicast+0x660/0x8d4 net/netlink/af_netlink.c:1354
 netlink_sendmsg+0x834/0xb18 net/netlink/af_netlink.c:1903
 sock_sendmsg_nosec net/socket.c:716 [inline]
 sock_sendmsg net/socket.c:736 [inline]
 ____sys_sendmsg+0x558/0x844 net/socket.c:2482
 ___sys_sendmsg net/socket.c:2536 [inline]
 __sys_sendmsg+0x26c/0x33c net/socket.c:2565
 __do_sys_sendmsg net/socket.c:2574 [inline]
 __se_sys_sendmsg net/socket.c:2572 [inline]
 __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2572
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/08/05 09:40 linux-6.1.y 52a953d0934b cdae481e .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in j1939_sk_errqueue
2023/12/31 12:44 linux-6.1.y 4aa6747d9352 fb427a07 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in j1939_sk_errqueue
2024/02/23 01:06 linux-6.1.y 8b4118fabd6e 8d446f15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in j1939_sk_errqueue
2024/01/18 12:20 linux-6.1.y fec3b1451d5f 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in j1939_sk_errqueue
2024/01/18 11:04 linux-6.1.y fec3b1451d5f 915053c7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in j1939_sk_errqueue
2023/07/09 02:39 linux-6.1.y 61fd484b2cf6 668cb1fa .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in j1939_sk_errqueue
* Struck through repros no longer work on HEAD.