syzbot

======================================================
WARNING: possible circular locking dependency detected
6.1.126-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.141/4958 is trying to acquire lock:
ffff88807f334650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_info+0x124/0x3a0 fs/ocfs2/quota_global.c:977

but task is already holding lock:
ffff8880559f4da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:988
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:988
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6770
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space include/linux/quotaops.h:384 [inline]
       dquot_free_block include/linux/quotaops.h:395 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline]
       ext4_free_blocks+0x1fb4/0x3020 fs/ext4/mballoc.c:6273
       ext4_remove_blocks fs/ext4/extents.c:2525 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
       ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2939
       ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4469
       ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288
       ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286
       evict+0x529/0x930 fs/inode.c:705
       do_unlinkat+0x509/0x820 fs/namei.c:4397
       __do_sys_unlink fs/namei.c:4438 [inline]
       __se_sys_unlink fs/namei.c:4436 [inline]
       __x64_sys_unlink+0x45/0x50 fs/namei.c:4436
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_map_blocks+0x955/0x1cb0 fs/ext4/inode.c:671
       mpage_map_one_extent fs/ext4/inode.c:2433 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2486 [inline]
       ext4_writepages+0x1643/0x3de0 fs/ext4/inode.c:2854
       do_writepages+0x3a2/0x670 mm/page-writeback.c:2491
       __writeback_single_inode+0x15d/0x11e0 fs/fs-writeback.c:1612
       writeback_sb_inodes+0xc2b/0x1b20 fs/fs-writeback.c:1903
       __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:1974
       wb_writeback+0x4b1/0xe10 fs/fs-writeback.c:2079
       wb_check_background_flush fs/fs-writeback.c:2145 [inline]
       wb_do_writeback fs/fs-writeback.c:2233 [inline]
       wb_workfn+0xc9e/0x1020 fs/fs-writeback.c:2260
       process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
       worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
       kthread+0x28d/0x320 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295

-> #2 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xc4c/0x29d0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_symlink+0x14e9/0x2f00 fs/ocfs2/namei.c:1908
       vfs_symlink+0x247/0x3d0 fs/namei.c:4471
       do_symlinkat+0x21e/0x390 fs/namei.c:4500
       __do_sys_symlink fs/namei.c:4522 [inline]
       __se_sys_symlink fs/namei.c:4520 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4520
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xc4c/0x29d0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_symlink+0x14e9/0x2f00 fs/ocfs2/namei.c:1908
       vfs_symlink+0x247/0x3d0 fs/namei.c:4471
       do_symlinkat+0x21e/0x390 fs/namei.c:4500
       __do_sys_symlink fs/namei.c:4522 [inline]
       __se_sys_symlink fs/namei.c:4520 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4520
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#5){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_write_info+0x124/0x3a0 fs/ocfs2/quota_global.c:977
       dquot_set_dqinfo+0x488/0x6f0 fs/quota/dquot.c:2911
       quota_setinfo+0x3d6/0x4f0 fs/quota/quota.c:174
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#5);

 *** DEADLOCK ***

3 locks held by syz.1.141/4958:
 #0: ffff88807f3340e0 (&type->s_umount_key#95){++++}-{3:3}, at: user_get_super+0x11a/0x250 fs/super.c:889
 #1: ffff8880559f5108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff8880559f5108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
 #2: ffff8880559f4da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 1 PID: 4958 Comm: syz.1.141 Not tainted 6.1.126-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
 ocfs2_write_info+0x124/0x3a0 fs/ocfs2/quota_global.c:977
 dquot_set_dqinfo+0x488/0x6f0 fs/quota/dquot.c:2911
 quota_setinfo+0x3d6/0x4f0 fs/quota/quota.c:174
 __do_sys_quotactl fs/quota/quota.c:960 [inline]
 __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fd9fd585d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd9fe452038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3
RAX: ffffffffffffffda RBX: 00007fd9fd776080 RCX: 00007fd9fd585d29
RDX: 0000000000000000 RSI: 0000000020000100 RDI: ffffffff80000600
RBP: 00007fd9fd601b08 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000200000c0 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fd9fd776080 R15: 00007ffd531e9c08
 </TASK>