syzbot


WARNING: bad unlock balance in ocfs2_read_blocks

Status: upstream: reported on 2024/09/17 05:01
Reported-by: syzbot+213c33114cacb17f4d01@syzkaller.appspotmail.com
First crash: 11d, last: 1d15h
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 WARNING: bad unlock balance in ocfs2_read_blocks origin:upstream C 7 6d02h 10d 0/3 upstream: reported C repro on 2024/09/17 16:46
upstream WARNING: bad unlock balance in ocfs2_read_blocks ocfs2 C 240 8d13h 40d 25/28 upstream: reported C repro on 2024/08/18 17:06

Sample crash report:
(syz.3.20,3831,1):ocfs2_read_blocks:240 ERROR: status = -12
=====================================
WARNING: bad unlock balance detected!
6.1.111-syzkaller #0 Not tainted
-------------------------------------
syz.3.20/3831 is trying to release lock (&oi->ip_io_mutex) at:
[<ffffffff835b713f>] ocfs2_read_blocks+0x11ef/0x16e0 fs/ocfs2/buffer_head_io.c:394
but there are no more locks to release!

other info that might help us debug this:
8 locks held by syz.3.20/3831:
 #0: ffff888026772460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
 #1: ffff88805c64c2c8 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88805c64c2c8 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: vfs_setxattr+0x1dd/0x420 fs/xattr.c:308
 #2: ffff88805c64bff8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x62f/0x1930 fs/ocfs2/xattr.c:3579
 #3: ffff88805c62ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff88805c62ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x182/0x5190 fs/ocfs2/suballoc.c:782
 #4: ffff88805c62d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff88805c62d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x182/0x5190 fs/ocfs2/suballoc.c:782
 #5: ffff888026772650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_block_group_alloc fs/ocfs2/suballoc.c:681 [inline]
 #5: ffff888026772650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_reserve_suballoc_bits+0x8f8/0x5190 fs/ocfs2/suballoc.c:828
 #6: ffff888059b014e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
 #7: ffff8880273f8990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f51/0x21b0 fs/jbd2/transaction.c:463

stack backtrace:
CPU: 1 PID: 3831 Comm: syz.3.20 Not tainted 6.1.111-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 print_unlock_imbalance_bug+0x24e/0x2c0 kernel/locking/lockdep.c:5102
 __lock_release kernel/locking/lockdep.c:5339 [inline]
 lock_release+0x5ad/0xa20 kernel/locking/lockdep.c:5682
 __mutex_unlock_slowpath+0xde/0x750 kernel/locking/mutex.c:907
 ocfs2_read_blocks+0x11ef/0x16e0 fs/ocfs2/buffer_head_io.c:394
 ocfs2_read_block fs/ocfs2/buffer_head_io.h:52 [inline]
 ocfs2_read_group_descriptor fs/ocfs2/suballoc.c:299 [inline]
 ocfs2_search_chain+0x2d1/0x2640 fs/ocfs2/suballoc.c:1757
 ocfs2_claim_suballoc_bits+0x1201/0x2560 fs/ocfs2/suballoc.c:1930
 __ocfs2_claim_clusters+0x327/0xa30 fs/ocfs2/suballoc.c:2338
 ocfs2_claim_clusters fs/ocfs2/suballoc.c:2375 [inline]
 ocfs2_block_group_alloc_contig fs/ocfs2/suballoc.c:428 [inline]
 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:695 [inline]
 ocfs2_reserve_suballoc_bits+0x1241/0x5190 fs/ocfs2/suballoc.c:828
 ocfs2_reserve_new_metadata_blocks+0x418/0x9b0 fs/ocfs2/suballoc.c:978
 ocfs2_init_xattr_set_ctxt+0x3ab/0x950 fs/ocfs2/xattr.c:3273
 ocfs2_xattr_set+0xf46/0x1930 fs/ocfs2/xattr.c:3630
 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x21d/0x420 fs/xattr.c:309
 do_setxattr fs/xattr.c:594 [inline]
 setxattr+0x250/0x2b0 fs/xattr.c:617
 path_setxattr+0x1bc/0x2a0 fs/xattr.c:636
 __do_sys_lsetxattr fs/xattr.c:659 [inline]
 __se_sys_lsetxattr fs/xattr.c:655 [inline]
 __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:655
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f533837df39
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5339243038 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 00007f5338536058 RCX: 00007f533837df39
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000020000080
RBP: 00007f53383f0216 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f5338536058 R15: 00007fff7ac78b58
 </TASK>
(syz.3.20,3831,0):ocfs2_search_chain:1761 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_search_chain:1871 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_claim_suballoc_bits:1940 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_claim_suballoc_bits:1983 ERROR: status = -12
(syz.3.20,3831,0):__ocfs2_claim_clusters:2355 ERROR: status = -12
(syz.3.20,3831,0):__ocfs2_claim_clusters:2363 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_block_group_alloc_contig:433 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_block_group_alloc:705 ERROR: status = -12
(syz.3.20,3831,1):ocfs2_block_group_alloc:758 ERROR: status = -12
(syz.3.20,3831,1):ocfs2_reserve_suballoc_bits:833 ERROR: status = -12
(syz.3.20,3831,1):ocfs2_reserve_suballoc_bits:850 ERROR: status = -12
(syz.3.20,3831,1):ocfs2_reserve_new_metadata_blocks:990 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_reserve_new_metadata_blocks:1013 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_init_xattr_set_ctxt:3276 ERROR: status = -12
(syz.3.20,3831,0):ocfs2_xattr_set:3633 ERROR: status = -12

Crashes (12):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/26 20:36 linux-6.1.y e526b12bf916 9314348a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/26 10:14 linux-6.1.y e526b12bf916 0d19f247 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/26 10:08 linux-6.1.y e526b12bf916 0d19f247 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/26 10:06 linux-6.1.y e526b12bf916 0d19f247 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/26 10:04 linux-6.1.y e526b12bf916 0d19f247 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/26 10:04 linux-6.1.y e526b12bf916 0d19f247 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/24 11:08 linux-6.1.y e526b12bf916 89298aad .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/24 11:08 linux-6.1.y e526b12bf916 89298aad .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/24 04:57 linux-6.1.y e526b12bf916 89298aad .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/24 04:57 linux-6.1.y e526b12bf916 89298aad .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/17 05:01 linux-6.1.y 5f55cad62cc9 c673ca06 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
2024/09/17 05:00 linux-6.1.y 5f55cad62cc9 c673ca06 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan WARNING: bad unlock balance in ocfs2_read_blocks
* Struck through repros no longer work on HEAD.