syzbot


possible deadlock in __mmap_lock_do_trace_acquire_returned

Status: upstream: reported C repro on 2024/04/13 06:55
Bug presence: origin:upstream
[Documentation on labels]
Reported-by: syzbot+351f700c0b4cbf13a0b2@syzkaller.appspotmail.com
First crash: 20d, last: 12d
Bug presence (1)
Date Name Commit Repro Result
2024/04/29 upstream (ToT) e67572cd2204 C [report] possible deadlock in __mmap_lock_do_trace_acquire_returned

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.87-syzkaller #0 Not tainted
------------------------------------------------------
dhcpcd/3216 is trying to acquire lock:
ffff8880b9835e90 (lock#9){+.+.}-{2:2}, at: local_lock_acquire include/linux/local_lock_internal.h:29 [inline]
ffff8880b9835e90 (lock#9){+.+.}-{2:2}, at: __mmap_lock_do_trace_acquire_returned+0x84/0x670 mm/mmap_lock.c:237

but task is already holding lock:
ffff8880b983aa18 (&rq->__lock){-.-.}-{2:2}, at: raw_spin_rq_lock_nested+0x26/0x140 kernel/sched/core.c:537

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&rq->__lock){-.-.}-{2:2}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       _raw_spin_lock_nested+0x2d/0x40 kernel/locking/spinlock.c:378
       raw_spin_rq_lock_nested+0x26/0x140 kernel/sched/core.c:537
       raw_spin_rq_lock kernel/sched/sched.h:1354 [inline]
       rq_lock kernel/sched/sched.h:1644 [inline]
       task_fork_fair+0x5d/0x350 kernel/sched/fair.c:11869
       sched_cgroup_fork+0x374/0x400 kernel/sched/core.c:4686
       copy_process+0x2442/0x4060 kernel/fork.c:2384
       kernel_clone+0x222/0x920 kernel/fork.c:2682
       user_mode_thread+0x12e/0x190 kernel/fork.c:2758
       rest_init+0x23/0x300 init/main.c:697
       start_kernel+0x0/0x53f init/main.c:892
       start_kernel+0x496/0x53f init/main.c:1139
       secondary_startup_64_no_verify+0xcf/0xdb

-> #2 (&p->pi_lock){-.-.}-{2:2}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
       _raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
       try_to_wake_up+0xad/0x12e0 kernel/sched/core.c:4112
       signal_wake_up_state kernel/signal.c:780 [inline]
       signal_wake_up include/linux/sched/signal.h:457 [inline]
       complete_signal+0x796/0xbd0 kernel/signal.c:1074
       __send_signal_locked+0xb1a/0xdc0 kernel/signal.c:1194
       do_notify_parent+0xe2b/0x1100 kernel/signal.c:2120
       exit_notify kernel/exit.c:744 [inline]
       do_exit+0x172e/0x26a0 kernel/exit.c:889
       do_group_exit+0x202/0x2b0 kernel/exit.c:1019
       __do_sys_exit_group kernel/exit.c:1030 [inline]
       __se_sys_exit_group kernel/exit.c:1028 [inline]
       __x64_sys_exit_group+0x3b/0x40 kernel/exit.c:1028
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&sighand->siglock){....}-{2:2}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
       _raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
       __lock_task_sighand+0x145/0x2d0 kernel/signal.c:1410
       lock_task_sighand include/linux/sched/signal.h:745 [inline]
       do_send_sig_info kernel/signal.c:1299 [inline]
       group_send_sig_info+0x26c/0x300 kernel/signal.c:1448
       bpf_send_signal_common+0x2d8/0x420 kernel/trace/bpf_trace.c:882
       ____bpf_send_signal kernel/trace/bpf_trace.c:887 [inline]
       bpf_send_signal+0x15/0x20 kernel/trace/bpf_trace.c:885
       0xffffffffa000096e
       bpf_dispatcher_nop_func include/linux/bpf.h:989 [inline]
       __bpf_prog_run include/linux/filter.h:603 [inline]
       bpf_prog_run include/linux/filter.h:610 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2273 [inline]
       bpf_trace_run4+0x253/0x470 kernel/trace/bpf_trace.c:2314
       trace_mmap_lock_acquire_returned include/trace/events/mmap_lock.h:52 [inline]
       __mmap_lock_do_trace_acquire_returned+0x5e3/0x670 mm/mmap_lock.c:237
       __mmap_lock_trace_acquire_returned include/linux/mmap_lock.h:36 [inline]
       mmap_read_trylock include/linux/mmap_lock.h:137 [inline]
       get_mmap_lock_carefully mm/memory.c:5304 [inline]
       lock_mm_and_find_vma+0x219/0x2e0 mm/memory.c:5366
       do_user_addr_fault arch/x86/mm/fault.c:1343 [inline]
       handle_page_fault arch/x86/mm/fault.c:1462 [inline]
       exc_page_fault+0x169/0x660 arch/x86/mm/fault.c:1518
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
       strncpy_from_user+0x159/0x360 lib/strncpy_from_user.c:139
       strncpy_from_bpfptr include/linux/bpfptr.h:85 [inline]
       bpf_prog_load+0x188/0x1bb0 kernel/bpf/syscall.c:2515
       __sys_bpf+0x382/0x6c0 kernel/bpf/syscall.c:5005
       __do_sys_bpf kernel/bpf/syscall.c:5109 [inline]
       __se_sys_bpf kernel/bpf/syscall.c:5107 [inline]
       __x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:5107
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (lock#9){+.+.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       local_lock_acquire include/linux/local_lock_internal.h:29 [inline]
       __mmap_lock_do_trace_acquire_returned+0x9d/0x670 mm/mmap_lock.c:237
       __mmap_lock_trace_acquire_returned include/linux/mmap_lock.h:36 [inline]
       mmap_read_trylock include/linux/mmap_lock.h:137 [inline]
       stack_map_get_build_id_offset+0x99e/0x9c0 kernel/bpf/stackmap.c:144
       __bpf_get_stack+0x495/0x570 kernel/bpf/stackmap.c:452
       ____bpf_get_stack_raw_tp kernel/trace/bpf_trace.c:1877 [inline]
       bpf_get_stack_raw_tp+0x1b2/0x220 kernel/trace/bpf_trace.c:1867
       bpf_prog_e6cf5f9c69743609+0x3a/0x3e
       bpf_dispatcher_nop_func include/linux/bpf.h:989 [inline]
       __bpf_prog_run include/linux/filter.h:603 [inline]
       bpf_prog_run include/linux/filter.h:610 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2273 [inline]
       bpf_trace_run4+0x253/0x470 kernel/trace/bpf_trace.c:2314
       trace_sched_switch include/trace/events/sched.h:222 [inline]
       __schedule+0x2116/0x4550 kernel/sched/core.c:6555
       schedule+0xbf/0x180 kernel/sched/core.c:6634
       schedule_hrtimeout_range_clock+0x2a4/0x480 kernel/time/hrtimer.c:2308
       poll_schedule_timeout fs/select.c:244 [inline]
       do_poll fs/select.c:965 [inline]
       do_sys_poll+0xe1c/0x1330 fs/select.c:1015
       __do_sys_ppoll fs/select.c:1121 [inline]
       __se_sys_ppoll+0x29c/0x330 fs/select.c:1101
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  lock#9 --> &p->pi_lock --> &rq->__lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&rq->__lock);
                               lock(&p->pi_lock);
                               lock(&rq->__lock);
  lock(lock#9);

 *** DEADLOCK ***

3 locks held by dhcpcd/3216:
 #0: ffff8880b983aa18 (&rq->__lock){-.-.}-{2:2}, at: raw_spin_rq_lock_nested+0x26/0x140 kernel/sched/core.c:537
 #1: ffffffff8d12ac80 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:350 [inline]
 #1: ffffffff8d12ac80 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:791 [inline]
 #1: ffffffff8d12ac80 (rcu_read_lock){....}-{1:2}, at: __bpf_trace_run kernel/trace/bpf_trace.c:2272 [inline]
 #1: ffffffff8d12ac80 (rcu_read_lock){....}-{1:2}, at: bpf_trace_run4+0x16a/0x470 kernel/trace/bpf_trace.c:2314
 #2: ffff88801874a6d8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_trylock include/linux/mmap_lock.h:136 [inline]
 #2: ffff88801874a6d8 (&mm->mmap_lock){++++}-{3:3}, at: stack_map_get_build_id_offset+0x232/0x9c0 kernel/bpf/stackmap.c:144

stack backtrace:
CPU: 0 PID: 3216 Comm: dhcpcd Not tainted 6.1.87-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 local_lock_acquire include/linux/local_lock_internal.h:29 [inline]
 __mmap_lock_do_trace_acquire_returned+0x9d/0x670 mm/mmap_lock.c:237
 __mmap_lock_trace_acquire_returned include/linux/mmap_lock.h:36 [inline]
 mmap_read_trylock include/linux/mmap_lock.h:137 [inline]
 stack_map_get_build_id_offset+0x99e/0x9c0 kernel/bpf/stackmap.c:144
 __bpf_get_stack+0x495/0x570 kernel/bpf/stackmap.c:452
 ____bpf_get_stack_raw_tp kernel/trace/bpf_trace.c:1877 [inline]
 bpf_get_stack_raw_tp+0x1b2/0x220 kernel/trace/bpf_trace.c:1867
 bpf_prog_e6cf5f9c69743609+0x3a/0x3e
 bpf_dispatcher_nop_func include/linux/bpf.h:989 [inline]
 __bpf_prog_run include/linux/filter.h:603 [inline]
 bpf_prog_run include/linux/filter.h:610 [inline]
 __bpf_trace_run kernel/trace/bpf_trace.c:2273 [inline]
 bpf_trace_run4+0x253/0x470 kernel/trace/bpf_trace.c:2314
 trace_sched_switch include/trace/events/sched.h:222 [inline]
 __schedule+0x2116/0x4550 kernel/sched/core.c:6555
 schedule+0xbf/0x180 kernel/sched/core.c:6634
 schedule_hrtimeout_range_clock+0x2a4/0x480 kernel/time/hrtimer.c:2308
 poll_schedule_timeout fs/select.c:244 [inline]
 do_poll fs/select.c:965 [inline]
 do_sys_poll+0xe1c/0x1330 fs/select.c:1015
 __do_sys_ppoll fs/select.c:1121 [inline]
 __se_sys_ppoll+0x29c/0x330 fs/select.c:1101
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f391315bad5
Code: 85 d2 74 0d 0f 10 02 48 8d 54 24 20 0f 11 44 24 20 64 8b 04 25 18 00 00 00 85 c0 75 27 41 b8 08 00 00 00 b8 0f 01 00 00 0f 05 <48> 3d 00 f0 ff ff 76 75 48 8b 15 24 73 0d 00 f7 d8 64 89 02 48 83
RSP: 002b:00007ffe794f2ea0 EFLAGS: 00000246 ORIG_RAX: 000000000000010f
RAX: ffffffffffffffda RBX: 000055cffd8eee20 RCX: 00007f391315bad5
RDX: 00007ffe794f2ec0 RSI: 0000000000000004 RDI: 000055cffd8f9b60
RBP: 00007ffe794f31f0 R08: 0000000000000008 R09: 0000000000000010
R10: 00007ffe794f31f0 R11: 0000000000000246 R12: 00007ffe794f2ee8
R13: 000055cffd3b9610 R14: 0000000000000000 R15: 0000000000000000
 </TASK>

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/04/20 22:07 linux-6.1.y 6741e066ec76 af24b050 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-perf possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/14 15:45 linux-6.1.y cd5d98c0556c c8349e48 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-perf possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/18 09:28 linux-6.1.y 6741e066ec76 af24b050 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/18 09:28 linux-6.1.y 6741e066ec76 af24b050 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/16 16:40 linux-6.1.y cd5d98c0556c 18f6e127 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-perf possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/15 16:23 linux-6.1.y cd5d98c0556c b9af7e61 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/13 22:01 linux-6.1.y cd5d98c0556c c8349e48 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-perf possible deadlock in __mmap_lock_do_trace_acquire_returned
2024/04/13 06:55 linux-6.1.y bf1e3b1cb1e0 c8349e48 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in __mmap_lock_do_trace_acquire_returned
* Struck through repros no longer work on HEAD.