syzbot


WARNING in isotp_tx_timer_handler

Status: fixed on 2023/12/03 08:04
Reported-by: syzbot+3a3c13a104534637475b@syzkaller.appspotmail.com
Fix commit: e163ad6a8639 can: isotp: add local echo tx processing and tx without FC
First crash: 591d, last: 387d
Fix bisection: fixed by (bisect log) :
commit e163ad6a8639bb28f5aee683f04929cb07dd5990
Author: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Tue Oct 31 09:30:23 2023 +0000

  can: isotp: add local echo tx processing and tx without FC

  
Bug presence (1)
Date Name Commit Repro Result
2023/08/02 upstream (ToT) 5d0c230f1de8 C Didn't crash
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream WARNING in isotp_tx_timer_handler can C error 1553 990d 1433d 20/28 fixed on 2022/03/08 16:11
upstream WARNING in isotp_tx_timer_handler (2) can C 1416 663d 986d 22/28 fixed on 2023/02/24 13:50
Fix bisection attempts (3)
Created Duration User Patch Repo Result
2023/12/03 01:59 4h46m bisect fix linux-5.15.y OK (1) job log
2023/11/01 15:56 2h49m bisect fix linux-5.15.y OK (0) job log log
2023/10/02 05:35 2h00m bisect fix linux-5.15.y OK (0) job log log

Sample crash report:
------------[ cut here ]------------
WARNING: CPU: 1 PID: 3544 at net/can/isotp.c:853 isotp_tx_timer_handler+0xb47/0xed0
Modules linked in:
CPU: 1 PID: 3544 Comm: syz-executor146 Not tainted 5.15.123-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023
RIP: 0010:isotp_tx_timer_handler+0xb47/0xed0 net/can/isotp.c:853
Code: 00 00 00 00 00 00 49 81 c5 a8 40 00 00 31 db 4c 89 ef be 01 00 00 00 ba 01 00 00 00 31 c9 e8 70 cc 26 f8 eb 57 e8 89 58 47 f8 <0f> 0b eb 4c e8 80 58 47 f8 eb 45 4c 8b 74 24 30 49 81 c6 a8 05 00
RSP: 0018:ffffc90000dd0b20 EFLAGS: 00010246
RAX: ffffffff8938a7e7 RBX: 0000000000000000 RCX: ffff8880155d9dc0
RDX: 0000000000000101 RSI: ffffffff8db298c0 RDI: 0000000000000000
RBP: ffffc90000dd0c70 R08: 0000000000000005 R09: ffffffff89389d7b
R10: 0000000000000003 R11: ffff8880155d9dc0 R12: 0000000000000000
R13: ffff88806b6a0578 R14: ffff88806b6a25fc R15: dffffc0000000000
FS:  00005555559dd480(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00005555559e67f8 CR3: 00000000741ab000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <IRQ>
 __run_hrtimer kernel/time/hrtimer.c:1685 [inline]
 __hrtimer_run_queues+0x598/0xcf0 kernel/time/hrtimer.c:1749
 hrtimer_run_softirq+0x196/0x2c0 kernel/time/hrtimer.c:1766
 __do_softirq+0x3b3/0x93a kernel/softirq.c:558
 invoke_softirq kernel/softirq.c:432 [inline]
 __irq_exit_rcu+0x155/0x240 kernel/softirq.c:636
 irq_exit_rcu+0x5/0x20 kernel/softirq.c:648
 sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1096
 </IRQ>
 <TASK>
 asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:638
RIP: 0010:console_unlock+0xe53/0x12b0 kernel/printk/printk.c:2739
Code: 00 48 83 7c 24 18 00 75 19 e8 79 e4 19 00 eb 18 e8 72 e4 19 00 e8 8d ec b5 08 48 83 7c 24 18 00 74 e7 e8 60 e4 19 00 fb 31 ff <44> 89 f6 e8 b5 e7 19 00 31 db 45 85 f6 0f 95 c0 89 c1 0a 4c 24 17
RSP: 0018:ffffc900026bf820 EFLAGS: 00000246
RAX: ffffffff81661c10 RBX: 0000000000000000 RCX: ffff8880155d9dc0
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: ffffc900026bfab0 R08: ffffffff81661bdb R09: fffffbfff1f7aa21
R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffffffff1a4a682
R13: ffffffff8d253448 R14: 0000000000000000 R15: dffffc0000000000
 vprintk_emit+0xba/0x150 kernel/printk/printk.c:2268
 _printk+0xd1/0x111 kernel/printk/printk.c:2289
 __xfs_printk fs/xfs/xfs_message.c:24 [inline]
 xfs_notice+0x1c8/0x320 fs/xfs/xfs_message.c:56
 xfs_fs_put_super+0x55/0x2b0 fs/xfs/xfs_super.c:1088
 generic_shutdown_super+0x136/0x2c0 fs/super.c:475
 kill_block_super+0x7a/0xe0 fs/super.c:1405
 deactivate_locked_super+0xa0/0x110 fs/super.c:335
 cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
 task_work_run+0x129/0x1a0 kernel/task_work.c:164
 tracehook_notify_resume include/linux/tracehook.h:189 [inline]
 exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:175
 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:208
 __syscall_exit_to_user_mode_work kernel/entry/common.c:290 [inline]
 syscall_exit_to_user_mode+0x5d/0x250 kernel/entry/common.c:301
 do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7ffaa5b38477
Code: 00 00 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 b0 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007fff7782dce8 EFLAGS: 00000206 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007ffaa5b38477
RDX: 0000000000000000 RSI: 000000000000000a RDI: 00007fff7782dda0
RBP: 00007fff7782dda0 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000206 R12: 00007fff7782ee60
R13: 00005555559de7c0 R14: 00007fff7782eea0 R15: 0000000000000022
 </TASK>
----------------
Code disassembly (best guess):
   0:	00 48 83             	add    %cl,-0x7d(%rax)
   3:	7c 24                	jl     0x29
   5:	18 00                	sbb    %al,(%rax)
   7:	75 19                	jne    0x22
   9:	e8 79 e4 19 00       	call   0x19e487
   e:	eb 18                	jmp    0x28
  10:	e8 72 e4 19 00       	call   0x19e487
  15:	e8 8d ec b5 08       	call   0x8b5eca7
  1a:	48 83 7c 24 18 00    	cmpq   $0x0,0x18(%rsp)
  20:	74 e7                	je     0x9
  22:	e8 60 e4 19 00       	call   0x19e487
  27:	fb                   	sti
  28:	31 ff                	xor    %edi,%edi
* 2a:	44 89 f6             	mov    %r14d,%esi <-- trapping instruction
  2d:	e8 b5 e7 19 00       	call   0x19e7e7
  32:	31 db                	xor    %ebx,%ebx
  34:	45 85 f6             	test   %r14d,%r14d
  37:	0f 95 c0             	setne  %al
  3a:	89 c1                	mov    %eax,%ecx
  3c:	0a 4c 24 17          	or     0x17(%rsp),%cl

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/08/01 14:25 linux-5.15.y 09996673e313 2a0d0f29 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan WARNING in isotp_tx_timer_handler
2023/08/01 01:25 linux-5.15.y 09996673e313 2a0d0f29 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan WARNING in isotp_tx_timer_handler
2023/04/11 23:46 linux-5.15.y d86dfc4d95cd 49faf98d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan WARNING in isotp_tx_timer_handler
* Struck through repros no longer work on HEAD.