syzbot


inconsistent lock state in sync_timeline_debug_remove

Status: upstream: reported C repro on 2024/01/09 18:24
Bug presence: origin:upstream
Labels: missing-backport
[Documentation on labels]
Reported-by: syzbot+44e602bb4db931099a8e@syzkaller.appspotmail.com
First crash: 190d, last: 57d
Bug presence (3)
Date Name Commit Repro Result
2024/06/05 linux-5.15.y (ToT) c61bd26ae81a C [report] inconsistent lock state in sync_info_debugfs_show
2024/04/20 upstream (ToT) 977b1ef51866 C [report] inconsistent lock state in sync_info_debugfs_show
2024/06/05 upstream (ToT) 32f88d65f01b C Didn't crash
Similar bugs (5)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 inconsistent lock state in sync_timeline_debug_remove (2) 3 60d 73d 0/3 upstream: reported on 2024/05/01 22:11
linux-4.14 inconsistent lock state in sync_timeline_debug_remove C 1 510d 872d 0/1 upstream: reported C repro on 2022/02/22 17:04
upstream inconsistent lock state in sync_timeline_debug_remove dri media C inconclusive 335 39d 880d 0/27 upstream: reported C repro on 2022/02/14 08:30
linux-4.19 inconsistent lock state in sync_timeline_debug_remove C error 1 877d 877d 0/1 upstream: reported C repro on 2022/02/18 00:33
linux-6.1 inconsistent lock state in sync_timeline_debug_remove 1 245d 245d 0/3 auto-obsoleted due to no activity on 2024/02/19 12:00
Fix bisection attempts (1)
Created Duration User Patch Repo Result
2024/06/26 02:18 1m fix candidate upstream error job log

Sample crash report:
================================
WARNING: inconsistent lock state
5.15.158-syzkaller #0 Not tainted
--------------------------------
inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage.
syz-executor874/3987 [HC1[1]:SC0[0]:HE0:SE1] takes:
ffff800015cefaf8 (sync_timeline_list_lock){?.+.}-{2:2}, at: sync_timeline_debug_remove+0x38/0x130 drivers/dma-buf/sync_debug.c:31
{HARDIRQ-ON-W} state was registered at:
  trace_hardirqs_on+0x2a4/0x50c kernel/trace/trace_preemptirq.c:49
  __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:168 [inline]
  _raw_spin_unlock_irq+0x9c/0x134 kernel/locking/spinlock.c:202
  spin_unlock_irq include/linux/spinlock.h:413 [inline]
  sync_print_obj drivers/dma-buf/sync_debug.c:118 [inline]
  sync_info_debugfs_show+0x16c/0x464 drivers/dma-buf/sync_debug.c:153
  seq_read_iter+0x3e0/0xc44 fs/seq_file.c:230
  seq_read+0x388/0x4ec fs/seq_file.c:162
  vfs_read+0x278/0xb10 fs/read_write.c:483
  ksys_read+0x15c/0x26c fs/read_write.c:623
  __do_sys_read fs/read_write.c:633 [inline]
  __se_sys_read fs/read_write.c:631 [inline]
  __arm64_sys_read+0x7c/0x90 fs/read_write.c:631
  __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
  invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
  el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
  do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
  el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
  el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
  el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
irq event stamp: 1138
hardirqs last  enabled at (1137): [<ffff800011a6e10c>] __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:168 [inline]
hardirqs last  enabled at (1137): [<ffff800011a6e10c>] _raw_spin_unlock_irq+0x9c/0x134 kernel/locking/spinlock.c:202
hardirqs last disabled at (1138): [<ffff800011997510>] enter_el1_irq_or_nmi+0x10/0x1c arch/arm64/kernel/entry-common.c:227
softirqs last  enabled at (98): [<ffff800008021c64>] softirq_handle_end kernel/softirq.c:401 [inline]
softirqs last  enabled at (98): [<ffff800008021c64>] __do_softirq+0xb5c/0xdb0 kernel/softirq.c:587
softirqs last disabled at (59): [<ffff8000081b6568>] do_softirq_own_stack include/asm-generic/softirq_stack.h:10 [inline]
softirqs last disabled at (59): [<ffff8000081b6568>] invoke_softirq kernel/softirq.c:439 [inline]
softirqs last disabled at (59): [<ffff8000081b6568>] __irq_exit_rcu+0x264/0x4d4 kernel/softirq.c:637

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(sync_timeline_list_lock);
  <Interrupt>
    lock(sync_timeline_list_lock);

 *** DEADLOCK ***

no locks held by syz-executor874/3987.

stack backtrace:
CPU: 1 PID: 3987 Comm: syz-executor874 Not tainted 5.15.158-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
 dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_usage_bug+0x64c/0x9a8 kernel/locking/lockdep.c:3920
 mark_lock_irq+0x980/0xd2c
 mark_lock+0x258/0x360 kernel/locking/lockdep.c:4591
 mark_usage kernel/locking/lockdep.c:4483 [inline]
 __lock_acquire+0xb50/0x7638 kernel/locking/lockdep.c:4966
 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0xc4/0x14c kernel/locking/spinlock.c:162
 sync_timeline_debug_remove+0x38/0x130 drivers/dma-buf/sync_debug.c:31
 sync_timeline_free drivers/dma-buf/sw_sync.c:104 [inline]
 kref_put include/linux/kref.h:65 [inline]
 sync_timeline_put drivers/dma-buf/sw_sync.c:116 [inline]
 timeline_fence_release+0x1f0/0x284 drivers/dma-buf/sw_sync.c:144
 dma_fence_release+0x180/0x560 drivers/dma-buf/dma-fence.c:548
 kref_put include/linux/kref.h:65 [inline]
 dma_fence_put include/linux/dma-fence.h:279 [inline]
 dma_fence_array_release+0x120/0x24c drivers/dma-buf/dma-fence-array.c:120
 dma_fence_release+0x180/0x560 drivers/dma-buf/dma-fence.c:548
 kref_put include/linux/kref.h:65 [inline]
 dma_fence_put include/linux/dma-fence.h:279 [inline]
 irq_dma_fence_array_work+0xac/0x160 drivers/dma-buf/dma-fence-array.c:52
 irq_work_single+0xbc/0x1e4 kernel/irq_work.c:155
 irq_work_run_list kernel/irq_work.c:177 [inline]
 irq_work_run+0x108/0x25c kernel/irq_work.c:186
 do_handle_IPI arch/arm64/kernel/smp.c:925 [inline]
 ipi_handler+0x108/0x7d4 arch/arm64/kernel/smp.c:948
 handle_percpu_devid_irq+0x29c/0x7fc kernel/irq/chip.c:933
 generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
 handle_irq_desc kernel/irq/irqdesc.c:651 [inline]
 handle_domain_irq+0xec/0x178 kernel/irq/irqdesc.c:706
 gic_handle_irq+0x78/0x1c8 drivers/irqchip/irq-gic-v3.c:758
 call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:899
 do_interrupt_handler+0x74/0x94 arch/arm64/kernel/entry-common.c:267
 el1_interrupt+0x30/0x58 arch/arm64/kernel/entry-common.c:454
 el1h_64_irq_handler+0x18/0x24 arch/arm64/kernel/entry-common.c:470
 el1h_64_irq+0x78/0x7c arch/arm64/kernel/entry.S:522
 arch_local_irq_enable arch/arm64/include/asm/irqflags.h:35 [inline]
 __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:168 [inline]
 _raw_spin_unlock_irq+0xa4/0x134 kernel/locking/spinlock.c:202
 spin_unlock_irq include/linux/spinlock.h:413 [inline]
 sw_sync_debugfs_release+0x134/0x204 drivers/dma-buf/sw_sync.c:321
 __fput+0x30c/0x7f0 fs/file_table.c:280
 ____fput+0x20/0x30 fs/file_table.c:308
 task_work_run+0x130/0x1e4 kernel/task_work.c:164
 tracehook_notify_resume include/linux/tracehook.h:189 [inline]
 do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946
 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
 exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
 el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609
 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

Crashes (20):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/05/14 07:42 linux-5.15.y 284087d4f7d5 fdb4c10c .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/20 18:03 linux-5.15.y c52b9710c83d af24b050 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/05/18 02:39 linux-5.15.y 83655231580b c0f1611a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/05/15 14:49 linux-5.15.y 284087d4f7d5 94b087b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/05/14 01:07 linux-5.15.y 284087d4f7d5 fdb4c10c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/05/14 01:07 linux-5.15.y 284087d4f7d5 fdb4c10c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/05/10 01:08 linux-5.15.y 284087d4f7d5 de979bc2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/16 04:57 linux-5.15.y fa3df276cd36 0d592ce4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/16 04:57 linux-5.15.y fa3df276cd36 0d592ce4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/16 04:57 linux-5.15.y fa3df276cd36 0d592ce4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/13 06:04 linux-5.15.y cdfd0a7f0139 c8349e48 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/11 01:42 linux-5.15.y cdfd0a7f0139 33b9e058 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/04/08 16:02 linux-5.15.y 9465fef4ae35 53df08b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/03/27 18:57 linux-5.15.y 9465fef4ae35 120789fd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/03/08 19:07 linux-5.15.y 574362648507 8e75c913 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/03/01 18:14 linux-5.15.y 80efc6265290 83acf9e0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/02/28 15:28 linux-5.15.y 458ce51d0356 55d6f11d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/01/16 02:06 linux-5.15.y ddcaf4999061 2a7bcc7f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/01/09 19:01 linux-5.15.y 26c690eff0a5 4807fb37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
2024/01/06 01:35 linux-5.15.y 26c690eff0a5 d0304e9c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_timeline_debug_remove
* Struck through repros no longer work on HEAD.