syzbot


BUG: corrupted list in nf_tables_commit

Status: fixed on 2020/02/16 09:59
Reported-by: syzbot+5d664cfac14aa11c1da4@syzkaller.appspotmail.com
Fix commit: 8260ce5aeee4 netfilter: nf_tables: fix flowtable list del corruption
First crash: 1773d, last: 1773d
Fix bisection: fixed by (bisect log) :
commit 8260ce5aeee4d7c4a6305e469edeae1066de2800
Author: Florian Westphal <fw@strlen.de>
Date: Thu Jan 16 11:03:01 2020 +0000

  netfilter: nf_tables: fix flowtable list del corruption

  
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream BUG: corrupted list in nf_tables_commit netfilter C done 8 1773d 1773d 15/28 fixed on 2020/02/18 14:31

Sample crash report:
audit: type=1400 audit(1579147604.427:36): avc:  denied  { map } for  pid=8269 comm="syz-executor513" path="/root/syz-executor513714234" dev="sda1" ino=16484 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
list_del corruption, ffff8880a6042400->prev is LIST_POISON2 (dead000000000200)
audit: type=1400 audit(1579147604.427:37): avc:  denied  { create } for  pid=8269 comm="syz-executor513" scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tclass=netlink_netfilter_socket permissive=1
------------[ cut here ]------------
audit: type=1400 audit(1579147604.427:38): avc:  denied  { write } for  pid=8269 comm="syz-executor513" scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tclass=netlink_netfilter_socket permissive=1
kernel BUG at lib/list_debug.c:48!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 8269 Comm: syz-executor513 Not tainted 4.19.96-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__list_del_entry_valid.cold+0x37/0x4f lib/list_debug.c:48
Code: eb fd 0f 0b 4c 89 ea 4c 89 f6 48 c7 c7 a0 2b eb 87 e8 e0 58 eb fd 0f 0b 4c 89 e2 4c 89 f6 48 c7 c7 00 2c eb 87 e8 cc 58 eb fd <0f> 0b 4c 89 f6 48 c7 c7 c0 2c eb 87 e8 bb 58 eb fd 0f 0b 90 90 90
RSP: 0018:ffff88809435f4a0 EFLAGS: 00010282
RAX: 000000000000004e RBX: ffff8880a6042400 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff81558bc6 RDI: ffffed101286be86
RBP: ffff88809435f4b8 R08: 000000000000004e R09: ffff8880772ecd60
R10: 0000000000000000 R11: 0000000000000000 R12: dead000000000200
R13: ffff88808cb1d8f0 R14: ffff8880a6042400 R15: 0000000000000000
FS:  00000000011ca880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000280 CR3: 00000000a507c000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __list_del_entry include/linux/list.h:117 [inline]
 list_del_rcu include/linux/rculist.h:130 [inline]
 nf_tables_commit+0x1fc0/0x41a0 net/netfilter/nf_tables_api.c:6561
 nfnetlink_rcv_batch+0xcf6/0x1750 net/netfilter/nfnetlink.c:482
 nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:540 [inline]
 nfnetlink_rcv+0x3ed/0x460 net/netfilter/nfnetlink.c:558
 netlink_unicast_kernel net/netlink/af_netlink.c:1317 [inline]
 netlink_unicast+0x53a/0x730 net/netlink/af_netlink.c:1343
 netlink_sendmsg+0x8ae/0xd70 net/netlink/af_netlink.c:1908
 sock_sendmsg_nosec net/socket.c:622 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:632
 ___sys_sendmsg+0x803/0x920 net/socket.c:2115
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2153
 __do_sys_sendmsg net/socket.c:2162 [inline]
 __se_sys_sendmsg net/socket.c:2160 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2160
 do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4406a9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff3a745388 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 00000000004406a9
RDX: 0000000000042000 RSI: 0000000020000140 RDI: 0000000000000004
RBP: 00000000006ca018 R08: 0000000000000001 R09: 00000000004002c8
R10: 0000000000000009 R11: 0000000000000246 R12: 0000000000401f30
R13: 0000000000401fc0 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace 967503997fa2eb4e ]---
RIP: 0010:__list_del_entry_valid.cold+0x37/0x4f lib/list_debug.c:48
Code: eb fd 0f 0b 4c 89 ea 4c 89 f6 48 c7 c7 a0 2b eb 87 e8 e0 58 eb fd 0f 0b 4c 89 e2 4c 89 f6 48 c7 c7 00 2c eb 87 e8 cc 58 eb fd <0f> 0b 4c 89 f6 48 c7 c7 c0 2c eb 87 e8 bb 58 eb fd 0f 0b 90 90 90
RSP: 0018:ffff88809435f4a0 EFLAGS: 00010282
RAX: 000000000000004e RBX: ffff8880a6042400 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff81558bc6 RDI: ffffed101286be86
RBP: ffff88809435f4b8 R08: 000000000000004e R09: ffff8880772ecd60
R10: 0000000000000000 R11: 0000000000000000 R12: dead000000000200
R13: ffff88808cb1d8f0 R14: ffff8880a6042400 R15: 0000000000000000
FS:  00000000011ca880(0000) GS:ffff8880ae900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000280 CR3: 00000000a507c000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/01/16 04:10 linux-4.19.y db5b9190ff82 f9b69507 .config console log report syz C ci2-linux-4-19
2020/01/16 02:09 linux-4.19.y db5b9190ff82 f9b69507 .config console log report syz C ci2-linux-4-19
* Struck through repros no longer work on HEAD.