syzbot


possible deadlock in btrfs_create_qgroup

Status: upstream: reported C repro on 2022/12/06 07:04
Subsystems: btrfs
[Documentation on labels]
Reported-by: syzbot+612ed3b940119a3f68de@syzkaller.appspotmail.com
First crash: 566d, last: 502d

Sample crash report:
BTRFS: device fsid 24c7a497-3402-47dd-bef8-82358f5f30e0 devid 1 transid 8 /dev/loop0
BTRFS info (device loop0): using free space tree
BTRFS info (device loop0): has skinny extents
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor173/8103 is trying to acquire lock:
000000008176a9e6 (&fs_info->qgroup_ioctl_lock){+.+.}, at: btrfs_create_qgroup+0x5a/0x270 fs/btrfs/qgroup.c:1380

but task is already holding lock:
00000000e6397e76 (sb_internal#2){.+.+}, at: sb_start_intwrite include/linux/fs.h:1626 [inline]
00000000e6397e76 (sb_internal#2){.+.+}, at: start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (sb_internal#2){.+.+}:
       sb_start_intwrite include/linux/fs.h:1626 [inline]
       start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528
       btrfs_quota_enable+0x169/0x10b0 fs/btrfs/qgroup.c:905
       btrfs_ioctl_quota_ctl fs/btrfs/ioctl.c:5233 [inline]
       btrfs_ioctl+0x622c/0x76d0 fs/btrfs/ioctl.c:6021
       vfs_ioctl fs/ioctl.c:46 [inline]
       file_ioctl fs/ioctl.c:501 [inline]
       do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688
       ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705
       __do_sys_ioctl fs/ioctl.c:712 [inline]
       __se_sys_ioctl fs/ioctl.c:710 [inline]
       __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&fs_info->qgroup_ioctl_lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:937 [inline]
       __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
       btrfs_create_qgroup+0x5a/0x270 fs/btrfs/qgroup.c:1380
       btrfs_ioctl_qgroup_create fs/btrfs/ioctl.c:5335 [inline]
       btrfs_ioctl+0xcce/0x76d0 fs/btrfs/ioctl.c:6025
       vfs_ioctl fs/ioctl.c:46 [inline]
       file_ioctl fs/ioctl.c:501 [inline]
       do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688
       ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705
       __do_sys_ioctl fs/ioctl.c:712 [inline]
       __se_sys_ioctl fs/ioctl.c:710 [inline]
       __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(sb_internal#2);
                               lock(&fs_info->qgroup_ioctl_lock);
                               lock(sb_internal#2);
  lock(&fs_info->qgroup_ioctl_lock);

 *** DEADLOCK ***

2 locks held by syz-executor173/8103:
 #0: 00000000bf42d339 (sb_writers#11){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
 #0: 00000000bf42d339 (sb_writers#11){.+.+}, at: mnt_want_write_file+0x63/0x1d0 fs/namespace.c:418
 #1: 00000000e6397e76 (sb_internal#2){.+.+}, at: sb_start_intwrite include/linux/fs.h:1626 [inline]
 #1: 00000000e6397e76 (sb_internal#2){.+.+}, at: start_transaction+0xa37/0xf90 fs/btrfs/transaction.c:528

stack backtrace:
CPU: 0 PID: 8103 Comm: syz-executor173 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 __mutex_lock_common kernel/locking/mutex.c:937 [inline]
 __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
 btrfs_create_qgroup+0x5a/0x270 fs/btrfs/qgroup.c:1380
 btrfs_ioctl_qgroup_create fs/btrfs/ioctl.c:5335 [inline]
 btrfs_ioctl+0xcce/0x76d0 fs/btrfs/ioctl.c:6025
 vfs_ioctl fs/ioctl.c:46 [inline]
 file_ioctl fs/ioctl.c:501 [inline]
 do_vfs_ioctl+0xcdb/0x12e0 fs/ioctl.c:688
 ksys_ioctl+0x9b/0xc0 fs/ioctl.c:705
 __do_sys_ioctl fs/ioctl.c:712 [inline]
 __se_sys_ioctl fs/ioctl.c:710 [inline]
 __x64_sys_ioctl+0x6f/0xb0 fs/ioctl.c:710
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f7ddceb47f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe352c24f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007f7ddceb47f9
RDX: 00000000200011c0 RSI: 000000004010942a RDI: 0000000000000004
RBP: 00007f7ddce74090 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f7ddce74120
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Crashes (28):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2022/12/26 05:59 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report syz C [disk image] [vmlinux] [mounted in repro] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/18 20:12 linux-4.19.y 3f8a27f9e27b 05494336 .config console log report syz C [disk image] [vmlinux] [mounted in repro] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/02/08 12:51 linux-4.19.y 3f8a27f9e27b abbb67b7 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/02/08 12:42 linux-4.19.y 3f8a27f9e27b abbb67b7 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/02/08 01:48 linux-4.19.y 3f8a27f9e27b 15c3d445 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/02/08 01:26 linux-4.19.y 3f8a27f9e27b 15c3d445 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/02/05 22:09 linux-4.19.y 3f8a27f9e27b be607b78 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/02/01 04:06 linux-4.19.y 3f8a27f9e27b b68fb8d6 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/31 19:33 linux-4.19.y 3f8a27f9e27b b68fb8d6 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/31 19:23 linux-4.19.y 3f8a27f9e27b b68fb8d6 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/28 15:54 linux-4.19.y 3f8a27f9e27b 9dfcf09c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/26 16:10 linux-4.19.y 3f8a27f9e27b 9dfcf09c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/15 04:14 linux-4.19.y 3f8a27f9e27b a63719e7 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/15 04:12 linux-4.19.y 3f8a27f9e27b a63719e7 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2023/01/08 02:13 linux-4.19.y 3f8a27f9e27b 1dac8c7a .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/31 00:26 linux-4.19.y 3f8a27f9e27b ab32d508 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/30 05:48 linux-4.19.y 3f8a27f9e27b 44712fbc .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/29 21:18 linux-4.19.y 3f8a27f9e27b 44712fbc .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/29 04:59 linux-4.19.y 3f8a27f9e27b 44712fbc .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/29 03:20 linux-4.19.y 3f8a27f9e27b 44712fbc .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/22 13:42 linux-4.19.y 3f8a27f9e27b 9da18ae8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/21 16:00 linux-4.19.y 3f8a27f9e27b 4067838e .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/21 01:51 linux-4.19.y 3f8a27f9e27b d3e76707 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/21 01:40 linux-4.19.y 3f8a27f9e27b d3e76707 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/21 01:40 linux-4.19.y 3f8a27f9e27b d3e76707 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/18 20:00 linux-4.19.y 3f8a27f9e27b 05494336 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/08 23:46 linux-4.19.y 3f8a27f9e27b 1034e5fa .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
2022/12/06 07:04 linux-4.19.y 3f8a27f9e27b 045cbb84 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in btrfs_create_qgroup
* Struck through repros no longer work on HEAD.