syzbot


KASAN: use-after-free Read in xfs_trans_ail_delete

Status: upstream: reported C repro on 2023/03/30 19:54
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+7f6b550d8fc0cc7f04ce@syzkaller.appspotmail.com
First crash: 452d, last: 233d
Fix bisection: the issue occurs on the latest tested release (bisect log)
Crash: KASAN: use-after-free Read in xfs_trans_committed_bulk (log)
Repro: C syz .config
  
Bug presence (2)
Date Name Commit Repro Result
2023/05/24 linux-6.1.y (ToT) fa74641fb6b9 C [report] INFO: rcu detected stall in corrupted
2023/05/24 upstream (ToT) 9d646009f65d C Didn't crash
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 KASAN: use-after-free Read in xfs_trans_ail_delete 11 365d 462d 0/3 auto-obsoleted due to no activity on 2023/10/03 15:08
Fix bisection attempts (4)
Created Duration User Patch Repo Result
2023/11/23 04:11 6h57m fix candidate upstream job log (1)
marked invalid by web-security-scanner@google.com
2023/11/04 05:20 1h39m bisect fix linux-6.1.y job log (0) log
2023/10/03 15:36 2h45m bisect fix linux-6.1.y job log (0) log
2023/08/07 15:00 5h57m bisect fix linux-6.1.y job log (0) log

Sample crash report:
XFS (loop3): Please unmount the filesystem and rectify the problem(s).
XFS (loop2): log I/O error -5
XFS (loop2): Filesystem has been shut down due to log error (0x2).
XFS (loop2): Please unmount the filesystem and rectify the problem(s).
==================================================================
BUG: KASAN: use-after-free in xfs_trans_ail_delete+0x5b/0x320 fs/xfs/xfs_trans_ail.c:875
Read of size 8 at addr ffff888022910a00 by task kworker/1:1H/52

CPU: 1 PID: 52 Comm: kworker/1:1H Not tainted 6.1.29-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/28/2023
Workqueue: xfs-log/loop2 xlog_ioend_work
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 print_address_description mm/kasan/report.c:284 [inline]
 print_report+0x15f/0x4f0 mm/kasan/report.c:395
 kasan_report+0x136/0x160 mm/kasan/report.c:495
 xfs_trans_ail_delete+0x5b/0x320 fs/xfs/xfs_trans_ail.c:875
 xfs_buf_item_done+0x5f/0x80 fs/xfs/xfs_buf_item.c:1042
 xfs_buf_ioend+0x336/0x780 fs/xfs/xfs_buf.c:1326
 xfs_trans_committed_bulk+0x342/0x830 fs/xfs/xfs_trans.c:806
 xlog_cil_committed+0x269/0xed0 fs/xfs/xfs_log_cil.c:795
 xlog_cil_process_committed+0x155/0x1a0 fs/xfs/xfs_log_cil.c:823
 xlog_state_shutdown_callbacks+0x2b6/0x3a0 fs/xfs/xfs_log.c:538
 xlog_force_shutdown+0x328/0x380 fs/xfs/xfs_log.c:3821
 xlog_ioend_work+0xa9/0x100 fs/xfs/xfs_log.c:1402
 process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2289
 worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436
 kthread+0x26e/0x300 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
 </TASK>

Allocated by task 4496:
 kasan_save_stack mm/kasan/common.c:45 [inline]
 kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
 ____kasan_kmalloc mm/kasan/common.c:374 [inline]
 __kasan_kmalloc+0x97/0xb0 mm/kasan/common.c:383
 kasan_kmalloc include/linux/kasan.h:211 [inline]
 __do_kmalloc_node mm/slab_common.c:955 [inline]
 __kmalloc+0xb2/0x230 mm/slab_common.c:968
 kmalloc include/linux/slab.h:558 [inline]
 kmem_alloc+0x15c/0x420 fs/xfs/kmem.c:20
 kmem_zalloc fs/xfs/kmem.h:69 [inline]
 xfs_trans_ail_init+0x20/0x240 fs/xfs/xfs_trans_ail.c:902
 xfs_log_mount+0x213/0x770 fs/xfs/xfs_log.c:721
 xfs_mountfs+0xcbb/0x1f00 fs/xfs/xfs_mount.c:805
 xfs_fs_fill_super+0xf90/0x11e0 fs/xfs/xfs_super.c:1666
 get_tree_bdev+0x3fe/0x620 fs/super.c:1346
 vfs_get_tree+0x88/0x270 fs/super.c:1553
 do_new_mount+0x28b/0xad0 fs/namespace.c:3040
 do_mount fs/namespace.c:3383 [inline]
 __do_sys_mount fs/namespace.c:3591 [inline]
 __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 3580:
 kasan_save_stack mm/kasan/common.c:45 [inline]
 kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
 kasan_save_free_info+0x27/0x40 mm/kasan/generic.c:516
 ____kasan_slab_free+0xd6/0x120 mm/kasan/common.c:236
 kasan_slab_free include/linux/kasan.h:177 [inline]
 slab_free_hook mm/slub.c:1724 [inline]
 slab_free_freelist_hook mm/slub.c:1750 [inline]
 slab_free mm/slub.c:3661 [inline]
 __kmem_cache_free+0x25c/0x3c0 mm/slub.c:3674
 xfs_log_unmount+0x51/0xc0 fs/xfs/xfs_log.c:1116
 xfs_unmountfs+0x12c/0x1e0 fs/xfs/xfs_mount.c:1081
 xfs_fs_put_super+0x6c/0x2c0 fs/xfs/xfs_super.c:1115
 generic_shutdown_super+0x130/0x340 fs/super.c:501
 kill_block_super+0x7a/0xe0 fs/super.c:1450
 deactivate_locked_super+0xa0/0x110 fs/super.c:332
 cleanup_mnt+0x490/0x520 fs/namespace.c:1186
 task_work_run+0x246/0x300 kernel/task_work.c:179
 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
 exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171
 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:204
 __syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
 syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:297
 do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

The buggy address belongs to the object at ffff888022910a00
 which belongs to the cache kmalloc-256 of size 256
The buggy address is located 0 bytes inside of
 256-byte region [ffff888022910a00, ffff888022910b00)

The buggy address belongs to the physical page:
page:ffffea00008a4400 refcount:1 mapcount:0 mapping:0000000000000000 index:0xffff888022911e00 pfn:0x22910
head:ffffea00008a4400 order:1 compound_mapcount:0 compound_pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 ffffea00007b7f80 dead000000000003 ffff888012441b40
raw: ffff888022911e00 0000000080100006 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 1, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 4040, tgid 4039 (syz-executor191), ts 613421102172, free_ts 612431443091
 set_page_owner include/linux/page_owner.h:31 [inline]
 post_alloc_hook+0x18d/0x1b0 mm/page_alloc.c:2533
 prep_new_page mm/page_alloc.c:2540 [inline]
 get_page_from_freelist+0x32ed/0x3480 mm/page_alloc.c:4292
 __alloc_pages+0x28d/0x770 mm/page_alloc.c:5559
 alloc_slab_page+0x6a/0x150 mm/slub.c:1794
 allocate_slab mm/slub.c:1939 [inline]
 new_slab+0x84/0x2d0 mm/slub.c:1992
 ___slab_alloc+0xa71/0x1080 mm/slub.c:3180
 __slab_alloc mm/slub.c:3279 [inline]
 slab_alloc_node mm/slub.c:3364 [inline]
 __kmem_cache_alloc_node+0x19f/0x260 mm/slub.c:3437
 __do_kmalloc_node mm/slab_common.c:954 [inline]
 __kmalloc+0xa1/0x230 mm/slab_common.c:968
 kmalloc_array include/linux/slab.h:605 [inline]
 kcalloc include/linux/slab.h:636 [inline]
 __list_lru_init+0xa6/0x5d0 mm/list_lru.c:571
 xfs_qm_init_quotainfo+0xef/0x12f0 fs/xfs/xfs_qm.c:627
 xfs_qm_mount_quotas+0x97/0x620 fs/xfs/xfs_qm.c:1424
 xfs_mountfs+0x185d/0x1f00 fs/xfs/xfs_mount.c:945
 xfs_fs_fill_super+0xf90/0x11e0 fs/xfs/xfs_super.c:1666
 get_tree_bdev+0x3fe/0x620 fs/super.c:1346
 vfs_get_tree+0x88/0x270 fs/super.c:1553
 do_new_mount+0x28b/0xad0 fs/namespace.c:3040
page last free stack trace:
 reset_page_owner include/linux/page_owner.h:24 [inline]
 free_pages_prepare mm/page_alloc.c:1460 [inline]
 free_pcp_prepare mm/page_alloc.c:1510 [inline]
 free_unref_page_prepare+0xf63/0x1120 mm/page_alloc.c:3388
 free_unref_page+0x98/0x570 mm/page_alloc.c:3484
 qlist_free_all+0x22/0x60 mm/kasan/quarantine.c:187
 kasan_quarantine_reduce+0x162/0x180 mm/kasan/quarantine.c:294
 __kasan_slab_alloc+0x1f/0x70 mm/kasan/common.c:305
 kasan_slab_alloc include/linux/kasan.h:201 [inline]
 slab_post_alloc_hook+0x50/0x370 mm/slab.h:737
 slab_alloc_node mm/slub.c:3398 [inline]
 slab_alloc mm/slub.c:3406 [inline]
 __kmem_cache_alloc_lru mm/slub.c:3413 [inline]
 kmem_cache_alloc+0x10c/0x2d0 mm/slub.c:3422
 getname_flags+0xb8/0x4e0 fs/namei.c:139
 user_path_at_empty+0x2a/0x180 fs/namei.c:2875
 do_readlinkat+0x114/0x3a0 fs/stat.c:468
 __do_sys_readlink fs/stat.c:501 [inline]
 __se_sys_readlink fs/stat.c:498 [inline]
 __x64_sys_readlink+0x7b/0x90 fs/stat.c:498
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
 ffff888022910900: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff888022910980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff888022910a00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                   ^
 ffff888022910a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff888022910b00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/05/24 08:31 linux-6.1.y fa74641fb6b9 4bce1a3e .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/06/01 17:27 linux-6.1.y d2869ace6eeb babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/06/01 13:23 linux-6.1.y d2869ace6eeb babc4389 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/05/28 04:09 linux-6.1.y a343b0dd87b4 cf184559 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/05/24 12:54 linux-6.1.y fa74641fb6b9 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/05/22 17:21 linux-6.1.y fa74641fb6b9 4bce1a3e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/03/30 19:54 linux-6.1.y 3b29299e5f60 f325deb0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan KASAN: use-after-free Read in xfs_trans_ail_delete
2023/06/18 22:35 linux-6.1.y ca87e77a2ef8 f3921d4d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 KASAN: use-after-free Read in xfs_trans_ail_delete
2023/04/23 15:12 linux-6.1.y f17b0ab65d17 2b32bd34 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 KASAN: use-after-free Read in xfs_trans_ail_delete
* Struck through repros no longer work on HEAD.