syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.6.102-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/5945 is trying to acquire lock:
ffff888073ee5f58 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff888073ee5f58 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782

but task is already holding lock:
ffff88806000a378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x410/0x11f0 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_init_acl+0x2fa/0x720 fs/ocfs2/acl.c:366
       ocfs2_mknod+0x12e5/0x20f0 fs/ocfs2/namei.c:410
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1e9d/0x20c0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2bb/0x5b0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x2a/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x376/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x46/0x2e0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x36a/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1633 [inline]
       sb_start_intwrite include/linux/fs.h:1755 [inline]
       ocfs2_start_trans+0x26b/0x6c0 fs/ocfs2/journal.c:370
       ocfs2_mknod+0xe47/0x20f0 fs/ocfs2/namei.c:361
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_reserve_local_alloc_bits+0x126/0x24b0 fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x1bf/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0xdee/0x20f0 fs/ocfs2/namei.c:354
       ocfs2_create+0x196/0x410 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3488 [inline]
       open_last_lookups fs/namei.c:3556 [inline]
       path_openat+0x1277/0x3190 fs/namei.c:3786
       do_filp_open+0x1c5/0x3d0 fs/namei.c:3816
       do_sys_openat2+0x12c/0x1c0 fs/open.c:1419
       do_sys_open fs/open.c:1434 [inline]
       __do_sys_open fs/open.c:1442 [inline]
       __se_sys_open fs/open.c:1438 [inline]
       __x64_sys_open+0x11f/0x140 fs/open.c:1438
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_new_metadata_blocks+0x404/0x940 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x2f8/0x6e0 fs/ocfs2/xattr.c:3277
       ocfs2_xattr_set+0xb6d/0x11f0 fs/ocfs2/xattr.c:3634
       __vfs_setxattr+0x431/0x470 fs/xattr.c:201
       __vfs_setxattr_noperm+0x12d/0x5e0 fs/xattr.c:235
       vfs_setxattr+0x16c/0x2f0 fs/xattr.c:322
       do_setxattr fs/xattr.c:630 [inline]
       path_setxattr+0x362/0x550 fs/xattr.c:659
       __do_sys_setxattr fs/xattr.c:677 [inline]
       __se_sys_setxattr fs/xattr.c:673 [inline]
       __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);

 *** DEADLOCK ***

3 locks held by syz.0.17/5945:
 #0: ffff88802ed7a418 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:403
 #1: ffff88806000a658 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88806000a658 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: vfs_setxattr+0x145/0x2f0 fs/xattr.c:321
 #2: ffff88806000a378 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x410/0x11f0 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 0 PID: 5945 Comm: syz.0.17 Not tainted 6.6.102-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
 ocfs2_reserve_new_metadata_blocks+0x404/0x940 fs/ocfs2/suballoc.c:978
 ocfs2_init_xattr_set_ctxt+0x2f8/0x6e0 fs/ocfs2/xattr.c:3277
 ocfs2_xattr_set+0xb6d/0x11f0 fs/ocfs2/xattr.c:3634
 __vfs_setxattr+0x431/0x470 fs/xattr.c:201
 __vfs_setxattr_noperm+0x12d/0x5e0 fs/xattr.c:235
 vfs_setxattr+0x16c/0x2f0 fs/xattr.c:322
 do_setxattr fs/xattr.c:630 [inline]
 path_setxattr+0x362/0x550 fs/xattr.c:659
 __do_sys_setxattr fs/xattr.c:677 [inline]
 __se_sys_setxattr fs/xattr.c:673 [inline]
 __x64_sys_setxattr+0xbb/0xd0 fs/xattr.c:673
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fe7dbb8ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc22d5c5a8 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007fe7dbdb5fa0 RCX: 00007fe7dbb8ebe9
RDX: 0000200000000340 RSI: 0000200000000140 RDI: 0000200000000100
RBP: 00007fe7dbc11e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000700 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fe7dbdb5fa0 R14: 00007fe7dbdb5fa0 R15: 0000000000000005
 </TASK>