syzbot

ocfs2: Mounting device (7,0) on (node local, slot 0) with writeback data mode.
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
6.14.0-syzkaller-03576-g1e1ba8d23dae #0 Not tainted
------------------------------------------------------
syz-executor827/5819 is trying to acquire lock:
ffff8880749a5100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
ffff8880749a5100 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x18d/0x4f30 fs/ocfs2/suballoc.c:786

but task is already holding lock:
ffff8880749206f8 (&oi->ip_xattr_sem){+.+.}-{4:4}, at: ocfs2_xattr_set+0x635/0x1940 fs/ocfs2/xattr.c:3583

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){+.+.}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
       ocfs2_xattr_set_handle+0x53b/0xa20 fs/ocfs2/xattr.c:3501
       ocfs2_init_security_set+0xbd/0xd0 fs/ocfs2/xattr.c:7307
       ocfs2_mknod+0x1cd3/0x2b30 fs/ocfs2/namei.c:419
       ocfs2_mkdir+0x19c/0x470 fs/ocfs2/namei.c:656
       vfs_mkdir+0x2f9/0x500 fs/namei.c:4324
       do_mkdirat+0x273/0x3f0 fs/namei.c:4357
       __do_sys_mkdirat fs/namei.c:4374 [inline]
       __se_sys_mkdirat fs/namei.c:4372 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4372
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){.+.+}-{0:0}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       start_this_handle+0x1f30/0x21e0 fs/jbd2/transaction.c:448
       jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505
       jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544
       ocfs2_start_trans+0x3cd/0x710 fs/ocfs2/journal.c:352
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0xa54/0x4f30 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x41c/0x9b0 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0x143e/0x2b30 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x19c/0x470 fs/ocfs2/namei.c:656
       vfs_mkdir+0x2f9/0x500 fs/namei.c:4324
       do_mkdirat+0x273/0x3f0 fs/namei.c:4357
       __do_sys_mkdirat fs/namei.c:4374 [inline]
       __se_sys_mkdirat fs/namei.c:4372 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4372
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_read+0xb3/0xae0 kernel/locking/rwsem.c:1524
       ocfs2_start_trans+0x3c2/0x710 fs/ocfs2/journal.c:350
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0xa54/0x4f30 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x41c/0x9b0 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0x143e/0x2b30 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x19c/0x470 fs/ocfs2/namei.c:656
       vfs_mkdir+0x2f9/0x500 fs/namei.c:4324
       do_mkdirat+0x273/0x3f0 fs/namei.c:4357
       __do_sys_mkdirat fs/namei.c:4374 [inline]
       __se_sys_mkdirat fs/namei.c:4372 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4372
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#2){.+.+}-{0:0}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       percpu_down_read include/linux/percpu-rwsem.h:52 [inline]
       __sb_start_write include/linux/fs.h:1775 [inline]
       sb_start_intwrite include/linux/fs.h:1958 [inline]
       ocfs2_start_trans+0x2bd/0x710 fs/ocfs2/journal.c:348
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0xa54/0x4f30 fs/ocfs2/suballoc.c:832
       ocfs2_reserve_new_metadata_blocks+0x41c/0x9b0 fs/ocfs2/suballoc.c:982
       ocfs2_mknod+0x143e/0x2b30 fs/ocfs2/namei.c:347
       ocfs2_mkdir+0x19c/0x470 fs/ocfs2/namei.c:656
       vfs_mkdir+0x2f9/0x500 fs/namei.c:4324
       do_mkdirat+0x273/0x3f0 fs/namei.c:4357
       __do_sys_mkdirat fs/namei.c:4374 [inline]
       __se_sys_mkdirat fs/namei.c:4372 [inline]
       __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4372
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
       __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
       inode_lock include/linux/fs.h:867 [inline]
       ocfs2_reserve_suballoc_bits+0x18d/0x4f30 fs/ocfs2/suballoc.c:786
       ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1132 [inline]
       ocfs2_reserve_clusters_with_limit+0x3df/0xb60 fs/ocfs2/suballoc.c:1177
       ocfs2_init_xattr_set_ctxt+0x435/0x900 fs/ocfs2/xattr.c:3286
       ocfs2_xattr_set+0xf52/0x1940 fs/ocfs2/xattr.c:3634
       __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200
       __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
       vfs_setxattr+0x223/0x430 fs/xattr.c:321
       ovl_do_setxattr fs/overlayfs/overlayfs.h:315 [inline]
       ovl_setxattr fs/overlayfs/overlayfs.h:327 [inline]
       ovl_make_workdir fs/overlayfs/super.c:715 [inline]
       ovl_get_workdir+0xea3/0x19e0 fs/overlayfs/super.c:827
       ovl_fill_super+0x1386/0x3720 fs/overlayfs/super.c:1401
       vfs_get_super fs/super.c:1280 [inline]
       get_tree_nodev+0xb7/0x140 fs/super.c:1299
       vfs_get_tree+0x90/0x2b0 fs/super.c:1759
       do_new_mount+0x2cf/0xb70 fs/namespace.c:3878
       do_mount fs/namespace.c:4218 [inline]
       __do_sys_mount fs/namespace.c:4429 [inline]
       __se_sys_mount+0x38c/0x400 fs/namespace.c:4406
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);

 *** DEADLOCK ***

4 locks held by syz-executor827/5819:
 #0: ffff88807e6a80e0 (&type->s_umount_key#43/1){+.+.}-{4:4}, at: alloc_super+0x221/0x9d0 fs/super.c:344
 #1: ffff88807c4e0420 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:556
 #2: ffff8880749209c0 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: inode_lock include/linux/fs.h:867 [inline]
 #2: ffff8880749209c0 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: vfs_setxattr+0x1e3/0x430 fs/xattr.c:320
 #3: ffff8880749206f8 (&oi->ip_xattr_sem){+.+.}-{4:4}, at: ocfs2_xattr_set+0x635/0x1940 fs/ocfs2/xattr.c:3583

stack backtrace:
CPU: 0 UID: 0 PID: 5819 Comm: syz-executor827 Not tainted 6.14.0-syzkaller-03576-g1e1ba8d23dae #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079
 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
 down_write+0x9c/0x220 kernel/locking/rwsem.c:1577
 inode_lock include/linux/fs.h:867 [inline]
 ocfs2_reserve_suballoc_bits+0x18d/0x4f30 fs/ocfs2/suballoc.c:786
 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1132 [inline]
 ocfs2_reserve_clusters_with_limit+0x3df/0xb60 fs/ocfs2/suballoc.c:1177
 ocfs2_init_xattr_set_ctxt+0x435/0x900 fs/ocfs2/xattr.c:3286
 ocfs2_xattr_set+0xf52/0x1940 fs/ocfs2/xattr.c:3634
 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200
 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234
 vfs_setxattr+0x223/0x430 fs/xattr.c:321
 ovl_do_setxattr fs/overlayfs/overlayfs.h:315 [inline]
 ovl_setxattr fs/overlayfs/overlayfs.h:327 [inline]
 ovl_make_workdir fs/overlayfs/super.c:715 [inline]
 ovl_get_workdir+0xea3/0x19e0 fs/overlayfs/super.c:827
 ovl_fill_super+0x1386/0x3720 fs/overlayfs/super.c:1401
 vfs_get_super fs/super.c:1280 [inline]
 get_tree_nodev+0xb7/0x140 fs/super.c:1299
 vfs_get_tree+0x90/0x2b0 fs/super.c:1759
 do_new_mount+0x2cf/0xb70 fs/namespace.c:3878
 do_mount fs/namespace.c:4218 [inline]
 __do_sys_mount fs/namespace.c:4429 [inline]
 __se_sys_mount+0x38c/0x400 fs/namespace.c:4406
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff2d09627b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd5f2324b8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 6e6f3d74726f7078 RCX: 00007ff2d09627b9
RDX: 0000200000000080 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007ff2d09d9610 R08: 0000200000000480 R09: 0000000000000000