syzbot


inconsistent lock state in sync_info_debugfs_show

Status: upstream: reported on 2024/01/09 18:23
Reported-by: syzbot+9cb817a930726a09c086@syzkaller.appspotmail.com
First crash: 115d, last: 10d
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream inconsistent lock state in sync_info_debugfs_show media dri C done unreliable 183 20h47m 824d 0/26 upstream: reported C repro on 2022/01/27 16:33
linux-6.1 inconsistent lock state in sync_info_debugfs_show 3 7d07h 52d 0/3 upstream: reported on 2024/03/09 05:08

Sample crash report:
================================
WARNING: inconsistent lock state
5.15.156-syzkaller #0 Not tainted
--------------------------------
inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage.
syz-executor.3/5598 [HC0[0]:SC0[0]:HE0:SE1] takes:
ffff800015cef6b8 (sync_timeline_list_lock){?...}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:388 [inline]
ffff800015cef6b8 (sync_timeline_list_lock){?...}-{2:2}, at: sync_info_debugfs_show+0x9c/0x464 drivers/dma-buf/sync_debug.c:147
{IN-HARDIRQ-W} state was registered at:
  lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
  __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
  _raw_spin_lock_irqsave+0xc4/0x14c kernel/locking/spinlock.c:162
  sync_timeline_debug_remove+0x38/0x130 drivers/dma-buf/sync_debug.c:31
  sync_timeline_free drivers/dma-buf/sw_sync.c:104 [inline]
  kref_put include/linux/kref.h:65 [inline]
  sync_timeline_put drivers/dma-buf/sw_sync.c:116 [inline]
  timeline_fence_release+0x1f0/0x284 drivers/dma-buf/sw_sync.c:144
  dma_fence_release+0x180/0x560 drivers/dma-buf/dma-fence.c:548
  kref_put include/linux/kref.h:65 [inline]
  dma_fence_put include/linux/dma-fence.h:279 [inline]
  dma_fence_array_release+0x120/0x24c drivers/dma-buf/dma-fence-array.c:120
  dma_fence_release+0x180/0x560 drivers/dma-buf/dma-fence.c:548
  kref_put include/linux/kref.h:65 [inline]
  dma_fence_put include/linux/dma-fence.h:279 [inline]
  irq_dma_fence_array_work+0xac/0x160 drivers/dma-buf/dma-fence-array.c:52
  irq_work_single+0xbc/0x1e4 kernel/irq_work.c:155
  irq_work_run_list kernel/irq_work.c:177 [inline]
  irq_work_run+0x108/0x25c kernel/irq_work.c:186
  do_handle_IPI arch/arm64/kernel/smp.c:925 [inline]
  ipi_handler+0x108/0x7d4 arch/arm64/kernel/smp.c:948
  handle_percpu_devid_irq+0x29c/0x7fc kernel/irq/chip.c:933
  generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
  handle_irq_desc kernel/irq/irqdesc.c:651 [inline]
  handle_domain_irq+0xec/0x178 kernel/irq/irqdesc.c:706
  gic_handle_irq+0x78/0x1c8 drivers/irqchip/irq-gic-v3.c:758
  call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:899
  do_interrupt_handler+0x74/0x94 arch/arm64/kernel/entry-common.c:267
  el1_interrupt+0x30/0x58 arch/arm64/kernel/entry-common.c:454
  el1h_64_irq_handler+0x18/0x24 arch/arm64/kernel/entry-common.c:470
  el1h_64_irq+0x78/0x7c arch/arm64/kernel/entry.S:580
  arch_local_irq_enable arch/arm64/include/asm/irqflags.h:35 [inline]
  __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:168 [inline]
  _raw_spin_unlock_irq+0xa4/0x134 kernel/locking/spinlock.c:202
  spin_unlock_irq include/linux/spinlock.h:413 [inline]
  sw_sync_debugfs_release+0x134/0x204 drivers/dma-buf/sw_sync.c:321
  __fput+0x30c/0x7f0 fs/file_table.c:280
  ____fput+0x20/0x30 fs/file_table.c:308
  task_work_run+0x130/0x1e4 kernel/task_work.c:164
  tracehook_notify_resume include/linux/tracehook.h:189 [inline]
  do_notify_resume+0x262c/0x32b8 arch/arm64/kernel/signal.c:946
  prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
  exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
  el0_svc+0xfc/0x1f0 arch/arm64/kernel/entry-common.c:609
  el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
  el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
irq event stamp: 8306
hardirqs last  enabled at (8305): [<ffff800011a6b934>] __raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:160 [inline]
hardirqs last  enabled at (8305): [<ffff800011a6b934>] _raw_spin_unlock_irqrestore+0xac/0x158 kernel/locking/spinlock.c:194
hardirqs last disabled at (8306): [<ffff800011a6b498>] __raw_spin_lock_irq include/linux/spinlock_api_smp.h:126 [inline]
hardirqs last disabled at (8306): [<ffff800011a6b498>] _raw_spin_lock_irq+0x38/0x13c kernel/locking/spinlock.c:170
softirqs last  enabled at (8286): [<ffff8000080310b0>] local_bh_enable+0x10/0x34 include/linux/bottom_half.h:31
softirqs last disabled at (8284): [<ffff80000803107c>] local_bh_disable+0x10/0x34 include/linux/bottom_half.h:18

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(sync_timeline_list_lock);
  <Interrupt>
    lock(sync_timeline_list_lock);

 *** DEADLOCK ***

3 locks held by syz-executor.3/5598:
 #0: ffff0000dc0c1270 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x128/0x170 fs/file.c:1088
 #1: ffff0000d5cb6668 (&p->lock){+.+.}-{3:3}, at: seq_read_iter+0xac/0xc44 fs/seq_file.c:182
 #2: ffff800015cef6b8 (sync_timeline_list_lock){?...}-{2:2}, at: spin_lock_irq include/linux/spinlock.h:388 [inline]
 #2: ffff800015cef6b8 (sync_timeline_list_lock){?...}-{2:2}, at: sync_info_debugfs_show+0x9c/0x464 drivers/dma-buf/sync_debug.c:147

stack backtrace:
CPU: 1 PID: 5598 Comm: syz-executor.3 Not tainted 5.15.156-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
 dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_usage_bug+0x64c/0x9a8 kernel/locking/lockdep.c:3920
 mark_lock_irq+0x980/0xd2c
 mark_lock+0x258/0x360 kernel/locking/lockdep.c:4591
 mark_held_locks kernel/locking/lockdep.c:4193 [inline]
 __trace_hardirqs_on_caller kernel/locking/lockdep.c:4211 [inline]
 lockdep_hardirqs_on_prepare+0x300/0x874 kernel/locking/lockdep.c:4278
 trace_hardirqs_on+0x2a4/0x50c kernel/trace/trace_preemptirq.c:49
 __raw_spin_unlock_irq include/linux/spinlock_api_smp.h:168 [inline]
 _raw_spin_unlock_irq+0x9c/0x134 kernel/locking/spinlock.c:202
 spin_unlock_irq include/linux/spinlock.h:413 [inline]
 sync_print_obj drivers/dma-buf/sync_debug.c:118 [inline]
 sync_info_debugfs_show+0x16c/0x464 drivers/dma-buf/sync_debug.c:153
 seq_read_iter+0x3e0/0xc44 fs/seq_file.c:230
 seq_read+0x388/0x4ec fs/seq_file.c:162
 vfs_read+0x278/0xb10 fs/read_write.c:483
 ksys_read+0x15c/0x26c fs/read_write.c:623
 __do_sys_read fs/read_write.c:633 [inline]
 __se_sys_read fs/read_write.c:631 [inline]
 __arm64_sys_read+0x7c/0x90 fs/read_write.c:631
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

Crashes (10):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/04/20 16:58 linux-5.15.y c52b9710c83d af24b050 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/15 13:28 linux-5.15.y fa3df276cd36 b9af7e61 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/15 13:28 linux-5.15.y fa3df276cd36 b9af7e61 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/15 13:28 linux-5.15.y fa3df276cd36 b9af7e61 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/15 13:28 linux-5.15.y fa3df276cd36 b9af7e61 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/10 22:47 linux-5.15.y cdfd0a7f0139 4320ec32 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/04/03 17:58 linux-5.15.y 9465fef4ae35 51c4dcff .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/03/09 07:52 linux-5.15.y 574362648507 6ee49f2e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/02/06 01:42 linux-5.15.y 6139f2a02fe0 6404acf9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
2024/01/05 22:12 linux-5.15.y 26c690eff0a5 28c42cff .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 inconsistent lock state in sync_info_debugfs_show
* Struck through repros no longer work on HEAD.