syzbot


possible deadlock in ext4_ioctl (2)

Status: upstream: reported C repro on 2024/07/11 06:29
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+9f5ef8b83a49f265fea6@syzkaller.appspotmail.com
First crash: 220d, last: 47d
Fix commit to backport (bisect log) :
tree: upstream
commit 5831788afb17b89c5b531fb60cbd798613ccbb63
Author: Petr Mladek <pmladek@suse.com>
Date: Thu Jun 23 14:51:56 2022 +0000

  Revert "printk: add kthread console printers"

  
Bug presence (2)
Date Name Commit Repro Result
2024/09/20 linux-5.15.y (ToT) 3a5928702e71 C [report] possible deadlock in dquot_commit
2024/09/20 upstream (ToT) baeb9a7d8b60 C Didn't crash
Similar bugs (6)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in ext4_ioctl 2 507d 606d 0/3 auto-obsoleted due to no activity on 2024/01/09 18:17
upstream possible deadlock in ext4_ioctl ext4 44 666d 860d 0/28 auto-obsoleted due to no activity on 2023/08/20 05:40
linux-6.1 possible deadlock in ext4_ioctl (2) 1 373d 373d 0/3 auto-obsoleted due to no activity on 2024/05/18 23:21
linux-6.1 possible deadlock in ext4_ioctl (3) 2 214d 246d 0/3 auto-obsoleted due to no activity on 2024/10/25 05:49
linux-5.15 possible deadlock in ext4_ioctl 1 380d 380d 0/3 auto-obsoleted due to no activity on 2024/05/12 20:19
linux-6.1 possible deadlock in ext4_ioctl (4) 1 71d 71d 0/3 upstream: reported on 2024/12/07 16:00
Last patch testing requests (2)
Created Duration User Patch Repo Result
2025/02/08 05:39 14m retest repro linux-5.15.y report log
2024/11/30 04:30 50m retest repro linux-5.15.y report log
Fix bisection attempts (2)
Created Duration User Patch Repo Result
2024/11/15 21:12 8h49m fix candidate upstream OK (1) job log
2024/10/15 01:31 0m fix candidate upstream error job log

Sample crash report:
loop0: detected capacity change from 0 to 512
ext4 filesystem being mounted at /root/syzkaller.MiOMdm/344/file0 supports timestamps until 2038 (0x7fffffff)
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor186/4268 is trying to acquire lock:
ffff88806ef4e628 (&ei->i_data_sem/1){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline]
ffff88806ef4e628 (&ei->i_data_sem/1){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
ffff88806ef4e628 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276

but task is already holding lock:
ffff88806ef4d238 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ei->i_data_sem/2){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ext4_map_blocks+0x391/0x1c70 fs/ext4/inode.c:597
       ext4_getblk+0x19f/0x710 fs/ext4/inode.c:869
       ext4_bread+0x2a/0x170 fs/ext4/inode.c:922
       ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:6520
       read_blk fs/quota/quota_tree.c:55 [inline]
       find_tree_dqentry+0x192/0xb60 fs/quota/quota_tree.c:617
       find_tree_dqentry+0x41a/0xb60 fs/quota/quota_tree.c:635
       find_dqentry fs/quota/quota_tree.c:647 [inline]
       qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:667
       v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333
       dquot_acquire+0x188/0x680 fs/quota/dquot.c:463
       ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
       ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474
       ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4974
       mount_bdev+0x2c9/0x3f0 fs/super.c:1398
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1528
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332
       dquot_acquire+0x188/0x680 fs/quota/dquot.c:463
       ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
       ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474
       ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4974
       mount_bdev+0x2c9/0x3f0 fs/super.c:1398
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1528
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0xdd8/0x1090 fs/quota/dquot.c:1750
       dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
       dquot_alloc_space include/linux/quotaops.h:310 [inline]
       swap_inode_boot_loader fs/ext4/ioctl.c:243 [inline]
       __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
       ext4_ioctl+0x4d2f/0x5b80 fs/ext4/ioctl.c:1276
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ei->i_data_sem/1){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
       swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline]
       __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
       ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->i_data_sem/2);
                               lock(&s->s_dquot.dqio_sem);
                               lock(&ei->i_data_sem/2);
  lock(&ei->i_data_sem/1);

 *** DEADLOCK ***

5 locks held by syz-executor186/4268:
 #0: ffff88807e270460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
 #1: ffff88806ef4d3b0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #1: ffff88806ef4d3b0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1118
 #2: ffff88806ef4e7a0 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:135 [inline]
 #2: ffff88806ef4e7a0 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
 #2: ffff88806ef4e7a0 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: ext4_ioctl+0x1fb2/0x5b80 fs/ext4/ioctl.c:1276
 #3: ffff88806ef4e940 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:834 [inline]
 #3: ffff88806ef4e940 (mapping.invalidate_lock){++++}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:152 [inline]
 #3: ffff88806ef4e940 (mapping.invalidate_lock){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
 #3: ffff88806ef4e940 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_ioctl+0x3965/0x5b80 fs/ext4/ioctl.c:1276
 #4: ffff88806ef4d238 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

stack backtrace:
CPU: 0 PID: 4268 Comm: syz-executor186 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write_nested+0x3b/0x60 kernel/locking/rwsem.c:1667
 swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline]
 __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
 ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:874 [inline]
 __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f4813534429
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff989614a8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000020000a40 RCX: 00007f4813534429
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000004
RBP: 0000000020000000 R08: 00007fff989614e0 R09: 00007fff989614e0
R10: 00000000000004a0 R11: 0000000000000246 R12: 0030656c69662f2e
R13: 0000000000000158 R14: 431bde82d7b634db R15: 00007fff98961500
 </TASK>

Crashes (13):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/20 13:11 linux-5.15.y 3a5928702e71 6f888b75 .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/12/31 22:47 linux-5.15.y 91786f140358 d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:21 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:20 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:18 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:16 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:16 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:15 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/09/20 09:15 linux-5.15.y 3a5928702e71 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/07/28 03:23 linux-5.15.y 7e89efd3ae1c 46eb10b7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/07/24 21:11 linux-5.15.y 7c6d66f0266f d1a1b0ca .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/07/24 02:00 linux-5.15.y 7c6d66f0266f e50e8da5 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
2024/07/11 06:29 linux-5.15.y f45bea23c39c c699c2eb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ext4_ioctl
* Struck through repros no longer work on HEAD.