syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.206/4845 is trying to acquire lock:
ffff88807b43e650 (sb_internal#2){.+.+}-{0:0}, at: __ocfs2_write_remove_suid+0x19b/0x780 fs/ocfs2/file.c:1388

but task is already holding lock:
ffff88805f8d3120 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_inode_lock_for_extent_tree+0xd6/0x190 fs/ocfs2/file.c:2213

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x237/0x8d0 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block+0xd1/0x4f0 fs/ocfs2/dir.c:508
       ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1842 [inline]
       ocfs2_dir_foreach_blk+0x264/0x19d0 fs/ocfs2/dir.c:1928
       ocfs2_dir_foreach fs/ocfs2/dir.c:1938 [inline]
       ocfs2_empty_dir+0x1a8/0x730 fs/ocfs2/dir.c:2156
       ocfs2_rename+0x21c0/0x3960 fs/ocfs2/namei.c:1499
       vfs_rename+0xbe1/0x1100 fs/namei.c:4840
       do_renameat2+0x8b7/0xf60 fs/namei.c:4993
       __do_sys_rename fs/namei.c:5039 [inline]
       __se_sys_rename fs/namei.c:5037 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:5037
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3a6/0x6f0 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xf5a/0x2510 fs/ocfs2/namei.c:361
       ocfs2_create+0x192/0x420 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3470 [inline]
       open_last_lookups fs/namei.c:3540 [inline]
       path_openat+0x11db/0x2fa0 fs/namei.c:3747
       do_filp_open+0x1e2/0x410 fs/namei.c:3777
       do_sys_openat2+0x150/0x4b0 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_openat fs/open.c:1287 [inline]
       __se_sys_openat fs/open.c:1282 [inline]
       __x64_sys_openat+0x135/0x160 fs/open.c:1282
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
       __ocfs2_write_remove_suid+0x19b/0x780 fs/ocfs2/file.c:1388
       ocfs2_write_remove_suid fs/ocfs2/file.c:1429 [inline]
       ocfs2_prepare_inode_for_write fs/ocfs2/file.c:2314 [inline]
       ocfs2_file_write_iter+0x9e3/0x1e70 fs/ocfs2/file.c:2454
       call_write_iter include/linux/fs.h:2173 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x745/0xd60 fs/read_write.c:594
       ksys_write+0x152/0x260 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &journal->j_trans_barrier --> &ocfs2_file_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&journal->j_trans_barrier);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(sb_internal#2);

 *** DEADLOCK ***

4 locks held by syz.0.206/4845:
 #0: ffff88801f7e9c70 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2bf/0x370 fs/file.c:1056
 #1: ffff88807b43e460 (sb_writers#13){.+.+}-{0:0}, at: vfs_write+0x295/0xd60 fs/read_write.c:590
 #2: ffff88805f8d3488 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff88805f8d3488 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x436/0x1e70 fs/ocfs2/file.c:2402
 #3: ffff88805f8d3120 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_inode_lock_for_extent_tree+0xd6/0x190 fs/ocfs2/file.c:2213

stack backtrace:
CPU: 0 PID: 4845 Comm: syz.0.206 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c42/0x7d10 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1811 [inline]
 sb_start_intwrite include/linux/fs.h:1928 [inline]
 ocfs2_start_trans+0x2a7/0x6f0 fs/ocfs2/journal.c:372
 __ocfs2_write_remove_suid+0x19b/0x780 fs/ocfs2/file.c:1388
 ocfs2_write_remove_suid fs/ocfs2/file.c:1429 [inline]
 ocfs2_prepare_inode_for_write fs/ocfs2/file.c:2314 [inline]
 ocfs2_file_write_iter+0x9e3/0x1e70 fs/ocfs2/file.c:2454
 call_write_iter include/linux/fs.h:2173 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x745/0xd60 fs/read_write.c:594
 ksys_write+0x152/0x260 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fc116e63cb9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fc1150bf028 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fc1170defa0 RCX: 00007fc116e63cb9
RDX: 000000000000029f RSI: 0000000000000000 RDI: 0000000000000004
RBP: 00007fc116ed1bf7 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fc1170df038 R14: 00007fc1170defa0 R15: 00007ffc2722af18
 </TASK>