syzbot

REISERFS warning (device loop2): sh-2029: %s: bitmap block (#%u) reading failed reiserfs_read_bitmap_block: reiserfs_read_bitmap_block
======================================================
WARNING: possible circular locking dependency detected
5.15.181-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor584/4269 is trying to acquire lock:
ffff0000e2c5a400 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
ffff0000e2c5a400 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
ffff0000e2c5a400 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338

but task is already holding lock:
ffff0000e2c5aaa0 (&type->i_mutex_dir_key#6
/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x55c/0x68c fs/reiserfs/xattr.c:309

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}:
       down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
       inode_lock_nested include/linux/fs.h:822 [inline]
       open_xa_root fs/reiserfs/xattr.c:127 [inline]
       open_xa_dir+0x118/0x57c fs/reiserfs/xattr.c:152
       xattr_lookup+0x3c/0x268 fs/reiserfs/xattr.c:395
       reiserfs_xattr_set_handle+0xd8/0xb34 fs/reiserfs/xattr.c:540
       reiserfs_xattr_set+0x388/0x4a8 fs/reiserfs/xattr.c:640
       trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31
       __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
       __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216
       __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
       vfs_setxattr+0x158/0x2ac fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x248/0x2ac fs/xattr.c:611
       path_setxattr+0x12c/0x25c fs/xattr.c:630
       __do_sys_lsetxattr fs/xattr.c:653 [inline]
       __se_sys_lsetxattr fs/xattr.c:649 [inline]
       __arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&type->i_mutex_dir_key#6){+.+.}-{3:3}:
       down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       vfs_rename+0x670/0xdcc fs/namei.c:4797
       do_renameat2+0x74c/0xcdc fs/namei.c:4985
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2928/0x651c kernel/locking/lockdep.c:5012
       lock_acquire+0x1f4/0x620 kernel/locking/lockdep.c:5623
       down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
       inode_lock_nested include/linux/fs.h:822 [inline]
       xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
       delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
       reiserfs_for_each_xattr+0x568/0x68c fs/reiserfs/xattr.c:311
       reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
       reiserfs_evict_inode+0x1d8/0x3e8 fs/reiserfs/inode.c:53
       evict+0x3c8/0x810 fs/inode.c:647
       iput_final fs/inode.c:1769 [inline]
       iput+0x6c4/0x77c fs/inode.c:1795
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x2f4/0x3ec fs/namei.c:4162
       do_rmdir+0x240/0x634 fs/namei.c:4210
       __do_sys_unlinkat fs/namei.c:4390 [inline]
       __se_sys_unlinkat fs/namei.c:4384 [inline]
       __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4384
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
  &type->i_mutex_dir_key#6/2 --> &type->i_mutex_dir_key#6 --> &type->i_mutex_dir_key#6/3

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->i_mutex_dir_key#6/3);
                               lock(&type->i_mutex_dir_key#6);
                               lock(&type->i_mutex_dir_key#6/3);
  lock(&type->i_mutex_dir_key#6/2);

 *** DEADLOCK ***

3 locks held by syz-executor584/4269:
 #0: ffff0000d5e42460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
 #1: ffff0000e2c5be80 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #1: ffff0000e2c5be80 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_rmdir+0x17c/0x634 fs/namei.c:4197
 #2: ffff0000e2c5aaa0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #2: ffff0000e2c5aaa0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x55c/0x68c fs/reiserfs/xattr.c:309

stack backtrace:
CPU: 0 PID: 4269 Comm: syz-executor584 Not tainted 5.15.181-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call trace:
 dump_backtrace+0x0/0x43c arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack+0x30/0x40 lib/dump_stack.c:88
 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2011
 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2928/0x651c kernel/locking/lockdep.c:5012
 lock_acquire+0x1f4/0x620 kernel/locking/lockdep.c:5623
 down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
 inode_lock_nested include/linux/fs.h:822 [inline]
 xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
 delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
 reiserfs_for_each_xattr+0x568/0x68c fs/reiserfs/xattr.c:311
 reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
 reiserfs_evict_inode+0x1d8/0x3e8 fs/reiserfs/inode.c:53
 evict+0x3c8/0x810 fs/inode.c:647
 iput_final fs/inode.c:1769 [inline]
 iput+0x6c4/0x77c fs/inode.c:1795
 d_delete_notify include/linux/fsnotify.h:267 [inline]
 vfs_rmdir+0x2f4/0x3ec fs/namei.c:4162
 do_rmdir+0x240/0x634 fs/namei.c:4210
 __do_sys_unlinkat fs/namei.c:4390 [inline]
 __se_sys_unlinkat fs/namei.c:4384 [inline]
 __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4384
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
 el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
 el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584