syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.52/4563 is trying to acquire lock:
ffff88805edd0090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x75/0xd0 fs/reiserfs/lock.c:27

but task is already holding lock:
ffff88802ed35b58 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
ffff88802ed35b58 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x15d/0x2b0 mm/util.c:518

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&mm->mmap_lock){++++}-{3:3}:
       __might_fault+0xc2/0x120 mm/memory.c:5852
       reiserfs_ioctl+0x13b/0x330 fs/reiserfs/ioctl.c:96
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:870 [inline]
       __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:856
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&sbi->lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       reiserfs_write_lock+0x75/0xd0 fs/reiserfs/lock.c:27
       reiserfs_dirty_inode+0xf0/0x240 fs/reiserfs/super.c:704
       __mark_inode_dirty+0x2eb/0xe90 fs/fs-writeback.c:2443
       generic_update_time fs/inode.c:1946 [inline]
       inode_update_time fs/inode.c:1959 [inline]
       touch_atime+0x3a7/0x620 fs/inode.c:2031
       file_accessed include/linux/fs.h:2600 [inline]
       generic_file_mmap+0xbe/0x120 mm/filemap.c:3579
       call_mmap include/linux/fs.h:2270 [inline]
       mmap_file+0x5d/0xb0 mm/util.c:1109
       __mmap_region mm/mmap.c:2772 [inline]
       mmap_region+0xe2c/0x1c70 mm/mmap.c:2916
       do_mmap+0x958/0xfd0 mm/mmap.c:1436
       vm_mmap_pgoff+0x1b2/0x2b0 mm/util.c:520
       ksys_mmap_pgoff+0x516/0x6f0 mm/mmap.c:1482
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&mm->mmap_lock);
                               lock(&sbi->lock);
                               lock(&mm->mmap_lock);
  lock(&sbi->lock);

 *** DEADLOCK ***

2 locks held by syz.0.52/4563:
 #0: ffff88802ed35b58 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:87 [inline]
 #0: ffff88802ed35b58 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x15d/0x2b0 mm/util.c:518
 #1: ffff888076f7e460 (sb_writers#13){.+.+}-{0:0}, at: file_accessed include/linux/fs.h:2600 [inline]
 #1: ffff888076f7e460 (sb_writers#13){.+.+}-{0:0}, at: generic_file_mmap+0xbe/0x120 mm/filemap.c:3579

stack backtrace:
CPU: 1 PID: 4563 Comm: syz.0.52 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
 reiserfs_write_lock+0x75/0xd0 fs/reiserfs/lock.c:27
 reiserfs_dirty_inode+0xf0/0x240 fs/reiserfs/super.c:704
 __mark_inode_dirty+0x2eb/0xe90 fs/fs-writeback.c:2443
 generic_update_time fs/inode.c:1946 [inline]
 inode_update_time fs/inode.c:1959 [inline]
 touch_atime+0x3a7/0x620 fs/inode.c:2031
 file_accessed include/linux/fs.h:2600 [inline]
 generic_file_mmap+0xbe/0x120 mm/filemap.c:3579
 call_mmap include/linux/fs.h:2270 [inline]
 mmap_file+0x5d/0xb0 mm/util.c:1109
 __mmap_region mm/mmap.c:2772 [inline]
 mmap_region+0xe2c/0x1c70 mm/mmap.c:2916
 do_mmap+0x958/0xfd0 mm/mmap.c:1436
 vm_mmap_pgoff+0x1b2/0x2b0 mm/util.c:520
 ksys_mmap_pgoff+0x516/0x6f0 mm/mmap.c:1482
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f2a6158f749
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2a62462038 EFLAGS: 00000246 ORIG_RAX: 0000000000000009
RAX: ffffffffffffffda RBX: 00007f2a617e6090 RCX: 00007f2a6158f749
RDX: 0000000000000002 RSI: 0000000000b36000 RDI: 0000200000000000
RBP: 00007f2a61613f91 R08: 0000000000000004 R09: 0000000000000000
R10: 0000000000028011 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f2a617e6128 R14: 00007f2a617e6090 R15: 00007ffdaf9ebc88
 </TASK>