syzbot

ocfs2: Mounting device (7,4) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.114-syzkaller #0 Not tainted
------------------------------------------------------
syz.4.666/7976 is trying to acquire lock:
ffff88805bf6a650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x68c/0xb60 fs/ocfs2/quota_global.c:843

but task is already holding lock:
ffff8880586f94a0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:308
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:308
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1750
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5727
       ext4_ext_map_blocks+0x1c1c/0x7ab0 fs/ext4/extents.c:4339
       ext4_map_blocks+0xa2b/0x1cb0 fs/ext4/inode.c:678
       ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889
       ext4_bread+0x2a/0x170 fs/ext4/inode.c:945
       ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83
       ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:3030
       ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3076
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4283
       ext4_setattr+0x10f5/0x1a00 fs/ext4/inode.c:5601
       notify_change+0xce3/0xfc0 fs/attr.c:499
       do_truncate+0x21c/0x300 fs/open.c:65
       do_sys_ftruncate+0x2e2/0x380 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdirat fs/namei.c:4146 [inline]
       __se_sys_mkdirat fs/namei.c:4144 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4144
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_acquire_dquot+0x68c/0xb60 fs/ocfs2/quota_global.c:843
       dqget+0x762/0xe90 fs/quota/dquot.c:986
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:308
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#2);

 *** DEADLOCK ***

6 locks held by syz.4.666/7976:
 #0: ffff88805bf6a460 (sb_writers#22){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
 #1: ffff888054ddb488 (&type->i_mutex_dir_key#25){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff888054ddb488 (&type->i_mutex_dir_key#25){++++}-{3:3}, at: open_last_lookups fs/namei.c:3547 [inline]
 #1: ffff888054ddb488 (&type->i_mutex_dir_key#25){++++}-{3:3}, at: path_openat+0x7b6/0x2e60 fs/namei.c:3780
 #2: ffff8880586fd108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff8880586fd108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x182/0x5190 fs/ocfs2/suballoc.c:782
 #3: ffff888054f7c0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x2a0/0xb60 fs/ocfs2/quota_global.c:806
 #4: ffff8880586f9808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff8880586f9808 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
 #5: ffff8880586f94a0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 0 PID: 7976 Comm: syz.4.666 Not tainted 6.1.114-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
 ocfs2_acquire_dquot+0x68c/0xb60 fs/ocfs2/quota_global.c:843
 dqget+0x762/0xe90 fs/quota/dquot.c:986
 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515
 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
 ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:308
 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672
 lookup_open fs/namei.c:3482 [inline]
 open_last_lookups fs/namei.c:3550 [inline]
 path_openat+0x12f1/0x2e60 fs/namei.c:3780
 do_filp_open+0x230/0x480 fs/namei.c:3810
 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
 do_sys_open fs/open.c:1334 [inline]
 __do_sys_openat fs/open.c:1350 [inline]
 __se_sys_openat fs/open.c:1345 [inline]
 __x64_sys_openat+0x243/0x290 fs/open.c:1345
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f557af7e719
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f557bd27038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f557b135f80 RCX: 00007f557af7e719
RDX: 000000000000275a RSI: 0000000020000040 RDI: ffffffffffffff9c
RBP: 00007f557aff132e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f557b135f80 R15: 00007ffc40915bd8
 </TASK>