======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.7.343/6407 is trying to acquire lock:
ffff888025ab0650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_write_info+0x117/0x350 fs/ocfs2/quota_global.c:982

but task is already holding lock:
ffff8880602da2e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_symlink+0xbec/0x25d0 fs/ocfs2/namei.c:1875
       vfs_symlink+0x247/0x3d0 fs/namei.c:4437
       do_symlinkat+0x1be/0x6c0 fs/namei.c:4466
       __do_sys_symlink fs/namei.c:4488 [inline]
       __se_sys_symlink fs/namei.c:4486 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4486
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_symlink+0xbec/0x25d0 fs/ocfs2/namei.c:1875
       vfs_symlink+0x247/0x3d0 fs/namei.c:4437
       do_symlinkat+0x1be/0x6c0 fs/namei.c:4466
       __do_sys_symlink fs/namei.c:4488 [inline]
       __se_sys_symlink fs/namei.c:4486 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4486
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6185
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x7ca/0xb90 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
       dquot_free_space include/linux/quotaops.h:381 [inline]
       dquot_free_block include/linux/quotaops.h:392 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6151 [inline]
       ext4_free_blocks+0x1af5/0x2480 fs/ext4/mballoc.c:6281
       ext4_remove_blocks fs/ext4/extents.c:2507 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
       ext4_ext_remove_space+0x22c4/0x43a0 fs/ext4/extents.c:2939
       ext4_ext_truncate+0x192/0x240 fs/ext4/extents.c:4473
       ext4_truncate+0x9f1/0x10d0 fs/ext4/inode.c:4256
       ext4_setattr+0xffe/0x19e0 fs/ext4/inode.c:5597
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x197/0x220 fs/open.c:65
       handle_truncate fs/namei.c:3273 [inline]
       do_open fs/namei.c:3620 [inline]
       path_openat+0x28af/0x2f30 fs/namei.c:3750
       do_filp_open+0x1b3/0x3e0 fs/namei.c:3777
       do_sys_openat2+0x142/0x4a0 fs/open.c:1255
       do_sys_open fs/open.c:1271 [inline]
       __do_sys_open fs/open.c:1279 [inline]
       __se_sys_open fs/open.c:1275 [inline]
       __x64_sys_open+0x11b/0x140 fs/open.c:1275
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_truncate+0x96d/0x10d0 fs/ext4/inode.c:4251
       ext4_setattr+0xffe/0x19e0 fs/ext4/inode.c:5597
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x197/0x220 fs/open.c:65
       do_sys_ftruncate+0x31b/0x3d0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361
       ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4073
       do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098
       __do_sys_mkdirat fs/namei.c:4113 [inline]
       __se_sys_mkdirat fs/namei.c:4111 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_mknod+0xe2f/0x22b0 fs/ocfs2/namei.c:361
       ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4073
       do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098
       __do_sys_mkdirat fs/namei.c:4113 [inline]
       __se_sys_mkdirat fs/namei.c:4111 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (sb_internal#3){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_write_info+0x117/0x350 fs/ocfs2/quota_global.c:982
       dquot_set_dqinfo+0x459/0x6c0 fs/quota/dquot.c:2904
       quota_setinfo+0x2a4/0x2b0 fs/quota/quota.c:173
       __do_sys_quotactl fs/quota/quota.c:959 [inline]
       __se_sys_quotactl+0x295/0x6c0 fs/quota/quota.c:915
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  sb_internal#3 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#3);

 *** DEADLOCK ***

3 locks held by syz.7.343/6407:
 #0: ffff888025ab00e0 (&type->s_umount_key#66){++++}-{3:3}, at: user_get_super+0x118/0x240 fs/super.c:850
 #1: ffff8880602da648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff8880602da648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
 #2: ffff8880602da2e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 0 PID: 6407 Comm: syz.7.343 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1811 [inline]
 sb_start_intwrite include/linux/fs.h:1928 [inline]
 ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_write_info+0x117/0x350 fs/ocfs2/quota_global.c:982
 dquot_set_dqinfo+0x459/0x6c0 fs/quota/dquot.c:2904
 quota_setinfo+0x2a4/0x2b0 fs/quota/quota.c:173
 __do_sys_quotactl fs/quota/quota.c:959 [inline]
 __se_sys_quotactl+0x295/0x6c0 fs/quota/quota.c:915
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f0a2203f749
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0a20285038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3
RAX: ffffffffffffffda RBX: 00007f0a22296090 RCX: 00007f0a2203f749
RDX: 0000000000000000 RSI: 0000200000000040 RDI: ffffffff80000601
RBP: 00007f0a220c3f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000200000000100 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f0a22296128 R14: 00007f0a22296090 R15: 00007ffecb025978
 </TASK>