syzbot


panic: Incrementing non-positive count ADDR on kernel.ProcessGroup

Status: fixed on 2021/02/10 20:40
Fix commit: fe4f4789601d kernel: reparentLocked has to update children maps of old and new parents
First crash: 1401d, last: 1401d
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
gvisor panic: Incrementing non-positive count ADDR on kernel.ProcessGroup (2) 1 1259d 1259d 14/26 fixed on 2021/06/25 12:16

Sample crash report:
panic: Incrementing non-positive count 0xc00052e100 on kernel.ProcessGroup

goroutine 1217 [running]:
panic(0xfc8ac0, 0xc0004aa4a0)
	GOROOT/src/runtime/panic.go:1064 +0x470 fp=0xc0008078b0 sp=0xc0008077f8 pc=0x437110
gvisor.dev/gvisor/pkg/sentry/kernel.(*ProcessGroupRefs).IncRef(0xc00052e100)
	bazel-out/k8-fastbuild-ST-3bfd66f45e612c1a5c797474a25664e227d81bf914f3b08a40e00b2e2692afa4/bin/pkg/sentry/kernel/process_group_refs.go:72 +0x15f fp=0xc000807928 sp=0xc0008078b0 pc=0x9a08ff
gvisor.dev/gvisor/pkg/sentry/kernel.(*ProcessGroup).incRefWithParent(...)
	pkg/sentry/kernel/sessions.go:144
gvisor.dev/gvisor/pkg/sentry/kernel.(*ThreadGroup).CreateProcessGroup.func1(0xc000a35800)
	pkg/sentry/kernel/sessions.go:407 +0x5d fp=0xc000807950 sp=0xc000807928 pc=0x9e8c1d
gvisor.dev/gvisor/pkg/sentry/kernel.(*ThreadGroup).forEachChildThreadGroupLocked(0xc000a35000, 0xc000807a30)
	pkg/sentry/kernel/thread_group.go:340 +0x77 fp=0xc0008079e0 sp=0xc000807950 pc=0x9d1257
gvisor.dev/gvisor/pkg/sentry/kernel.(*ThreadGroup).CreateProcessGroup(0xc000a35000, 0x0, 0x0)
	pkg/sentry/kernel/sessions.go:406 +0x294 fp=0xc000807a68 sp=0xc0008079e0 pc=0x9aaeb4
gvisor.dev/gvisor/pkg/sentry/syscalls/linux.Setpgid(0xc0004d0a80, 0xf, 0x0, 0x434c49, 0x0, 0x1, 0x1, 0xf, 0xc000525400, 0x0, ...)
	pkg/sentry/syscalls/linux/sys_thread.go:616 +0xa5 fp=0xc000807af8 sp=0xc000807a68 pc=0xa54325
gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).executeSyscall(0xc0004d0a80, 0x6d, 0xf, 0x0, 0x434c49, 0x0, 0x1, 0x1, 0xdd45b7, 0x11a1360, ...)
	pkg/sentry/kernel/task_syscall.go:104 +0x13c fp=0xc000807c58 sp=0xc000807af8 pc=0x9cc39c
gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscallInvoke(0xc0004d0a80, 0x6d, 0xf, 0x0, 0x434c49, 0x0, 0x1, 0x1, 0x1, 0x1)
	pkg/sentry/kernel/task_syscall.go:239 +0x66 fp=0xc000807ce0 sp=0xc000807c58 pc=0x9cd566
gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscallEnter(0xc0004d0a80, 0x6d, 0xf, 0x0, 0x434c49, 0x0, 0x1, 0x1, 0x0, 0x0)
	pkg/sentry/kernel/task_syscall.go:199 +0x98 fp=0xc000807d40 sp=0xc000807ce0 pc=0x9cd118
gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscall(0xc0004d0a80, 0x2, 0xc0004d0a80)
	pkg/sentry/kernel/task_syscall.go:174 +0x15c fp=0xc000807e10 sp=0xc000807d40 pc=0x9ccabc
gvisor.dev/gvisor/pkg/sentry/kernel.(*runApp).execute(0x0, 0xc0004d0a80, 0x12f1ec0, 0x0)
	pkg/sentry/kernel/task_run.go:282 +0xc45 fp=0xc000807f60 sp=0xc000807e10 pc=0x9c0ec5
gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).run(0xc0004d0a80, 0x24)
	pkg/sentry/kernel/task_run.go:97 +0x1af fp=0xc000807fd0 sp=0xc000807f60 pc=0x9bfb8f
runtime.goexit()
	src/runtime/asm_amd64.s:1374 +0x1 fp=0xc000807fd8 sp=0xc000807fd0 pc=0x470681
created by gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).Start
	pkg/sentry/kernel/task_start.go:323 +0xfe

Crashes (12):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/01/24 16:44 gvisor 65594d30ad1b 52e37319 .config console log report syz C ci-gvisor-kvm panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:43 gvisor f5736fa2bf91 52e37319 .config console log report syz C ci-gvisor-kvm-cover panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:29 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-2-race panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:28 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-3-race panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:28 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-3 panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:27 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-2 panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:26 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-2-cover panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:20 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-1-race panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:20 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-1 panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:19 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-3-cover panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 16:08 gvisor cac70c65e6b5 52e37319 .config console log report syz C ci-gvisor-ptrace-1-cover panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
2021/01/24 15:55 gvisor cac70c65e6b5 52e37319 .config console log report info ci-gvisor-ptrace-1-cover panic: Incrementing non-positive count ADDR on kernel.ProcessGroup
* Struck through repros no longer work on HEAD.