possible deadlock in __might

possible deadlock in __might_fault
Status: upstream: reported C repro on 2019/04/13 04:10
Reported-by: syzbot+dd3e1ed823e8f95e8845@syzkaller.appspotmail.com
First crash: 218d, last: 5h02m

similar bugs (7):
Kernel	Title	Repro	Count	Last	Reported	Patched	Status
upstream	possible deadlock in __might_fault	C	8978	612d	628d	4/14	fixed on 2018/03/23 18:14
linux-4.19	possible deadlock in __might_fault	C	343	12h10m	219d	0/1	upstream: reported C repro on 2019/04/12 04:47
android-44	possible deadlock in __might_fault	C	6745	602d	629d	2/2	fixed on 2018/04/24 18:02
android-49	possible deadlock in __might_fault	C	10264	607d	629d	3/3	fixed on 2018/04/24 17:23
android-414	possible deadlock in __might_fault		134	27d	218d	0/1	public: reported on 2019/04/13 00:01
upstream	possible deadlock in __might_fault (3)	C	10580	8h27m	443d	0/14	closed as dup on 2018/09/16 01:51
upstream	possible deadlock in __might_fault (2)	C	20	565d	568d	9/14	fixed on 2018/07/09 18:05

Sample crash report:

random: sshd: uninitialized urandom read (32 bytes read)
audit: type=1400 audit(1555153503.677:36): avc:  denied  { map } for  pid=7072 comm="syz-executor258" path="/root/syz-executor258664817" dev="sda1" ino=16484 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
IPVS: ftp: loaded support on port[0] = 21
audit: type=1400 audit(1555153504.687:37): avc:  denied  { map } for  pid=7073 comm="syz-executor258" path="/dev/usbmon0" dev="devtmpfs" ino=15377 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023 tcontext=system_u:object_r:usbmon_device_t:s0 tclass=chr_file permissive=1
======================================================
WARNING: possible circular locking dependency detected
4.14.111 #1 Not tainted
------------------------------------------------------
syz-executor258/7074 is trying to acquire lock:
 (&mm->mmap_sem){++++}, at: [<ffffffff817b9850>] __might_fault+0xe0/0x1d0 mm/memory.c:4577

but task is already holding lock:
 (&rp->fetch_lock){+.+.}, at: [<ffffffff83f7da6d>] mon_bin_read+0x5d/0x5e0 drivers/usb/mon/mon_bin.c:813

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&rp->fetch_lock){+.+.}:
       lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893
       mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908
       mon_bin_vma_fault+0x6f/0x280 drivers/usb/mon/mon_bin.c:1236
       __do_fault+0x109/0x390 mm/memory.c:3217
       do_read_fault mm/memory.c:3627 [inline]
       do_fault mm/memory.c:3753 [inline]
       handle_pte_fault mm/memory.c:3983 [inline]
       __handle_mm_fault+0x2465/0x3470 mm/memory.c:4107
       handle_mm_fault+0x293/0x7c0 mm/memory.c:4144
       faultin_page mm/gup.c:502 [inline]
       __get_user_pages+0x465/0x1250 mm/gup.c:702
       populate_vma_page_range+0x18e/0x230 mm/gup.c:1219
       __mm_populate+0x198/0x2c0 mm/gup.c:1267
       mm_populate include/linux/mm.h:2174 [inline]
       vm_mmap_pgoff+0x1be/0x1d0 mm/util.c:338
       SYSC_mmap_pgoff mm/mmap.c:1550 [inline]
       SyS_mmap_pgoff+0x3ca/0x520 mm/mmap.c:1508
       SYSC_mmap arch/x86/kernel/sys_x86_64.c:100 [inline]
       SyS_mmap+0x16/0x20 arch/x86/kernel/sys_x86_64.c:91
       do_syscall_64+0x1eb/0x630 arch/x86/entry/common.c:289
       entry_SYSCALL_64_after_hwframe+0x42/0xb7

-> #0 (&mm->mmap_sem){++++}:
       check_prev_add kernel/locking/lockdep.c:1901 [inline]
       check_prevs_add kernel/locking/lockdep.c:2018 [inline]
       validate_chain kernel/locking/lockdep.c:2460 [inline]
       __lock_acquire+0x2c89/0x45e0 kernel/locking/lockdep.c:3487
       lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994
       __might_fault mm/memory.c:4578 [inline]
       __might_fault+0x143/0x1d0 mm/memory.c:4563
       _copy_to_user+0x2c/0xd0 lib/usercopy.c:25
       copy_to_user include/linux/uaccess.h:155 [inline]
       mon_bin_read+0x2fb/0x5e0 drivers/usb/mon/mon_bin.c:825
       __vfs_read+0x107/0x6b0 fs/read_write.c:411
       vfs_read+0x137/0x350 fs/read_write.c:447
       SYSC_read fs/read_write.c:573 [inline]
       SyS_read+0xb8/0x180 fs/read_write.c:566
       do_syscall_64+0x1eb/0x630 arch/x86/entry/common.c:289
       entry_SYSCALL_64_after_hwframe+0x42/0xb7

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&rp->fetch_lock);
                               lock(&mm->mmap_sem);
                               lock(&rp->fetch_lock);
  lock(&mm->mmap_sem);

 *** DEADLOCK ***

1 lock held by syz-executor258/7074:
 #0:  (&rp->fetch_lock){+.+.}, at: [<ffffffff83f7da6d>] mon_bin_read+0x5d/0x5e0 drivers/usb/mon/mon_bin.c:813

stack backtrace:
CPU: 1 PID: 7074 Comm: syz-executor258 Not tainted 4.14.111 #1
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x138/0x19c lib/dump_stack.c:53
 print_circular_bug.isra.0.cold+0x1cc/0x28f kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1901 [inline]
 check_prevs_add kernel/locking/lockdep.c:2018 [inline]
 validate_chain kernel/locking/lockdep.c:2460 [inline]
 __lock_acquire+0x2c89/0x45e0 kernel/locking/lockdep.c:3487
 lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994
 __might_fault mm/memory.c:4578 [inline]
 __might_fault+0x143/0x1d0 mm/memory.c:4563
 _copy_to_user+0x2c/0xd0 lib/usercopy.c:25
 copy_to_user include/linux/uaccess.h:155 [inline]
 mon_bin_read+0x2fb/0x5e0 drivers/usb/mon/mon_bin.c:825
 __vfs_read+0x107/0x6b0 fs/read_write.c:411
 vfs_read+0x137/0x350 fs/read_write.c:447
 SYSC_read fs/read_write.c:573 [inline]
 SyS_read+0xb8/0x180 fs/read_write.c:566
 do_syscall_64+0x1eb/0x630 arch/x86/entry/common.c:289
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x449f19
RSP: 002b:00007f1a6f744ce8 EFLAGS: 00000246 ORIG_RAX: 0000000000000000
RAX: ffffffffffffffda RBX: 00000000006dbc28 RCX: 0000000000449f19
RDX: 000000000000002f RSI: 0000000000000000 RDI: 0000000000000003
RBP: 00000000006dbc20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006dbc2c
R13: 00007fff9c54b37f R14: 00007f1a6f7459c0 R15: 000000000000002d

Crashes (270):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci2-linux-4-14	2019/04/13 11:08	linux-4.14.y	1ec8f1f0	c402d8f1	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 13:30	linux-4.14.y	b98aebd2	b24d2b8a	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 09:47	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 08:54	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 07:46	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 07:27	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 06:43	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/06/16 12:34	linux-4.14.y	a74d0e93	442206d7	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/22 06:01	linux-4.14.y	68d7a45e	b0e8efcb	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/22 01:28	linux-4.14.y	68d7a45e	b0e8efcb	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/21 22:00	linux-4.14.y	68d7a45e	b0e8efcb	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/20 06:01	linux-4.14.y	58b454eb	b0e8efcb	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/19 08:51	linux-4.14.y	58b454eb	b0e8efcb	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/16 19:52	linux-4.14.y	1ec8f1f0	505ab413	.config	log	report	syz	C	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/22 06:05	linux-4.14.y	b98aebd2	c59a7cd8	.config	log	report	syz		gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/04/13 03:10	linux-4.14.y	1ec8f1f0	c402d8f1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/11/17 09:57	linux-4.14.y	775d01b6	d5696d51	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/11/17 07:50	linux-4.14.y	775d01b6	cdac920b	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/11/12 16:50	linux-4.14.y	4762bcd4	048f2d49	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/11/11 14:03	linux-4.14.y	c9fda4f2	dc438b91	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/11/11 12:27	linux-4.14.y	c9fda4f2	dc438b91	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/11/11 00:21	linux-4.14.y	c9fda4f2	dc438b91	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/23 02:31	linux-4.14.y	b98aebd2	d0686497	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/21 02:42	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/20 19:38	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/20 10:16	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/19 23:55	linux-4.14.y	b98aebd2	8c88c9c1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/17 16:38	linux-4.14.y	e132c8d7	8c88c9c1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/17 03:41	linux-4.14.y	e132c8d7	8c88c9c1	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/13 05:40	linux-4.14.y	e132c8d7	426631dd	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/11 09:05	linux-4.14.y	42327896	1a3bad90	.config	log	report			linux-kernel@vger.kernel.org, linux-mm@kvack.org
ci2-linux-4-14	2019/10/07 05:37	linux-4.14.y	db189223	f3f7d9c8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/06 22:35	linux-4.14.y	db189223	f3f7d9c8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/06 09:04	linux-4.14.y	db189223	f3f7d9c8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/05 12:27	linux-4.14.y	db189223	f3f7d9c8	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/04 16:54	linux-4.14.y	f6e27dbb	c86336cf	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/04 15:12	linux-4.14.y	f6e27dbb	c86336cf	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/03 22:44	linux-4.14.y	f6e27dbb	fc17ba49	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/10/01 09:26	linux-4.14.y	f6e27dbb	c7a4fb99	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/28 11:10	linux-4.14.y	f6e27dbb	eb6b9855	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/27 10:06	linux-4.14.y	f6e27dbb	2f1548bc	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/26 01:59	linux-4.14.y	f6e27dbb	24d405a3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/25 13:55	linux-4.14.y	f6e27dbb	a3355dba	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/24 13:29	linux-4.14.y	f6e27dbb	f8368f99	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/23 16:47	linux-4.14.y	f6e27dbb	c68252d2	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/23 14:32	linux-4.14.y	f6e27dbb	1e9788a0	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/23 11:22	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/23 05:59	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/23 04:46	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/23 00:17	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 20:59	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 20:54	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 16:57	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 15:24	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 12:50	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 09:46	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/22 03:20	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/21 22:47	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/21 20:30	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/21 07:21	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/21 06:16	linux-4.14.y	f6e27dbb	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/20 09:20	linux-4.14.y	b10ab5e2	d96e88f3	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
ci2-linux-4-14	2019/09/19 20:41	linux-4.14.y	b10ab5e2	4d3ae0b7	.config	log	report			gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org