syzbot

REISERFS (device loop4): Using tea hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
5.15.133-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/10866 is trying to acquire lock:
ffff888024bb9090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27

but task is already holding lock:
ffff8880264896c0 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
ffff8880264896c0 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}, at: filename_create+0x256/0x530 fs/namei.c:3765

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       down_write_nested+0xa0/0x180 kernel/locking/rwsem.c:1657
       inode_lock_nested include/linux/fs.h:822 [inline]
       filename_create+0x256/0x530 fs/namei.c:3765
       do_mkdirat+0xb3/0x520 fs/namei.c:4009
       __do_sys_mkdir fs/namei.c:4039 [inline]
       __se_sys_mkdir fs/namei.c:4037 [inline]
       __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4037
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (sb_writers#27){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1742 [inline]
       sb_start_write+0x4f/0x1c0 include/linux/fs.h:1812
       mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
       reiserfs_ioctl+0x170/0x340 fs/reiserfs/ioctl.c:103
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&sbi->lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
       reiserfs_lookup+0x15c/0x4b0 fs/reiserfs/namei.c:364
       __lookup_hash+0x117/0x240 fs/namei.c:1560
       filename_create+0x28d/0x530 fs/namei.c:3766
       do_mkdirat+0xb3/0x520 fs/namei.c:4009
       __do_sys_mkdir fs/namei.c:4039 [inline]
       __se_sys_mkdir fs/namei.c:4037 [inline]
       __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4037
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
  &sbi->lock --> sb_writers#27 --> &type->i_mutex_dir_key#17/1

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&type->i_mutex_dir_key#17/1);
                               lock(sb_writers#27);
                               lock(&type->i_mutex_dir_key#17/1);
  lock(&sbi->lock);

 *** DEADLOCK ***

2 locks held by syz-executor.4/10866:
 #0: ffff888072e80460 (sb_writers#27){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff8880264896c0 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #1: ffff8880264896c0 (&type->i_mutex_dir_key#17/1){+.+.}-{3:3}, at: filename_create+0x256/0x530 fs/namei.c:3765

stack backtrace:
CPU: 1 PID: 10866 Comm: syz-executor.4 Not tainted 5.15.133-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
 reiserfs_lookup+0x15c/0x4b0 fs/reiserfs/namei.c:364
 __lookup_hash+0x117/0x240 fs/namei.c:1560
 filename_create+0x28d/0x530 fs/namei.c:3766
 do_mkdirat+0xb3/0x520 fs/namei.c:4009
 __do_sys_mkdir fs/namei.c:4039 [inline]
 __se_sys_mkdir fs/namei.c:4037 [inline]
 __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4037
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f688e708ae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f688cc8a0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000053
RAX: ffffffffffffffda RBX: 00007f688e827f80 RCX: 00007f688e708ae9
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000400
RBP: 00007f688e75447a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f688e827f80 R15: 00007ffc24a9b088
 </TASK>
overlayfs: upper fs needs to support d_type.
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: failed to set xattr on upper
overlayfs: ...falling back to index=off,metacopy=off.