syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.166-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.15/3675 is trying to acquire lock:
ffff888028cf0c28 ((work_completion)(&hdev->bg_scan_update)){+.+.}-{0:0}, at: __flush_work+0xcf/0x1a0 kernel/workqueue.c:3090

but task is already holding lock:
ffffffff8dcbd988 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a5/0x790 net/rfkill/core.c:1266

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (rfkill_global_mutex){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       rfkill_register+0x30/0x880 net/rfkill/core.c:1045
       hci_register_dev+0x4dd/0xa50 net/bluetooth/hci_core.c:3960
       __vhci_create_device drivers/bluetooth/hci_vhci.c:129 [inline]
       vhci_create_device+0x310/0x590 drivers/bluetooth/hci_vhci.c:153
       vhci_get_user drivers/bluetooth/hci_vhci.c:210 [inline]
       vhci_write+0x382/0x430 drivers/bluetooth/hci_vhci.c:290
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0xacd/0xe50 fs/read_write.c:594
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&data->open_mutex){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       vhci_send_frame+0x8a/0xf0 drivers/bluetooth/hci_vhci.c:71
       hci_send_frame+0x1af/0x2f0 net/bluetooth/hci_core.c:4256
       hci_sched_acl_pkt net/bluetooth/hci_core.c:4781 [inline]
       hci_sched_acl net/bluetooth/hci_core.c:4866 [inline]
       hci_tx_work+0xb2e/0x1a30 net/bluetooth/hci_core.c:4932
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #2 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
       hci_dev_do_close+0x20a/0x1070 net/bluetooth/hci_core.c:1756
       hci_unregister_dev+0x2d7/0x580 net/bluetooth/hci_core.c:4040
       vhci_release+0x73/0xc0 drivers/bluetooth/hci_vhci.c:345
       __fput+0x3fe/0x8e0 fs/file_table.c:280
       task_work_run+0x129/0x1a0 kernel/task_work.c:188
       exit_task_work include/linux/task_work.h:33 [inline]
       do_exit+0x6a3/0x2480 kernel/exit.c:874
       do_group_exit+0x144/0x310 kernel/exit.c:996
       get_signal+0xc66/0x14e0 kernel/signal.c:2897
       arch_do_signal_or_restart+0xc3/0x1890 arch/x86/kernel/signal.c:867
       handle_signal_work kernel/entry/common.c:154 [inline]
       exit_to_user_mode_loop+0x97/0x130 kernel/entry/common.c:178
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&hdev->req_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hci_req_sync net/bluetooth/hci_request.c:278 [inline]
       bg_scan_update+0xa1/0x4a0 net/bluetooth/hci_request.c:2952
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:334
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #0 ((work_completion)(&hdev->bg_scan_update)){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
       __cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
       hci_request_cancel_all+0xcb/0x300 net/bluetooth/hci_request.c:3522
       hci_dev_do_close+0x51/0x1070 net/bluetooth/hci_core.c:1736
       hci_rfkill_set_block+0x114/0x1a0 net/bluetooth/hci_core.c:2235
       rfkill_set_block+0x1e7/0x430 net/rfkill/core.c:345
       rfkill_fop_write+0x5b7/0x790 net/rfkill/core.c:1274
       vfs_write+0x30c/0xe50 fs/read_write.c:592
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  (work_completion)(&hdev->bg_scan_update) --> &data->open_mutex --> rfkill_global_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(rfkill_global_mutex);
                               lock(&data->open_mutex);
                               lock(rfkill_global_mutex);
  lock((work_completion)(&hdev->bg_scan_update));

 *** DEADLOCK ***

1 lock held by syz.0.15/3675:
 #0: ffffffff8dcbd988 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a5/0x790 net/rfkill/core.c:1266

stack backtrace:
CPU: 1 PID: 3675 Comm: syz.0.15 Not tainted 5.15.166-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
 __cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
 hci_request_cancel_all+0xcb/0x300 net/bluetooth/hci_request.c:3522
 hci_dev_do_close+0x51/0x1070 net/bluetooth/hci_core.c:1736
 hci_rfkill_set_block+0x114/0x1a0 net/bluetooth/hci_core.c:2235
 rfkill_set_block+0x1e7/0x430 net/rfkill/core.c:345
 rfkill_fop_write+0x5b7/0x790 net/rfkill/core.c:1274
 vfs_write+0x30c/0xe50 fs/read_write.c:592
 ksys_write+0x1a2/0x2c0 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f389b309ef9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd00635268 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f389b4c2f80 RCX: 00007f389b309ef9
RDX: 0000000000000008 RSI: 0000000020000240 RDI: 0000000000000003
RBP: 00007f389b37c046 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f389b4c2f80 R14: 00007f389b4c2f80 R15: 00000000000014c2
 </TASK>