syzbot


possible deadlock in hci_conn_hash_flush

Status: auto-obsoleted due to no activity on 2023/11/27 03:55
Reported-by: syzbot+7d6c2af7fec7addcb8c2@syzkaller.appspotmail.com
First crash: 537d, last: 460d
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hci_conn_hash_flush (2) origin:lts-only syz done 13 192d 268d 0/3 upstream: reported syz repro on 2024/02/27 07:43
upstream possible deadlock in hci_conn_hash_flush bluetooth 4 642d 773d 0/28 auto-obsoleted due to no activity on 2023/06/17 14:27
linux-5.15 possible deadlock in hci_conn_hash_flush (2) origin:lts-only syz error 5 178d 302d 0/3 upstream: reported syz repro on 2024/01/23 23:43
linux-6.1 possible deadlock in hci_conn_hash_flush 5 484d 589d 0/3 auto-obsoleted due to no activity on 2023/11/03 12:59

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
5.15.127-syzkaller #0 Not tainted
------------------------------------------------------
kworker/u5:3/3535 is trying to acquire lock:
ffff88801d7c8470 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}, at: __flush_work+0xcf/0x1a0 kernel/workqueue.c:3090

but task is already holding lock:
ffffffff8db2bdc8 (hci_cb_list_lock){+.+.}-{3:3}, at: hci_disconn_cfm include/net/bluetooth/hci_core.h:1518 [inline]
ffffffff8db2bdc8 (hci_cb_list_lock){+.+.}-{3:3}, at: hci_conn_hash_flush+0xb8/0x210 net/bluetooth/hci_conn.c:1610

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (hci_cb_list_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hci_connect_cfm include/net/bluetooth/hci_core.h:1503 [inline]
       hci_remote_features_evt+0x6d1/0xb50 net/bluetooth/hci_event.c:3323
       hci_event_packet+0x6da/0x1480 net/bluetooth/hci_event.c:6376
       hci_rx_work+0x240/0x7d0 net/bluetooth/hci_core.c:5153
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:319
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

-> #2 (&hdev->lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       sco_sock_connect+0x181/0x8c0 net/bluetooth/sco.c:587
       __sys_connect_file net/socket.c:1899 [inline]
       __sys_connect+0x38b/0x410 net/socket.c:1916
       __do_sys_connect net/socket.c:1926 [inline]
       __se_sys_connect net/socket.c:1923 [inline]
       __x64_sys_connect+0x76/0x80 net/socket.c:1923
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       lock_sock_nested+0x44/0x100 net/core/sock.c:3230
       lock_sock include/net/sock.h:1661 [inline]
       sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:96
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:319
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

-> #0 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
       __cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
       sco_conn_del+0x205/0x300 net/bluetooth/sco.c:204
       hci_disconn_cfm include/net/bluetooth/hci_core.h:1521 [inline]
       hci_conn_hash_flush+0x10d/0x210 net/bluetooth/hci_conn.c:1610
       hci_dev_do_close+0x9f6/0x1000 net/bluetooth/hci_core.c:1795
       hci_error_reset+0xcd/0x160 net/bluetooth/hci_core.c:2340
       process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
       worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
       kthread+0x3f6/0x4f0 kernel/kthread.c:319
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298

other info that might help us debug this:

Chain exists of:
  (work_completion)(&(&conn->timeout_work)->work) --> &hdev->lock --> hci_cb_list_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(hci_cb_list_lock);
                               lock(&hdev->lock);
                               lock(hci_cb_list_lock);
  lock((work_completion)(&(&conn->timeout_work)->work));

 *** DEADLOCK ***

5 locks held by kworker/u5:3/3535:
 #0: ffff88807b76b138 ((wq_completion)hci5){+.+.}-{0:0}, at: process_one_work+0x78a/0x10c0 kernel/workqueue.c:2283
 #1: ffffc90002e4fd20 ((work_completion)(&hdev->error_reset)){+.+.}-{0:0}, at: process_one_work+0x7d0/0x10c0 kernel/workqueue.c:2285
 #2: ffff8880774f8ff0 (&hdev->req_lock){+.+.}-{3:3}, at: hci_dev_do_close+0x5e/0x1000 net/bluetooth/hci_core.c:1737
 #3: ffff8880774f8078 (&hdev->lock){+.+.}-{3:3}, at: hci_dev_do_close+0x42c/0x1000 net/bluetooth/hci_core.c:1782
 #4: ffffffff8db2bdc8 (hci_cb_list_lock){+.+.}-{3:3}, at: hci_disconn_cfm include/net/bluetooth/hci_core.h:1518 [inline]
 #4: ffffffff8db2bdc8 (hci_cb_list_lock){+.+.}-{3:3}, at: hci_conn_hash_flush+0xb8/0x210 net/bluetooth/hci_conn.c:1610

stack backtrace:
CPU: 1 PID: 3535 Comm: kworker/u5:3 Not tainted 5.15.127-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Workqueue: hci5 hci_error_reset
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
 __flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
 __cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
 sco_conn_del+0x205/0x300 net/bluetooth/sco.c:204
 hci_disconn_cfm include/net/bluetooth/hci_core.h:1521 [inline]
 hci_conn_hash_flush+0x10d/0x210 net/bluetooth/hci_conn.c:1610
 hci_dev_do_close+0x9f6/0x1000 net/bluetooth/hci_core.c:1795
 hci_error_reset+0xcd/0x160 net/bluetooth/hci_core.c:2340
 process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
 worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
 kthread+0x3f6/0x4f0 kernel/kthread.c:319
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
 </TASK>

Crashes (9):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/08/19 03:54 linux-5.15.y f6f7927ac664 d216d8a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/08/11 17:48 linux-5.15.y 24c4de4069cb 39990d51 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/08/10 00:18 linux-5.15.y c275eaaaa342 13ca4cd6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/08/09 00:25 linux-5.15.y c275eaaaa342 9552ae77 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/08/08 16:15 linux-5.15.y 38d4ca22a528 9552ae77 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/08/03 10:03 linux-5.15.y 38d4ca22a528 39a91c18 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/07/24 23:20 linux-5.15.y 5c6a716301d9 b03242d7 .config console log report info ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/07/20 19:10 linux-5.15.y d54cfc420586 f49af159 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
2023/06/03 08:21 linux-5.15.y 0ab06468cbd1 a4ae4f42 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in hci_conn_hash_flush
* Struck through repros no longer work on HEAD.