syzbot


possible deadlock in ntfs_file_write_iter

Status: upstream: reported C repro on 2024/08/03 11:07
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+01244cf1d56776f863c8@syzkaller.appspotmail.com
First crash: 141d, last: 2h44m
Bug presence (2)
Date Name Commit Repro Result
2024/11/13 linux-6.1.y (ToT) d7039b844a1c C [report] possible deadlock in ntfs_file_write_iter
2024/11/13 upstream (ToT) 9f8e716d46c6 C Didn't crash
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in ntfs_file_write_iter origin:lts-only C error 147 20d 125d 0/3 upstream: reported C repro on 2024/08/19 12:03
upstream possible deadlock in ntfs_file_write_iter ntfs3 C done 59 1d16h 190d 0/28 upstream: reported C repro on 2024/06/15 08:45

Sample crash report:
         option from the mount to silence this warning.
=======================================================
======================================================
WARNING: possible circular locking dependency detected
6.1.116-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor352/4289 is trying to acquire lock:
ffff0000d4fb2548 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x9c/0x124 mm/memory.c:5850

but task is already holding lock:
ffff0000e5007240 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:778 [inline]
ffff0000e5007240 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: ntfs_file_write_iter+0x190/0x580 fs/ntfs3/file.c:1144

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ntfs_file_mmap+0x4b0/0x688 fs/ntfs3/file.c:399
       call_mmap include/linux/fs.h:2270 [inline]
       mmap_region+0xdd0/0x1a98 mm/mmap.c:2763
       do_mmap+0xa00/0x1108 mm/mmap.c:1425
       vm_mmap_pgoff+0x1a4/0x2b4 mm/util.c:520
       ksys_mmap_pgoff+0x3c8/0x5b0 mm/mmap.c:1471
       __do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
       __se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
       __arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&mm->mmap_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       __might_fault+0xc4/0x124 mm/memory.c:5851
       fault_in_readable+0x188/0x5f0 mm/gup.c:1891
       fault_in_iov_iter_readable+0xcc/0x22c lib/iov_iter.c:356
       generic_perform_write+0x1c8/0x55c mm/filemap.c:3835
       __generic_file_write_iter+0x168/0x388 mm/filemap.c:3973
       ntfs_file_write_iter+0x4d4/0x580 fs/ntfs3/file.c:1165
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x610/0x91c fs/read_write.c:584
       ksys_write+0x15c/0x26c fs/read_write.c:637
       __do_sys_write fs/read_write.c:649 [inline]
       __se_sys_write fs/read_write.c:646 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:646
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&sb->s_type->i_mutex_key#17);
                               lock(&mm->mmap_lock);
                               lock(&sb->s_type->i_mutex_key#17);
  lock(&mm->mmap_lock);

 *** DEADLOCK ***

3 locks held by syz-executor352/4289:
 #0: ffff0000d82cdc68 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x124/0x16c fs/file.c:1031
 #1: ffff0000da4e2460 (sb_writers#8){.+.+}-{0:0}, at: vfs_write+0x244/0x91c fs/read_write.c:580
 #2: ffff0000e5007240 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:778 [inline]
 #2: ffff0000e5007240 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: ntfs_file_write_iter+0x190/0x580 fs/ntfs3/file.c:1144

stack backtrace:
CPU: 1 PID: 4289 Comm: syz-executor352 Not tainted 6.1.116-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 __might_fault+0xc4/0x124 mm/memory.c:5851
 fault_in_readable+0x188/0x5f0 mm/gup.c:1891
 fault_in_iov_iter_readable+0xcc/0x22c lib/iov_iter.c:356
 generic_perform_write+0x1c8/0x55c mm/filemap.c:3835
 __generic_file_write_iter+0x168/0x388 mm/filemap.c:3973
 ntfs_file_write_iter+0x4d4/0x580 fs/ntfs3/file.c:1165
 call_write_iter include/linux/fs.h:2265 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x610/0x91c fs/read_write.c:584
 ksys_write+0x15c/0x26c fs/read_write.c:637
 __do_sys_write fs/read_write.c:649 [inline]
 __se_sys_write fs/read_write.c:646 [inline]
 __arm64_sys_write+0x7c/0x90 fs/read_write.c:646
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Crashes (121):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/11/09 15:33 linux-6.1.y d7039b844a1c 6b856513 .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/20 08:09 linux-6.1.y 29f02ec58a94 0f61b415 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/20 01:02 linux-6.1.y 29f02ec58a94 5905cb39 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/17 09:45 linux-6.1.y 52f863f820fd f93b2b55 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/14 22:24 linux-6.1.y 52f863f820fd 7cbfbb3a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/14 02:33 linux-6.1.y e4d90d63d385 7cbfbb3a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/13 16:20 linux-6.1.y e4d90d63d385 3547e30f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/03 03:43 linux-6.1.y e4d90d63d385 578925bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/30 03:00 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/27 20:30 linux-6.1.y e4d90d63d385 5df23865 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/26 12:18 linux-6.1.y e4d90d63d385 e9a9a9f2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/25 22:04 linux-6.1.y e4d90d63d385 11dbc254 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/25 00:19 linux-6.1.y e4d90d63d385 68da6d95 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/19 18:11 linux-6.1.y b67dc5c9ade9 7d02db5a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/19 06:23 linux-6.1.y b67dc5c9ade9 571351cb .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/15 16:44 linux-6.1.y 59d7b1a7104a f6ede3a3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/11/07 09:06 linux-6.1.y 7c15117f9468 df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/10/31 18:19 linux-6.1.y 7ec6f9fa3d97 96eb609f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/10/11 23:33 linux-6.1.y aa4cd140bba5 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/10/11 16:04 linux-6.1.y aa4cd140bba5 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in ntfs_file_write_iter
2024/12/22 13:16 linux-6.1.y 29f02ec58a94 b4fbdbd4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/22 13:15 linux-6.1.y 29f02ec58a94 b4fbdbd4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/22 02:20 linux-6.1.y 29f02ec58a94 d7f584ee .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/15 08:10 linux-6.1.y 52f863f820fd 7cbfbb3a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/05 19:36 linux-6.1.y e4d90d63d385 29f61fce .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/05 11:43 linux-6.1.y e4d90d63d385 29f61fce .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/03 23:24 linux-6.1.y e4d90d63d385 b50eb251 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/03 03:45 linux-6.1.y e4d90d63d385 578925bc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/02 15:07 linux-6.1.y e4d90d63d385 b499ea68 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/02 13:56 linux-6.1.y e4d90d63d385 b499ea68 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/12/01 19:22 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/30 09:18 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/30 07:35 linux-6.1.y e4d90d63d385 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/30 00:02 linux-6.1.y e4d90d63d385 5df23865 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/23 00:56 linux-6.1.y e4d90d63d385 68da6d95 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/22 10:29 linux-6.1.y b67dc5c9ade9 4b25d554 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/22 04:55 linux-6.1.y b67dc5c9ade9 4b25d554 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/14 21:13 linux-6.1.y 59d7b1a7104a a8c99394 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/11/14 09:56 linux-6.1.y d7039b844a1c a8c99394 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/10/31 09:01 linux-6.1.y 7ec6f9fa3d97 96eb609f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/10/30 22:33 linux-6.1.y 7ec6f9fa3d97 fb888278 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/10/18 22:59 linux-6.1.y 54d90d17e8ce cd6fc0a3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/10/18 02:57 linux-6.1.y 54d90d17e8ce 666f77ed .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/10/18 02:45 linux-6.1.y 54d90d17e8ce 666f77ed .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
2024/08/03 11:07 linux-6.1.y 48d525b0e463 1786a2a8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ntfs_file_write_iter
* Struck through repros no longer work on HEAD.