syzbot


possible deadlock in chown_common

Status: auto-obsoleted due to no activity on 2024/08/08 12:40
Reported-by: syzbot+097db46a03bf76e49ae4@syzkaller.appspotmail.com
First crash: 443d, last: 205d
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 possible deadlock in chown_common C 1 638d 777d 0/1 upstream: reported C repro on 2022/10/05 17:28
linux-6.1 possible deadlock in chown_common (2) 1 233d 233d 0/3 auto-obsoleted due to no activity on 2024/07/11 11:15
linux-6.1 possible deadlock in chown_common 1 490d 490d 0/3 auto-obsoleted due to no activity on 2023/10/28 14:17
upstream possible deadlock in chown_common reiserfs C error done 22 304d 773d 25/28 fixed on 2024/01/30 15:47

Sample crash report:
REISERFS (device loop1): Using tea hash to sort names
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
5.15.157-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/10350 is trying to acquire lock:
ffff8880526b02e0 (&type->i_mutex_dir_key#25){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff8880526b02e0 (&type->i_mutex_dir_key#25){+.+.}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674

but task is already holding lock:
ffff88807bf4a460 (sb_writers#37){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (sb_writers#37){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_write+0x4f/0x1c0 include/linux/fs.h:1881
       mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
       reiserfs_ioctl+0x170/0x340 fs/reiserfs/ioctl.c:103
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&sbi->lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
       reiserfs_lookup+0x15c/0x4b0 fs/reiserfs/namei.c:364
       __lookup_slow+0x275/0x3d0 fs/namei.c:1663
       lookup_one_len+0x187/0x2d0 fs/namei.c:2718
       reiserfs_lookup_privroot+0x85/0x1e0 fs/reiserfs/xattr.c:980
       reiserfs_fill_super+0x2224/0x2690 fs/reiserfs/super.c:2178
       mount_bdev+0x2c9/0x3f0 fs/super.c:1387
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1517
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&type->i_mutex_dir_key#25){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:789 [inline]
       chown_common+0x499/0x890 fs/open.c:674
       do_fchownat+0x169/0x240 fs/open.c:711
       __do_sys_fchownat fs/open.c:726 [inline]
       __se_sys_fchownat fs/open.c:723 [inline]
       __x64_sys_fchownat+0xb1/0xc0 fs/open.c:723
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &type->i_mutex_dir_key#25 --> &sbi->lock --> sb_writers#37

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(sb_writers#37);
                               lock(&sbi->lock);
                               lock(sb_writers#37);
  lock(&type->i_mutex_dir_key#25);

 *** DEADLOCK ***

1 lock held by syz-executor.1/10350:
 #0: ffff88807bf4a460 (sb_writers#37){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377

stack backtrace:
CPU: 1 PID: 10350 Comm: syz-executor.1 Not tainted 5.15.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:789 [inline]
 chown_common+0x499/0x890 fs/open.c:674
 do_fchownat+0x169/0x240 fs/open.c:711
 __do_sys_fchownat fs/open.c:726 [inline]
 __se_sys_fchownat fs/open.c:723 [inline]
 __x64_sys_fchownat+0xb1/0xc0 fs/open.c:723
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f8763d47ea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f87622ba0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000104
RAX: ffffffffffffffda RBX: 00007f8763e75f80 RCX: 00007f8763d47ea9
RDX: 0000000000000000 RSI: 0000000020000000 RDI: ffffffffffffff9c
RBP: 00007f8763d944a4 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f8763e75f80 R15: 00007fff4bb789b8
 </TASK>

Crashes (6):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/04/30 12:40 linux-5.15.y b925f60c6ee7 3ce4924c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in chown_common
2024/04/23 02:17 linux-5.15.y c52b9710c83d 36c961ad .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in chown_common
2024/01/18 17:07 linux-5.15.y ddcaf4999061 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in chown_common
2023/10/24 20:25 linux-5.15.y 00c03985402e 17e6d526 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in chown_common
2023/10/20 17:53 linux-5.15.y 00c03985402e 361b23dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in chown_common
2023/09/04 16:29 linux-5.15.y 8f790700c974 db3306a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in chown_common
* Struck through repros no longer work on HEAD.