DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint

Status: fixed on 2025/02/07 11:57
Fix commit: da7cd03064d7 Lock around packet mmap fields.
First crash: 570d, last: 569d

Sample crash report:
WARNING: DATA RACE
Read at 0x00c0046b41d8 by goroutine 149086:
  gvisor.dev/gvisor/pkg/tcpip/transport/packet.(*endpoint).GetPacketMMapEndpoint()
      pkg/tcpip/transport/packet/endpoint.go:584 +0x44
  gvisor.dev/gvisor/pkg/sentry/socket/netstack.(*sock).ConfigureMMap()
      pkg/sentry/socket/netstack/netstack.go:3598 +0xbe
  gvisor.dev/gvisor/pkg/sentry/vfs.(*FileDescription).ConfigureMMap()
      pkg/sentry/vfs/file_description.go:710 +0x7c
  gvisor.dev/gvisor/pkg/sentry/syscalls/linux.Mmap()
      pkg/sentry/syscalls/linux/sys_mmap.go:110 +0xb9e
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).executeSyscall()
      pkg/sentry/kernel/task_syscall.go:143 +0xb9e
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscallInvoke()
      pkg/sentry/kernel/task_syscall.go:323 +0x84
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscallEnter()
      pkg/sentry/kernel/task_syscall.go:283 +0xc6
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscall()
      pkg/sentry/kernel/task_syscall.go:258 +0x549
  gvisor.dev/gvisor/pkg/sentry/kernel.(*runApp).execute()
      pkg/sentry/kernel/task_run.go:269 +0x2294
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).run()
      pkg/sentry/kernel/task_run.go:97 +0x41a
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).Start.gowrap1()
      pkg/sentry/kernel/task_start.go:412 +0x44

Previous write at 0x00c0046b41d8 by goroutine 149084:
  gvisor.dev/gvisor/pkg/tcpip/transport/packet.(*endpoint).SetPacketMMapEndpoint()
      pkg/tcpip/transport/packet/endpoint.go:578 +0x51
  gvisor.dev/gvisor/pkg/sentry/socket/netstack.setSockOptPacket()
      pkg/sentry/socket/netstack/netstack.go:2752 +0x772
  gvisor.dev/gvisor/pkg/sentry/socket/netstack.SetSockOpt()
      pkg/sentry/socket/netstack/netstack.go:1873 +0x365
  gvisor.dev/gvisor/pkg/sentry/socket/netstack.(*sock).SetSockOpt()
      pkg/sentry/socket/netstack/netstack.go:634 +0x6a9
  gvisor.dev/gvisor/pkg/sentry/syscalls/linux.SetSockOpt()
      pkg/sentry/syscalls/linux/sys_socket.go:551 +0x46b
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).executeSyscall()
      pkg/sentry/kernel/task_syscall.go:143 +0xb9e
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscallInvoke()
      pkg/sentry/kernel/task_syscall.go:323 +0x84
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscallEnter()
      pkg/sentry/kernel/task_syscall.go:283 +0xc6
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).doSyscall()
      pkg/sentry/kernel/task_syscall.go:258 +0x549
  gvisor.dev/gvisor/pkg/sentry/kernel.(*runApp).execute()
      pkg/sentry/kernel/task_run.go:269 +0x2294
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).run()
      pkg/sentry/kernel/task_run.go:97 +0x41a
  gvisor.dev/gvisor/pkg/sentry/kernel.(*Task).Start.gowrap1()
      pkg/sentry/kernel/task_start.go:412 +0x44

Crashes (14):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/02/07 09:48 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 06:31 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 03:24 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 02:56 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-systrap-1-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 02:51 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 02:09 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-ptrace-1-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 01:56 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-systrap-1-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/07 00:32 gvisor a4a0e84b5cd5 53657d1b .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/06 20:57 gvisor 902a56c6c584 1e1faf27 .config console log report info ci-gvisor-systrap-1-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/06 17:05 gvisor 902a56c6c584 1e1faf27 .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/06 16:20 gvisor 902a56c6c584 1e1faf27 .config console log report info ci-gvisor-ptrace-1-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/06 14:50 gvisor 902a56c6c584 1e1faf27 .config console log report info ci-gvisor-systrap-1-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/06 12:39 gvisor 902a56c6c584 1e1faf27 .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
2025/02/06 06:29 gvisor 902a56c6c584 577d049b .config console log report info ci-gvisor-ptrace-2-race-cover DATA RACE in packet.(*endpoint).GetPacketMMapEndpoint
* Struck through repros no longer work on HEAD.