syzbot


possible deadlock in ni_fiemap

Status: upstream: reported C repro on 2023/03/20 17:55
Bug presence: origin:upstream
Labels: missing-backport
[Documentation on labels]
Reported-by: syzbot+279c5747e43b1bc50fcb@syzkaller.appspotmail.com
First crash: 784d, last: 1h57m
Fix commit to backport (bisect log) :
tree: upstream
commit d92725256b4f22d084b813b37ddc394da79aacab
Author: Peter Xu <peterx@redhat.com>
Date: Mon May 30 18:34:50 2022 +0000

  mm: avoid unnecessary page fault retires on shared memory types

  
Bug presence (3)
Date Name Commit Repro Result
2023/10/16 linux-5.15.y (ToT) 02e21884dcf2 C [report] possible deadlock in ni_fiemap
2023/09/01 upstream (ToT) 99d99825fc07 C [report] VFS: Busy inodes after unmount (use-after-free)
2023/10/16 upstream (ToT) 58720809f527 C Didn't crash
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ni_fiemap ntfs3 C error done 4007 211d 938d 28/28 fixed on 2024/11/30 03:00
linux-6.1 possible deadlock in ni_fiemap origin:lts-only C unreliable 165 257d 776d 0/3 upstream: reported C repro on 2023/03/29 02:45
Fix bisection attempts (1)
Created Duration User Patch Repo Result
2023/11/14 03:51 5h35m fix candidate upstream OK (1) job log

Sample crash report:
loop0: detected capacity change from 0 to 4096
======================================================
WARNING: possible circular locking dependency detected
5.15.182-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor798/4188 is trying to acquire lock:
ffff88807c324e28 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x90/0x110 mm/memory.c:5356

but task is already holding lock:
ffff88806f4c7050 (&ni->file.run_lock#3){++++}-{3:3}, at: ni_fiemap+0x2de/0xc20 fs/ntfs3/frecord.c:1915

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ni->file.run_lock#3){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       attr_data_get_block+0x10d/0x1880 fs/ntfs3/attrib.c:831
       ntfs_file_mmap+0x457/0x720 fs/ntfs3/file.c:389
       call_mmap include/linux/fs.h:2177 [inline]
       mmap_file+0x5d/0xb0 mm/util.c:1092
       __mmap_region mm/mmap.c:1784 [inline]
       mmap_region+0xd0d/0x15e0 mm/mmap.c:2921
       do_mmap+0x77a/0xdf0 mm/mmap.c:1574
       vm_mmap_pgoff+0x1b2/0x2b0 mm/util.c:551
       ksys_mmap_pgoff+0x542/0x780 mm/mmap.c:1623
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&mm->mmap_lock){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       __might_fault+0xb3/0x110 mm/memory.c:5357
       _copy_to_user+0x29/0x130 lib/usercopy.c:35
       copy_to_user include/linux/uaccess.h:200 [inline]
       fiemap_fill_next_extent+0x19d/0x360 fs/ioctl.c:144
       ni_fiemap+0x92d/0xc20 fs/ntfs3/frecord.c:2019
       ntfs_fiemap+0xd7/0x130 fs/ntfs3/file.c:1233
       ioctl_fiemap fs/ioctl.c:219 [inline]
       do_vfs_ioctl+0x1464/0x1de0 fs/ioctl.c:814
       __do_sys_ioctl fs/ioctl.c:872 [inline]
       __se_sys_ioctl+0x83/0x170 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ni->file.run_lock#3);
                               lock(&mm->mmap_lock);
                               lock(&ni->file.run_lock#3);
  lock(&mm->mmap_lock);

 *** DEADLOCK ***

2 locks held by syz-executor798/4188:
 #0: ffff88806f4c6fa0 (&ni->ni_lock/5){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline]
 #0: ffff88806f4c6fa0 (&ni->ni_lock/5){+.+.}-{3:3}, at: ntfs_fiemap+0xc4/0x130 fs/ntfs3/file.c:1231
 #1: ffff88806f4c7050 (&ni->file.run_lock#3){++++}-{3:3}, at: ni_fiemap+0x2de/0xc20 fs/ntfs3/frecord.c:1915

stack backtrace:
CPU: 1 PID: 4188 Comm: syz-executor798 Not tainted 5.15.182-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/19/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 __might_fault+0xb3/0x110 mm/memory.c:5357
 _copy_to_user+0x29/0x130 lib/usercopy.c:35
 copy_to_user include/linux/uaccess.h:200 [inline]
 fiemap_fill_next_extent+0x19d/0x360 fs/ioctl.c:144
 ni_fiemap+0x92d/0xc20 fs/ntfs3/frecord.c:2019
 ntfs_fiemap+0xd7/0x130 fs/ntfs3/file.c:1233
 ioctl_fiemap fs/ioctl.c:219 [inline]
 do_vfs_ioctl+0x1464/0x1de0 fs/ioctl.c:814
 __do_sys_ioctl fs/ioctl.c:872 [inline]
 __se_sys_ioctl+0x83/0x170 fs/ioctl.c:860
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7ff09021ec99
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff0901db218 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ff0902c66c8 RCX: 00007ff09021ec99
RDX: 0000200000000180 RSI: 00000000c020660b RDI: 0000000000000005
RBP: 00007ff0902c66c0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff090292bf0
R13: 0000200000000180 R14: 00007ff090292a08 R15: 0000000000bcaefa
 </TASK>

Crashes (322):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/05/12 07:25 linux-5.15.y 3b8db0e4f263 77908e5f .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2023/08/16 08:45 linux-5.15.y 24c4de4069cb 39990d51 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2024/10/08 03:29 linux-5.15.y 3a5928702e71 d7906eff .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2023/06/25 09:01 linux-5.15.y f67653019430 79782afc .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2023/05/16 00:55 linux-5.15.y b0ece631f84a c4d362e7 .config console log report syz [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/05/01 17:42 linux-5.15.y f7347f400572 51b137cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/25 07:04 linux-5.15.y f7347f400572 e3715315 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/22 03:31 linux-5.15.y f7347f400572 2a20f901 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/17 15:08 linux-5.15.y f7347f400572 229db4cf .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/15 02:30 linux-5.15.y f7347f400572 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/11 14:05 linux-5.15.y f7347f400572 94486846 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/10 21:57 linux-5.15.y f7347f400572 1ef3ab4d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/08 09:17 linux-5.15.y 0c935c049b5c a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/05 08:00 linux-5.15.y 0c935c049b5c c53ea9c9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/04/01 16:24 linux-5.15.y 0c935c049b5c b8645499 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/29 09:56 linux-5.15.y 0c935c049b5c cf25e2c2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/27 19:36 linux-5.15.y 0c935c049b5c 6c09fb82 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/24 05:17 linux-5.15.y 0c935c049b5c 875573af .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/23 08:00 linux-5.15.y 0c935c049b5c 4e8d3850 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/22 18:49 linux-5.15.y 0c935c049b5c c6512ef7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/18 18:30 linux-5.15.y 0c935c049b5c 22a6c2b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/17 19:24 linux-5.15.y 0c935c049b5c 948c34e4 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/13 17:44 linux-5.15.y 0c935c049b5c 44be8b44 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/03/13 11:17 linux-5.15.y c16c81c81336 44be8b44 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/02/18 00:05 linux-5.15.y c16c81c81336 429ea007 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/02/15 09:33 linux-5.15.y c16c81c81336 40a34ec9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/02/14 17:08 linux-5.15.y c16c81c81336 1022af74 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
2025/05/13 05:22 linux-5.15.y 3b8db0e4f263 f6671af7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/05/09 11:19 linux-5.15.y 3b8db0e4f263 bb813bcc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/05/07 20:27 linux-5.15.y 16fdf2c7111b dbf35fa1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/05/04 13:53 linux-5.15.y 16fdf2c7111b b0714e37 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/04/20 18:18 linux-5.15.y f7347f400572 2a20f901 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/04/16 04:12 linux-5.15.y f7347f400572 a95239b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/04/14 19:05 linux-5.15.y f7347f400572 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/04/13 19:49 linux-5.15.y f7347f400572 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/04/12 11:09 linux-5.15.y f7347f400572 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/04/10 01:33 linux-5.15.y 0c935c049b5c 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/30 13:11 linux-5.15.y 0c935c049b5c d3999433 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/26 21:10 linux-5.15.y 0c935c049b5c 20510e88 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/21 14:23 linux-5.15.y 0c935c049b5c 62330552 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/16 03:39 linux-5.15.y 0c935c049b5c e2826670 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/09 06:14 linux-5.15.y c16c81c81336 163f510d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/07 18:32 linux-5.15.y c16c81c81336 7e3bd60d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/03/04 23:13 linux-5.15.y c16c81c81336 c3901742 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/02/19 17:34 linux-5.15.y c16c81c81336 b257a9b7 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/02/18 02:07 linux-5.15.y c16c81c81336 429ea007 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/02/17 04:04 linux-5.15.y c16c81c81336 40a34ec9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2025/02/11 05:59 linux-5.15.y c16c81c81336 43f51a00 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in ni_fiemap
2023/03/20 17:54 linux-5.15.y 8020ae3c051d 7939252e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in ni_fiemap
* Struck through repros no longer work on HEAD.