input: Steam Controller as /devices/platform/dummy_hcd.0/usb1/1-1/1-1:0.0/0003:28DE:1102.0004/input/input10
======================================================
WARNING: possible circular locking dependency detected
5.15.179-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.453/5885 is trying to acquire lock:
ffffffff8d750188 (input_mutex){+.+.}-{3:3}
, at: input_register_device+0xb81/0x1150 drivers/input/input.c:2422

but task is already holding lock:
ffff888021f79ee0 (&hdev->ll_open_lock){+.+.}-{3:3}, at: hid_hw_close+0x2c/0xd0 drivers/hid/hid-core.c:2144

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&hdev->ll_open_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_killable_nested+0x17/0x20 kernel/locking/mutex.c:758
       hid_hw_open+0x24/0x160 drivers/hid/hid-core.c:2118
       input_open_device+0x188/0x2d0 drivers/input/input.c:640
       mousedev_open_device+0xc3/0x160 drivers/input/mousedev.c:430
       mousedev_open+0x2c9/0x470 drivers/input/mousedev.c:556
       chrdev_open+0x54a/0x630 fs/char_dev.c:414
       do_dentry_open+0x807/0xfb0 fs/open.c:826
       do_open fs/namei.c:3608 [inline]
       path_openat+0x2705/0x2f20 fs/namei.c:3742
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_openat fs/open.c:1285 [inline]
       __se_sys_openat fs/open.c:1280 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1280
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&dev->mutex#2){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_interruptible_nested+0x17/0x20 kernel/locking/mutex.c:765
       input_register_handle+0x69/0x3a0 drivers/input/input.c:2588
       kbd_connect+0xbb/0x120 drivers/tty/vt/keyboard.c:1577
       input_attach_handler drivers/input/input.c:1046 [inline]
       input_register_device+0xdae/0x1150 drivers/input/input.c:2429
       acpi_button_add+0x62d/0x9f0 drivers/acpi/button.c:579
       acpi_device_probe+0xa3/0x2f0 drivers/acpi/bus.c:1013
       really_probe+0x24e/0xb60 drivers/base/dd.c:595
       __driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:755
       driver_probe_device+0x50/0x420 drivers/base/dd.c:785
       __driver_attach+0x479/0x690 drivers/base/dd.c:1164
       bus_for_each_dev+0x17c/0x1f0 drivers/base/bus.c:303
       bus_add_driver+0x334/0x600 drivers/base/bus.c:620
       driver_register+0x2bf/0x3a0 drivers/base/driver.c:240
       do_one_initcall+0x22b/0x7a0 init/main.c:1302
       do_initcall_level+0x157/0x210 init/main.c:1375
       do_initcalls+0x49/0x90 init/main.c:1391
       kernel_init_freeable+0x425/0x5c0 init/main.c:1615
       kernel_init+0x19/0x290 init/main.c:1506
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287

-> #0 (input_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_interruptible_nested+0x17/0x20 kernel/locking/mutex.c:765
       input_register_device+0xb81/0x1150 drivers/input/input.c:2422
       steam_input_register+0x947/0xbd0 drivers/hid/hid-steam.c:469
       hid_hw_close+0xa4/0xd0 drivers/hid/hid-core.c:2146
       drop_ref drivers/hid/hidraw.c:338 [inline]
       hidraw_release+0x3bd/0x600 drivers/hid/hidraw.c:360
       __fput+0x3fe/0x8e0 fs/file_table.c:311
       task_work_run+0x129/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  input_mutex --> &dev->mutex#2 --> &hdev->ll_open_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&hdev->ll_open_lock);
                               lock(&dev->mutex#2);
                               lock(&hdev->ll_open_lock);
  lock(input_mutex);

 *** DEADLOCK ***

2 locks held by syz.0.453/5885:
 #0: ffffffff8dac41a8 (minors_lock){+.+.}-{3:3}, at: hidraw_release+0x74/0x600 drivers/hid/hidraw.c:351
 #1: ffff888021f79ee0 (&hdev->ll_open_lock){+.+.}-{3:3}, at: hid_hw_close+0x2c/0xd0 drivers/hid/hid-core.c:2144

stack backtrace:
CPU: 1 PID: 5885 Comm: syz.0.453 Not tainted 5.15.179-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_interruptible_nested+0x17/0x20 kernel/locking/mutex.c:765
 input_register_device+0xb81/0x1150 drivers/input/input.c:2422
 steam_input_register+0x947/0xbd0 drivers/hid/hid-steam.c:469
 hid_hw_close+0xa4/0xd0 drivers/hid/hid-core.c:2146
 drop_ref drivers/hid/hidraw.c:338 [inline]
 hidraw_release+0x3bd/0x600 drivers/hid/hidraw.c:360
 __fput+0x3fe/0x8e0 fs/file_table.c:311
 task_work_run+0x129/0x1a0 kernel/task_work.c:188
 tracehook_notify_resume include/linux/tracehook.h:189 [inline]
 exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
 __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
 syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fa3a8224169
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffa59f7438 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4
RAX: 0000000000000000 RBX: 00000000000284b5 RCX: 00007fa3a8224169
RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003
RBP: 00007fa3a843eba0 R08: 0000000000000001 R09: 00000013a59f772f
R10: 00007fa3a8097000 R11: 0000000000000246 R12: 00007fa3a843cfac
R13: 00007fa3a843cfa0 R14: ffffffffffffffff R15: 00007fffa59f7550
 </TASK>