syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.152-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor189/3500 is trying to acquire lock:
ffff888015db8120 (sk_lock-AF_INET6){+.+.}-{0:0}, at: inet_sk_diag_fill+0xf6a/0x1cb0 net/ipv4/inet_diag.c:342

but task is already holding lock:
ffffc90001742b78 (&h->lhash2[i].lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:363 [inline]
ffffc90001742b78 (&h->lhash2[i].lock){+.+.}-{2:2}, at: mptcp_diag_dump_listeners net/mptcp/mptcp_diag.c:95 [inline]
ffffc90001742b78 (&h->lhash2[i].lock){+.+.}-{2:2}, at: mptcp_diag_dump+0x869/0x1330 net/mptcp/mptcp_diag.c:194

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&h->lhash2[i].lock){+.+.}-{2:2}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
       _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:154
       spin_lock include/linux/spinlock.h:363 [inline]
       __inet_hash+0xe3/0x920 net/ipv4/inet_hashtables.c:606
       inet_csk_listen_start+0x231/0x310 net/ipv4/inet_connection_sock.c:1084
       inet_listen+0x2c9/0x7c0 net/ipv4/af_inet.c:231
       __sys_listen+0x1a7/0x220 net/socket.c:1749
       __do_sys_listen net/socket.c:1758 [inline]
       __se_sys_listen net/socket.c:1756 [inline]
       __x64_sys_listen+0x56/0x60 net/socket.c:1756
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (sk_lock-AF_INET6){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       lock_sock_fast include/net/sock.h:1700 [inline]
       mptcp_diag_get_info+0x276/0xa10 net/mptcp/mptcp_diag.c:224
       inet_sk_diag_fill+0xf6a/0x1cb0 net/ipv4/inet_diag.c:342
       sk_diag_dump net/mptcp/mptcp_diag.c:24 [inline]
       mptcp_diag_dump_listeners net/mptcp/mptcp_diag.c:122 [inline]
       mptcp_diag_dump+0xd1d/0x1330 net/mptcp/mptcp_diag.c:194
       __inet_diag_dump+0x20e/0x3a0 net/ipv4/inet_diag.c:1179
       inet_diag_dump_compat+0x1bd/0x2d0 net/ipv4/inet_diag.c:1287
       netlink_dump+0x606/0xc40 net/netlink/af_netlink.c:2279
       __netlink_dump_start+0x52f/0x6f0 net/netlink/af_netlink.c:2384
       netlink_dump_start include/linux/netlink.h:258 [inline]
       inet_diag_rcv_msg_compat+0x202/0x4c0 net/ipv4/inet_diag.c:1321
       sock_diag_rcv_msg+0xd5/0x400
       netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2505
       sock_diag_rcv+0x26/0x40 net/core/sock_diag.c:276
       netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
       netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
       netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1924
       sock_sendmsg_nosec net/socket.c:704 [inline]
       __sock_sendmsg net/socket.c:716 [inline]
       ____sys_sendmsg+0x59e/0x8f0 net/socket.c:2431
       ___sys_sendmsg+0x252/0x2e0 net/socket.c:2485
       __sys_sendmsg net/socket.c:2514 [inline]
       __do_sys_sendmsg net/socket.c:2523 [inline]
       __se_sys_sendmsg+0x19a/0x260 net/socket.c:2521
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&h->lhash2[i].lock);
                               lock(sk_lock-AF_INET6);
                               lock(&h->lhash2[i].lock);
  lock(sk_lock-AF_INET6);

 *** DEADLOCK ***

6 locks held by syz-executor189/3500:
 #0: ffffffff8d9e56c8 (sock_diag_mutex){+.+.}-{3:3}, at: sock_diag_rcv+0x17/0x40 net/core/sock_diag.c:275
 #1: ffffffff8d9e5528 (sock_diag_table_mutex){+.+.}-{3:3}, at: sock_diag_rcv_msg+0xb8/0x400 net/core/sock_diag.c:255
 #2: ffff88814aedb690 (nlk_cb_mutex-SOCK_DIAG){+.+.}-{3:3}, at: netlink_dump+0xd0/0xc40 net/netlink/af_netlink.c:2227
 #3: ffffffff8dac1b08 (inet_diag_table_mutex){+.+.}-{3:3}, at: inet_diag_lock_handler net/ipv4/inet_diag.c:63 [inline]
 #3: ffffffff8dac1b08 (inet_diag_table_mutex){+.+.}-{3:3}, at: __inet_diag_dump+0x191/0x3a0 net/ipv4/inet_diag.c:1177
 #4: ffffffff8c91f720 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:268
 #5: ffffc90001742b78 (&h->lhash2[i].lock){+.+.}-{2:2}, at: spin_lock include/linux/spinlock.h:363 [inline]
 #5: ffffc90001742b78 (&h->lhash2[i].lock){+.+.}-{2:2}, at: mptcp_diag_dump_listeners net/mptcp/mptcp_diag.c:95 [inline]
 #5: ffffc90001742b78 (&h->lhash2[i].lock){+.+.}-{2:2}, at: mptcp_diag_dump+0x869/0x1330 net/mptcp/mptcp_diag.c:194

stack backtrace:
CPU: 0 PID: 3500 Comm: syz-executor189 Not tainted 5.15.152-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 lock_sock_fast include/net/sock.h:1700 [inline]
 mptcp_diag_get_info+0x276/0xa10 net/mptcp/mptcp_diag.c:224
 inet_sk_diag_fill+0xf6a/0x1cb0 net/ipv4/inet_diag.c:342
 sk_diag_dump net/mptcp/mptcp_diag.c:24 [inline]
 mptcp_diag_dump_listeners net/mptcp/mptcp_diag.c:122 [inline]
 mptcp_diag_dump+0xd1d/0x1330 net/mptcp/mptcp_diag.c:194
 __inet_diag_dump+0x20e/0x3a0 net/ipv4/inet_diag.c:1179
 inet_diag_dump_compat+0x1bd/0x2d0 net/ipv4/inet_diag.c:1287
 netlink_dump+0x606/0xc40 net/netlink/af_netlink.c:2279
 __netlink_dump_start+0x52f/0x6f0 net/netlink/af_netlink.c:2384
 netlink_dump_start include/linux/netlink.h:258 [inline]
 inet_diag_rcv_msg_compat+0x202/0x4c0 net/ipv4/inet_diag.c:1321
 sock_diag_rcv_msg+0xd5/0x400
 netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2505
 sock_diag_rcv+0x26/0x40 net/core/sock_diag.c:276
 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
 netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
 netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1924
 sock_sendmsg_nosec net/socket.c:704 [inline]
 __sock_sendmsg net/socket.c:716 [inline]
 ____sys_sendmsg+0x59e/0x8f0 net/socket.c:2431
 ___sys_sendmsg+0x252/0x2e0 net/socket.c:2485
 __sys_sendmsg net/socket.c:2514 [inline]
 __do_sys_sendmsg net/socket.c:2523 [inline]
 __se_sys_sendmsg+0x19a/0x260 net/socket.c:2521
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f18e11ce3a9
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc8c379f28 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007ffc8c37a0f8 RCX: 00007f18e11ce3a9
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000004
RBP: 00007f18e1241610 R08: 00007ffc8c37a0f8 R09: 00007ffc8c37a0f8
R10: 00007ffc8c37a0f8 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffc8c37a0e8 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
BUG: sleeping function called from invalid context at net/core/sock.c:3271
in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 3500, name: syz-executor189
INFO: lockdep is turned off.
Preemption disabled at:
[<0000000000000000>] 0x0
CPU: 0 PID: 3500 Comm: syz-executor189 Not tainted 5.15.152-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 ___might_sleep+0x547/0x6a0 kernel/sched/core.c:9626
 __lock_sock_fast+0x2f/0xe0 net/core/sock.c:3271
 lock_sock_fast include/net/sock.h:1702 [inline]
 mptcp_diag_get_info+0x282/0xa10 net/mptcp/mptcp_diag.c:224
 inet_sk_diag_fill+0xf6a/0x1cb0 net/ipv4/inet_diag.c:342
 sk_diag_dump net/mptcp/mptcp_diag.c:24 [inline]
 mptcp_diag_dump_listeners net/mptcp/mptcp_diag.c:122 [inline]
 mptcp_diag_dump+0xd1d/0x1330 net/mptcp/mptcp_diag.c:194
 __inet_diag_dump+0x20e/0x3a0 net/ipv4/inet_diag.c:1179
 inet_diag_dump_compat+0x1bd/0x2d0 net/ipv4/inet_diag.c:1287
 netlink_dump+0x606/0xc40 net/netlink/af_netlink.c:2279
 __netlink_dump_start+0x52f/0x6f0 net/netlink/af_netlink.c:2384
 netlink_dump_start include/linux/netlink.h:258 [inline]
 inet_diag_rcv_msg_compat+0x202/0x4c0 net/ipv4/inet_diag.c:1321
 sock_diag_rcv_msg+0xd5/0x400
 netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2505
 sock_diag_rcv+0x26/0x40 net/core/sock_diag.c:276
 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
 netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
 netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1924
 sock_sendmsg_nosec net/socket.c:704 [inline]
 __sock_sendmsg net/socket.c:716 [inline]
 ____sys_sendmsg+0x59e/0x8f0 net/socket.c:2431
 ___sys_sendmsg+0x252/0x2e0 net/socket.c:2485
 __sys_sendmsg net/socket.c:2514 [inline]
 __do_sys_sendmsg net/socket.c:2523 [inline]
 __se_sys_sendmsg+0x19a/0x260 net/socket.c:2521
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f18e11ce3a9
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc8c379f28 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007ffc8c37a0f8 RCX: 00007f18e11ce3a9
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000004
RBP: 00007f18e1241610 R08: 00007ffc8c37a0f8 R09: 00007ffc8c37a0f8
R10: 00007ffc8c37a0f8 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffc8c37a0e8 R14: 0000000000000001 R15: 0000000000000001