syzbot

loop0: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.6.98-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.2121/14448 is trying to acquire lock:
ffff88805e2042d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805e2042d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:640 [inline]
ffff88805e2042d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: __ocfs2_move_extents_range+0x1a65/0x3360 fs/ocfs2/move_extents.c:860

but task is already holding lock:
ffff88805e0909d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
ffff88805e0909d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:632 [inline]
ffff88805e0909d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: __ocfs2_move_extents_range+0x1371/0x3360 fs/ocfs2/move_extents.c:860

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
       ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline]
       ocfs2_reserve_clusters_with_limit+0x2fc/0xba0 fs/ocfs2/suballoc.c:1173
       ocfs2_defrag_extent fs/ocfs2/move_extents.c:266 [inline]
       __ocfs2_move_extents_range+0x160f/0x3360 fs/ocfs2/move_extents.c:857
       ocfs2_move_extents+0x379/0x940 fs/ocfs2/move_extents.c:927
       ocfs2_ioctl_move_extents+0x4e1/0x6c0 fs/ocfs2/move_extents.c:1053
       ocfs2_ioctl+0x195/0x750 fs/ocfs2/ioctl.c:945
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:871 [inline]
       __se_sys_ioctl+0xfd/0x170 fs/ioctl.c:857
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
       lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
       down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:804 [inline]
       ocfs2_move_extent fs/ocfs2/move_extents.c:640 [inline]
       __ocfs2_move_extents_range+0x1a65/0x3360 fs/ocfs2/move_extents.c:860
       ocfs2_move_extents+0x379/0x940 fs/ocfs2/move_extents.c:927
       ocfs2_ioctl_move_extents+0x4e1/0x6c0 fs/ocfs2/move_extents.c:1053
       ocfs2_ioctl+0x195/0x750 fs/ocfs2/ioctl.c:945
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:871 [inline]
       __se_sys_ioctl+0xfd/0x170 fs/ioctl.c:857
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6);

 *** DEADLOCK ***

5 locks held by syz.0.2121/14448:
 #0: ffff888024012418 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write_file+0x63/0x200 fs/namespace.c:447
 #1: ffff88805e205118 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #1: ffff88805e205118 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: ocfs2_move_extents+0x1a3/0x940 fs/ocfs2/move_extents.c:905
 #2: ffff88805e204da0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_move_extents+0x36c/0x940 fs/ocfs2/move_extents.c:925
 #3: ffff88805e095118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #3: ffff88805e095118 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x165/0x4360 fs/ocfs2/suballoc.c:782
 #4: ffff88805e0909d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline]
 #4: ffff88805e0909d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:632 [inline]
 #4: ffff88805e0909d8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: __ocfs2_move_extents_range+0x1371/0x3360 fs/ocfs2/move_extents.c:860

stack backtrace:
CPU: 1 PID: 14448 Comm: syz.0.2121 Not tainted 6.6.98-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x16c/0x230 lib/dump_stack.c:106
 check_noncircular+0x2bd/0x3c0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x2ddb/0x7c80 kernel/locking/lockdep.c:5137
 lock_acquire+0x197/0x410 kernel/locking/lockdep.c:5754
 down_write+0x97/0x1f0 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:804 [inline]
 ocfs2_move_extent fs/ocfs2/move_extents.c:640 [inline]
 __ocfs2_move_extents_range+0x1a65/0x3360 fs/ocfs2/move_extents.c:860
 ocfs2_move_extents+0x379/0x940 fs/ocfs2/move_extents.c:927
 ocfs2_ioctl_move_extents+0x4e1/0x6c0 fs/ocfs2/move_extents.c:1053
 ocfs2_ioctl+0x195/0x750 fs/ocfs2/ioctl.c:945
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:871 [inline]
 __se_sys_ioctl+0xfd/0x170 fs/ioctl.c:857
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x55/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f71a938e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f71aa1c8038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f71a95b5fa0 RCX: 00007f71a938e929
RDX: 00002000000000c0 RSI: 0000000040406f06 RDI: 0000000000000004
RBP: 00007f71a9410ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f71a95b5fa0 R15: 00007ffc2b157e38
 </TASK>