syzbot

======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.4.21/4421 is trying to acquire lock:
ffff8880703a3488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff8880703a3488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:646 [inline]
ffff8880703a3488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}, at: __ocfs2_move_extents_range+0x1a31/0x3450 fs/ocfs2/move_extents.c:866

but task is already holding lock:
ffff88807038d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff88807038d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:638 [inline]
ffff88807038d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: __ocfs2_move_extents_range+0x131f/0x3450 fs/ocfs2/move_extents.c:866

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       __ocfs2_flush_truncate_log+0x351/0x1110 fs/ocfs2/alloc.c:6044
       ocfs2_flush_truncate_log fs/ocfs2/alloc.c:6074 [inline]
       ocfs2_try_to_free_truncate_log+0x1a7/0x370 fs/ocfs2/alloc.c:6133
       ocfs2_reserve_clusters_with_limit+0x48a/0xc10 fs/ocfs2/suballoc.c:1202
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1245 [inline]
       ocfs2_lock_allocators+0x2ce/0x5f0 fs/ocfs2/suballoc.c:2701
       ocfs2_write_begin_nolock+0x1b97/0x44b0 fs/ocfs2/aops.c:1743
       ocfs2_dio_wr_get_block+0xba4/0x1810 fs/ocfs2/aops.c:2241
       get_more_blocks fs/direct-io.c:673 [inline]
       do_direct_IO fs/direct-io.c:959 [inline]
       do_blockdev_direct_IO fs/direct-io.c:1276 [inline]
       __blockdev_direct_IO+0x142d/0x3b20 fs/direct-io.c:1368
       ocfs2_direct_IO+0x233/0x2a0 fs/ocfs2/aops.c:2483
       generic_file_direct_write+0x222/0x470 mm/filemap.c:3687
       __generic_file_write_iter+0x2b2/0x4e0 mm/filemap.c:3869
       ocfs2_file_write_iter+0x171a/0x1ee0 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x47d/0x5f0 fs/read_write.c:-1
       do_iter_write+0x1f8/0x7a0 fs/read_write.c:855
       iter_file_splice_write+0x6be/0xcf0 fs/splice.c:689
       do_splice_from fs/splice.c:767 [inline]
       direct_splice_actor+0xe1/0x130 fs/splice.c:956
       splice_direct_to_actor+0x4e8/0xc00 fs/splice.c:902
       do_splice_direct+0x1d4/0x2f0 fs/splice.c:1008
       do_sendfile+0x524/0xe30 fs/read_write.c:1249
       __do_sys_sendfile64 fs/read_write.c:1317 [inline]
       __se_sys_sendfile64+0x141/0x1a0 fs/read_write.c:1303
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
       lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_move_extent fs/ocfs2/move_extents.c:646 [inline]
       __ocfs2_move_extents_range+0x1a31/0x3450 fs/ocfs2/move_extents.c:866
       ocfs2_move_extents+0x409/0xa40 fs/ocfs2/move_extents.c:938
       ocfs2_ioctl_move_extents+0x4d7/0x6e0 fs/ocfs2/move_extents.c:1064
       ocfs2_ioctl+0x31f/0x7a0 fs/ocfs2/ioctl.c:947
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:874 [inline]
       __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:860
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8
);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#8);

 *** DEADLOCK ***

5 locks held by syz.4.21/4421:
 #0: ffff888025c1e460
 (sb_writers#15){.+.+}-{0:0}
, at: mnt_want_write_file+0x5c/0x200 fs/namespace.c:430
 #1: ffff88805f266d88
 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: ocfs2_move_extents+0x19d/0xa40 fs/ocfs2/move_extents.c:916
 #2: ffff88805f266a20 (&oi->ip_alloc_sem){++++}-{3:3}
, at: ocfs2_move_extents+0x3fc/0xa40 fs/ocfs2/move_extents.c:936
 #3: ffff88807038ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #3: ffff88807038ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x16d/0x44b0 fs/ocfs2/suballoc.c:804
 #4: ffff88807038d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #4: ffff88807038d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_move_extent fs/ocfs2/move_extents.c:638 [inline]
 #4: ffff88807038d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: __ocfs2_move_extents_range+0x131f/0x3450 fs/ocfs2/move_extents.c:866

stack backtrace:
CPU: 1 PID: 4421 Comm: syz.4.21 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/09/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0x188/0x250 lib/dump_stack.c:106
 check_noncircular+0x296/0x330 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c66/0x7b50 kernel/locking/lockdep.c:5012
 lock_acquire+0x19e/0x400 kernel/locking/lockdep.c:5623
 down_write+0x38/0x60 kernel/locking/rwsem.c:1551
 inode_lock include/linux/fs.h:787 [inline]
 ocfs2_move_extent fs/ocfs2/move_extents.c:646 [inline]
 __ocfs2_move_extents_range+0x1a31/0x3450 fs/ocfs2/move_extents.c:866
 ocfs2_move_extents+0x409/0xa40 fs/ocfs2/move_extents.c:938
 ocfs2_ioctl_move_extents+0x4d7/0x6e0 fs/ocfs2/move_extents.c:1064
 ocfs2_ioctl+0x31f/0x7a0 fs/ocfs2/ioctl.c:947
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:874 [inline]
 __se_sys_ioctl+0xfa/0x170 fs/ioctl.c:860
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f94c9725e59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f94c795d028 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f94c99ae090 RCX: 00007f94c9725e59
RDX: 00002000000000c0 RSI: 0000000040406f06 RDI: 0000000000000007
RBP: 00007f94c97bbe6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f94c99ae128 R14: 00007f94c99ae090 R15: 00007fff45251928
 </TASK>