syzbot

EXT4-fs error (device loop0): ext4_ext_check_inode:501: inode #16: comm syz-executor324: pblk 0 bad header/extent: invalid extent entries - magic f30a, entries 1, max 4(4), depth 19200(19200)
EXT4-fs error (device loop0): ext4_orphan_get:1402: comm syz-executor324: couldn't read orphan inode 16 (err -117)
ext4 filesystem being mounted at /root/syzkaller.JNz7ds/87/file1 supports timestamps until 2038 (0x7fffffff)
======================================================
WARNING: possible circular locking dependency detected
5.15.155-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor324/3692 is trying to acquire lock:
ffff888071fd3e48 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568

but task is already holding lock:
ffff8880744ca208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332
       dquot_acquire+0x188/0x680 fs/quota/dquot.c:463
       ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192
       dqget+0x74e/0xe30 fs/quota/dquot.c:986
       __dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1516
       ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474
       ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4974
       mount_bdev+0x2c9/0x3f0 fs/super.c:1387
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1517
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x1e0/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x932/0xe40 fs/quota/dquot.c:1941
       dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
       dquot_free_space include/linux/quotaops.h:381 [inline]
       dquot_free_block include/linux/quotaops.h:392 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6157 [inline]
       ext4_free_blocks+0x1f6e/0x2ea0 fs/ext4/mballoc.c:6287
       ext4_remove_blocks fs/ext4/extents.c:2519 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
       ext4_ext_remove_space+0x24da/0x4db0 fs/ext4/extents.c:2933
       ext4_ext_truncate+0x191/0x250 fs/ext4/extents.c:4448
       ext4_truncate+0x9fd/0x1130 fs/ext4/inode.c:4238
       ext4_evict_inode+0xba1/0x1100 fs/ext4/inode.c:289
       evict+0x2a4/0x620 fs/inode.c:587
       ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474
       ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4974
       mount_bdev+0x2c9/0x3f0 fs/super.c:1387
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1517
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
       do_mount fs/namespace.c:3348 [inline]
       __do_sys_mount fs/namespace.c:3556 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ei->i_data_sem/2){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568
       ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846
       ext4_bread+0x2a/0x170 fs/ext4/inode.c:899
       ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6566
       write_blk fs/quota/quota_tree.c:64 [inline]
       get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125
       do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335
       do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
       dq_insert_tree fs/quota/quota_tree.c:392 [inline]
       qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411
       v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358
       dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472
       ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192
       dqget+0x74e/0xe30 fs/quota/dquot.c:986
       dquot_transfer+0x1d1/0x4e0 fs/quota/dquot.c:2145
       ext4_setattr+0x91a/0x1990 fs/ext4/inode.c:5405
       notify_change+0xc6d/0xf50 fs/attr.c:505
       chown_common+0x592/0x890 fs/open.c:680
       vfs_fchown fs/open.c:748 [inline]
       ksys_fchown+0xde/0x150 fs/open.c:759
       __do_sys_fchown fs/open.c:767 [inline]
       __se_sys_fchown fs/open.c:765 [inline]
       __x64_sys_fchown+0x76/0x80 fs/open.c:765
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&s->s_dquot.dqio_sem);
                               lock(&dquot->dq_lock);
                               lock(&s->s_dquot.dqio_sem);
  lock(&ei->i_data_sem/2);

 *** DEADLOCK ***

5 locks held by syz-executor324/3692:
 #0: ffff8880744ca460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
 #1: ffff888071fd5da8 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #1: ffff888071fd5da8 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674
 #2: ffff888071fd5a80 (&ei->xattr_sem){.+.+}-{3:3}, at: ext4_setattr+0x90d/0x1990 fs/ext4/inode.c:5404
 #3: ffff888071e653e8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460
 #4: ffff8880744ca208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:354

stack backtrace:
CPU: 0 PID: 3692 Comm: syz-executor324 Not tainted 5.15.155-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
 ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568
 ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846
 ext4_bread+0x2a/0x170 fs/ext4/inode.c:899
 ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6566
 write_blk fs/quota/quota_tree.c:64 [inline]
 get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125
 do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335
 do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
 dq_insert_tree fs/quota/quota_tree.c:392 [inline]
 qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411
 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358
 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472
 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6192
 dqget+0x74e/0xe30 fs/quota/dquot.c:986
 dquot_transfer+0x1d1/0x4e0 fs/quota/dquot.c:2145
 ext4_setattr+0x91a/0x1990 fs/ext4/inode.c:5405
 notify_change+0xc6d/0xf50 fs/attr.c:505
 chown_common+0x592/0x890 fs/open.c:680
 vfs_fchown fs/open.c:748 [inline]
 ksys_fchown+0xde/0x150 fs/open.c:759
 __do_sys_fchown fs/open.c:767 [inline]
 __se_sys_fchown fs/open.c:765 [inline]
 __x64_sys_fchown+0x76/0x80 fs/open.c:765
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f88844954a9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 21 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd4d1c82c8 EFLAGS: 00000246 ORIG_RAX: 000000000000005d
RAX: ffffffffffffffda RBX: 00007ffd4d1c8320 RCX: 00007f88844954a9
RDX: 0000000000000000 RSI: 0000000020737365 RDI: 0000000000000004
RBP: 0000000000000000 R08: 00007ffd4d1c8300 R09: 00007ffd4d1c8300
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffd4d1c8320
R13: 0000000000000057 R14: 431bde82d7b634db R15: 00007ffd4d1c82ec
 </TASK>