syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,3) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.126-syzkaller #0 Not tainted
------------------------------------------------------
syz.3.1719/11827 is trying to acquire lock:
ffff8880542e8660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314

but task is already holding lock:
ffff8880542e89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff8880542e89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:988
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #7 (&dquot->dq_lock){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       dquot_commit+0x57/0x510 fs/quota/dquot.c:507
       ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6770
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space include/linux/quotaops.h:384 [inline]
       dquot_free_block include/linux/quotaops.h:395 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline]
       ext4_free_blocks+0x1fb4/0x3020 fs/ext4/mballoc.c:6273
       ext4_remove_blocks fs/ext4/extents.c:2525 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
       ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2939
       ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4469
       ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288
       ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286
       evict+0x529/0x930 fs/inode.c:705
       d_delete_notify include/linux/fsnotify.h:267 [inline]
       vfs_rmdir+0x381/0x4b0 fs/namei.c:4204
       do_rmdir+0x3a2/0x590 fs/namei.c:4252
       __do_sys_unlinkat fs/namei.c:4432 [inline]
       __se_sys_unlinkat fs/namei.c:4426 [inline]
       __x64_sys_unlinkat+0xdc/0xf0 fs/namei.c:4426
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #6 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4283
       ext4_setattr+0x10f5/0x1a00 fs/ext4/inode.c:5601
       notify_change+0xce3/0xfc0 fs/attr.c:499
       do_truncate+0x21c/0x300 fs/open.c:65
       do_sys_ftruncate+0x2e2/0x380 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x4c6a/0x5720 fs/ocfs2/super.c:1139
       mount_bdev+0x2c9/0x3f0 fs/super.c:1443
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_modify_bh+0xe9/0x4c0 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x1587/0x19e0 fs/ocfs2/quota_local.c:768
       dquot_load_quota_sb+0x754/0xb90 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x318/0x600 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x165/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x4c6a/0x5720 fs/ocfs2/super.c:1139
       mount_bdev+0x2c9/0x3f0 fs/super.c:1443
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (sb_internal#3){.+.+}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1481 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1584 [inline]
       ocfs2_write_begin_nolock+0x2073/0x4e40 fs/ocfs2/aops.c:1670
       ocfs2_write_begin+0x201/0x390 fs/ocfs2/aops.c:1904
       generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3845
       __generic_file_write_iter+0x176/0x400 mm/filemap.c:3973
       ocfs2_file_write_iter+0x19d7/0x2280 fs/ocfs2/file.c:2469
       call_write_iter include/linux/fs.h:2265 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x857/0xbc0 fs/read_write.c:584
       ksys_write+0x19c/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x436/0x28c0 fs/ocfs2/dir.c:1080
       ocfs2_find_files_on_disk+0x10d/0x3a0 fs/ocfs2/dir.c:1982
       ocfs2_lookup_ino_from_name+0xad/0x1e0 fs/ocfs2/dir.c:2004
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x314/0x7b0 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x328/0x720 fs/ocfs2/super.c:457
       ocfs2_initialize_super fs/ocfs2/super.c:2250 [inline]
       ocfs2_fill_super+0x2f72/0x5720 fs/ocfs2/super.c:994
       mount_bdev+0x2c9/0x3f0 fs/super.c:1443
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&osb->system_file_mutex){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_suballoc_bits+0x167/0x5190 fs/ocfs2/suballoc.c:776
       ocfs2_reserve_new_metadata_blocks+0x418/0x9b0 fs/ocfs2/suballoc.c:978
       ocfs2_reserve_new_metadata fs/ocfs2/suballoc.c:1021 [inline]
       ocfs2_lock_allocators+0x2a5/0x620 fs/ocfs2/suballoc.c:2658
       ocfs2_extend_allocation+0x4e5/0x1d00 fs/ocfs2/file.c:585
       ocfs2_allocate_unwritten_extents+0x394/0x9e0 fs/ocfs2/file.c:1496
       __ocfs2_change_file_space+0x8ce/0xf60 fs/ocfs2/file.c:2023
       ocfs2_fallocate+0x2dc/0x350 fs/ocfs2/file.c:2138
       vfs_fallocate+0x547/0x6b0 fs/open.c:323
       ksys_fallocate fs/open.c:346 [inline]
       __do_sys_fallocate fs/open.c:354 [inline]
       __se_sys_fallocate fs/open.c:352 [inline]
       __x64_sys_fallocate+0xb9/0x100 fs/open.c:352
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
       dqget+0x762/0xe90 fs/quota/dquot.c:988
       __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310
       ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0x12f1/0x2e60 fs/namei.c:3780
       do_filp_open+0x230/0x480 fs/namei.c:3810
       do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1345
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &ocfs2_quota_ip_alloc_sem_key --> &dquot->dq_lock --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&dquot->dq_lock);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
  lock(&ocfs2_quota_ip_alloc_sem_key);

 *** DEADLOCK ***

5 locks held by syz.3.1719/11827:
 #0: ffff8880749ba460 (sb_writers#29){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
 #1: ffff8880542ed108 (&type->i_mutex_dir_key#18){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff8880542ed108 (&type->i_mutex_dir_key#18){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3547 [inline]
 #1: ffff8880542ed108 (&type->i_mutex_dir_key#18){+.+.}-{3:3}, at: path_openat+0x7b6/0x2e60 fs/namei.c:3780
 #2: ffff8880704da648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff8880704da648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x182/0x5190 fs/ocfs2/suballoc.c:782
 #3: ffff88804d8400a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x2a0/0xb60 fs/ocfs2/quota_global.c:806
 #4: ffff8880542e89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff8880542e89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313

stack backtrace:
CPU: 0 PID: 11827 Comm: syz.3.1719 Not tainted 6.1.126-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 down_write+0x36/0x60 kernel/locking/rwsem.c:1573
 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811
 dqget+0x762/0xe90 fs/quota/dquot.c:988
 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517
 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202
 ocfs2_mknod+0xe32/0x2e20 fs/ocfs2/namei.c:310
 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:674
 lookup_open fs/namei.c:3482 [inline]
 open_last_lookups fs/namei.c:3550 [inline]
 path_openat+0x12f1/0x2e60 fs/namei.c:3780
 do_filp_open+0x230/0x480 fs/namei.c:3810
 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
 do_sys_open fs/open.c:1334 [inline]
 __do_sys_openat fs/open.c:1350 [inline]
 __se_sys_openat fs/open.c:1345 [inline]
 __x64_sys_openat+0x243/0x290 fs/open.c:1345
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f03bc385d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f03bd137038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f03bc575fa0 RCX: 00007f03bc385d29
RDX: 0000000000105042 RSI: 0000000020000080 RDI: ffffffffffffff9c
RBP: 00007f03bc401b08 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000000001df R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f03bc575fa0 R15: 00007ffc6ab064d8
 </TASK>