WARNING in tcp_send_loss

WARNING in tcp_send_loss_probe
Status: fixed on 2019/12/09 13:28
Reported-by: syzbot+41d858b879cd4d0585ce@syzkaller.appspotmail.com
Fix commit: ba2ddb43 tcp: Don't dequeue SYN/FIN-segments from write-queue
First crash: 264d, last: 254d

Fix bisection: fixed by (bisect log):

commit ba2ddb43f270e6492ccce4fc42fc32c611de8f68
Author: Christoph Paasch <cpaasch@apple.com>
Date: Fri Sep 13 20:08:19 2019 +0000

tcp: Don't dequeue SYN/FIN-segments from write-queue

similar bugs (2):
Kernel	Title	Repro	Bisected	Count	Last	Reported	Patched	Status
android-414	WARNING in tcp_send_loss_probe	C		30	253d	264d	0/1	public: reported C repro on 2019/09/10 13:28
upstream	WARNING in tcp_send_loss_probe	C		9	462d	514d	12/17	fixed on 2019/03/06 07:43

Sample crash report:

invalid inflight: 1 state 4 cwnd 10 mss 1448
------------[ cut here ]------------
WARNING: CPU: 1 PID: 9694 at net/ipv4/tcp_output.c:2507 tcp_send_loss_probe.cold+0x83/0xa2 net/ipv4/tcp_output.c:2507
Kernel panic - not syncing: panic_on_warn set ...

CPU: 1 PID: 9694 Comm: syz-executor019 Not tainted 4.14.143 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <IRQ>
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x138/0x197 lib/dump_stack.c:53
 panic+0x1f2/0x426 kernel/panic.c:182
 __warn.cold+0x2f/0x36 kernel/panic.c:546
 report_bug+0x216/0x254 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:177 [inline]
 fixup_bug arch/x86/kernel/traps.c:172 [inline]
 do_error_trap+0x1bb/0x310 arch/x86/kernel/traps.c:295
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:314
 invalid_op+0x1b/0x40 arch/x86/entry/entry_64.S:963
RIP: 0010:tcp_send_loss_probe.cold+0x83/0xa2 net/ipv4/tcp_output.c:2507
RSP: 0000:ffff8880aef07cb8 EFLAGS: 00010282
RAX: 000000000000002c RBX: 0000000000000000 RCX: 0000000000000000
RDX: 0000000000000100 RSI: ffffffff866d10e0 RDI: ffffed1015de0f8d
RBP: ffff8880aef07ce8 R08: 000000000000002c R09: ffff88809a7b0930
R10: 0000000000000000 R11: 0000000000000000 R12: ffff888084c96a80
R13: 0000000000000001 R14: 00000000000005a8 R15: 000000000000000a
 tcp_write_timer_handler+0x4a8/0x7e0 net/ipv4/tcp_timer.c:575
 tcp_write_timer+0xd8/0x180 net/ipv4/tcp_timer.c:597
 call_timer_fn+0x161/0x670 kernel/time/timer.c:1279
 expire_timers kernel/time/timer.c:1318 [inline]
 __run_timers kernel/time/timer.c:1634 [inline]
 __run_timers kernel/time/timer.c:1602 [inline]
 run_timer_softirq+0x5b4/0x1570 kernel/time/timer.c:1647
 __do_softirq+0x244/0x9a0 kernel/softirq.c:288
 invoke_softirq kernel/softirq.c:368 [inline]
 irq_exit+0x160/0x1b0 kernel/softirq.c:409
 exiting_irq arch/x86/include/asm/apic.h:648 [inline]
 smp_apic_timer_interrupt+0x146/0x5e0 arch/x86/kernel/apic/apic.c:1102
 apic_timer_interrupt+0x96/0xa0 arch/x86/entry/entry_64.S:792
 </IRQ>
RIP: 0010:clear_page_erms+0x9/0x10 arch/x86/lib/clear_page_64.S:51
RSP: 0000:ffff888083e57a90 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff10
RAX: 0000000000000000 RBX: ffffea000246f080 RCX: 0000000000000000
RDX: 1ffff110134f623d RSI: 0000000000000001 RDI: ffff888091bc3000
RBP: ffff888083e57b80 R08: ffffea000246f080 R09: ffffed1012378400
R10: 0000000000000000 R11: 0000000000000000 R12: ffff88809a7b0040
R13: ffffea000246f0c0 R14: ffffed10134f626a R15: ffffea000246f080
 __alloc_pages_nodemask+0x33f/0x7a0 mm/page_alloc.c:4178
 alloc_pages_current+0xec/0x1e0 mm/mempolicy.c:2113
 alloc_pages include/linux/gfp.h:497 [inline]
 pte_alloc_one+0x1a/0x100 arch/x86/mm/pgtable.c:30
 do_fault_around mm/memory.c:3587 [inline]
 do_read_fault mm/memory.c:3628 [inline]
 do_fault mm/memory.c:3759 [inline]
 handle_pte_fault mm/memory.c:3989 [inline]
 __handle_mm_fault+0x2c19/0x3470 mm/memory.c:4113
 handle_mm_fault+0x293/0x7c0 mm/memory.c:4150
 __do_page_fault+0x4c1/0xb80 arch/x86/mm/fault.c:1420
 do_page_fault+0x71/0x511 arch/x86/mm/fault.c:1495
 page_fault+0x45/0x50 arch/x86/entry/entry_64.S:1122
RIP: 0033:0x4460fa
RSP: 002b:00007ffe70d697e0 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 00007ffe70d697e0 RCX: 00000000004460fa
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000001200011
RBP: 00007ffe70d69820 R08: 0000000000000001 R09: 00000000007c3880
R10: 00000000007c3b50 R11: 0000000000000246 R12: 0000000000000001
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (22):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	Maintainers
ci2-linux-4-14	2019/09/13 23:43	linux-4.14.y	e2cd24b6	32d59357	.config	log	report	syz	C	davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/10 13:28	linux-4.14.y	e2cd24b6	a60cb4cd	.config	log	report	syz		davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/20 08:39	linux-4.14.y	b10ab5e2	d96e88f3	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/19 20:41	linux-4.14.y	b10ab5e2	4d3ae0b7	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/19 08:32	linux-4.14.y	b10ab5e2	eb940044	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/18 16:50	linux-4.14.y	968722f5	46c0be24	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/18 13:50	linux-4.14.y	968722f5	1037b424	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/18 11:56	linux-4.14.y	968722f5	c2dcd700	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/18 00:22	linux-4.14.y	968722f5	03e0d245	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/17 23:56	linux-4.14.y	968722f5	03e0d245	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/17 23:38	linux-4.14.y	968722f5	03e0d245	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/17 11:15	linux-4.14.y	968722f5	13dcda9b	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/16 21:23	linux-4.14.y	968722f5	51ca0454	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/16 20:42	linux-4.14.y	968722f5	51ca0454	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/16 07:17	linux-4.14.y	968722f5	32d59357	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/16 03:20	linux-4.14.y	e2cd24b6	32d59357	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/15 04:40	linux-4.14.y	e2cd24b6	32d59357	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/13 22:12	linux-4.14.y	e2cd24b6	32d59357	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/13 16:07	linux-4.14.y	e2cd24b6	32d59357	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/13 15:21	linux-4.14.y	e2cd24b6	32d59357	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/11 19:54	linux-4.14.y	e2cd24b6	f4e53c10	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci2-linux-4-14	2019/09/10 12:22	linux-4.14.y	e2cd24b6	a60cb4cd	.config	log	report			davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org