syzbot

ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.5397/24284 is trying to acquire lock:
ffff8880757a6650 (sb_internal#6){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x66e/0xb10 fs/ocfs2/quota_global.c:848

but task is already holding lock:
ffff8880777abf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8be/0x2350 fs/ocfs2/namei.c:310
       vfs_mknod+0x424/0x4c0 fs/namei.c:3993
       do_mknodat+0x34e/0x4c0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4071 [inline]
       __se_sys_mknodat fs/namei.c:4068 [inline]
       __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4068
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x2a0/0xb10 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8be/0x2350 fs/ocfs2/namei.c:310
       vfs_mknod+0x424/0x4c0 fs/namei.c:3993
       do_mknodat+0x34e/0x4c0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4071 [inline]
       __se_sys_mknodat fs/namei.c:4068 [inline]
       __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4068
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6785
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0xf9/0x400 fs/quota/dquot.c:412
       __dquot_alloc_space+0x5fc/0xe60 fs/quota/dquot.c:1752
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xf74/0x4720 fs/ext4/mballoc.c:5722
       ext4_ext_map_blocks+0x18de/0x66d0 fs/ext4/extents.c:4340
       ext4_map_blocks+0x9d1/0x1b60 fs/ext4/inode.c:679
       ext4_getblk+0x1ab/0x6d0 fs/ext4/inode.c:890
       ext4_bread+0x26/0x170 fs/ext4/inode.c:946
       ext4_append+0x2c3/0x560 fs/ext4/namei.c:83
       ext4_init_new_dir+0x2b8/0x570 fs/ext4/namei.c:3030
       ext4_mkdir+0x47d/0xc50 fs/ext4/namei.c:3076
       vfs_mkdir+0x387/0x570 fs/namei.c:4114
       do_mkdirat+0x1d0/0x430 fs/namei.c:4139
       __do_sys_mkdir fs/namei.c:4159 [inline]
       __se_sys_mkdir fs/namei.c:4157 [inline]
       __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4157
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x36/0x60 kernel/locking/rwsem.c:1573
       ext4_truncate+0x987/0x1230 fs/ext4/inode.c:4290
       ext4_setattr+0x10cb/0x19f0 fs/ext4/inode.c:5645
       notify_change+0xc74/0xf40 fs/attr.c:499
       do_truncate+0x197/0x220 fs/open.c:65
       do_sys_ftruncate+0x312/0x3c0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1f49/0x2150 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x372/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_modify_bh+0xe5/0x460 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13b1/0x16e0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c3/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x409f/0x4d00 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x366/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_modify_bh+0xe5/0x460 fs/ocfs2/quota_local.c:101
       ocfs2_local_read_info+0x13b1/0x16e0 fs/ocfs2/quota_local.c:764
       dquot_load_quota_sb+0x756/0xac0 fs/quota/dquot.c:2470
       dquot_load_quota_inode+0x2d8/0x5d0 fs/quota/dquot.c:2507
       ocfs2_enable_quotas+0x1c3/0x440 fs/ocfs2/super.c:926
       ocfs2_fill_super+0x409f/0x4d00 fs/ocfs2/super.c:1139
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (sb_internal#6){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_acquire_dquot+0x66e/0xb10 fs/ocfs2/quota_global.c:848
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_mknod+0x8be/0x2350 fs/ocfs2/namei.c:310
       vfs_mknod+0x424/0x4c0 fs/namei.c:3993
       do_mknodat+0x34e/0x4c0 fs/namei.c:-1
       __do_sys_mknodat fs/namei.c:4071 [inline]
       __se_sys_mknodat fs/namei.c:4068 [inline]
       __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4068
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  sb_internal#6 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#6);

 *** DEADLOCK ***

6 locks held by syz.2.5397/24284:
 #0: ffff8880757a6460 (sb_writers#34){.+.+}-{0:0}, at: mnt_want_write+0x3d/0x90 fs/namespace.c:402
 #1: ffff8880752309c8 (&type->i_mutex_dir_key#26/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline]
 #1: ffff8880752309c8 (&type->i_mutex_dir_key#26/1){+.+.}-{3:3}, at: filename_create+0x1f2/0x450 fs/namei.c:3884
 #2: ffff8880752342c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff8880752342c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x162/0x4630 fs/ocfs2/suballoc.c:782
 #3: ffff8880753e60a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x293/0xb10 fs/ocfs2/quota_global.c:811
 #4: ffff8880777ac2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #4: ffff8880777ac2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
 #5: ffff8880777abf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 1 PID: 24284 Comm: syz.2.5397 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1891 [inline]
 sb_start_intwrite include/linux/fs.h:2013 [inline]
 ocfs2_start_trans+0x267/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_acquire_dquot+0x66e/0xb10 fs/ocfs2/quota_global.c:848
 dqget+0x778/0xeb0 fs/quota/dquot.c:988
 __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
 ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
 ocfs2_mknod+0x8be/0x2350 fs/ocfs2/namei.c:310
 vfs_mknod+0x424/0x4c0 fs/namei.c:3993
 do_mknodat+0x34e/0x4c0 fs/namei.c:-1
 __do_sys_mknodat fs/namei.c:4071 [inline]
 __se_sys_mknodat fs/namei.c:4068 [inline]
 __x64_sys_mknodat+0xa5/0xc0 fs/namei.c:4068
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fb884f8f749
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb885f0f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000103
RAX: ffffffffffffffda RBX: 00007fb8851e5fa0 RCX: 00007fb884f8f749
RDX: 0000000000006004 RSI: 0000200000000000 RDI: ffffffffffffff9c
RBP: 00007fb885013f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000705 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fb8851e6038 R14: 00007fb8851e5fa0 R15: 00007ffc3dae5198
 </TASK>