syzbot

loop0: detected capacity change from 0 to 512
EXT4-fs (loop0): Warning: mounting with an experimental mount option 'dioread_nolock' for blocksize < PAGE_SIZE
EXT4-fs (loop0): 1 truncate cleaned up
EXT4-fs (loop0): mounted filesystem without journal. Opts: inode_readahead_blks=0x0000000000000000,nogrpid,debug_want_extra_isize=0x0000000000000066,dioread_nolock,max_batch_time=0x0000000000000008,resgid=0x0000000000000000,,errors=continue. Quota mode: writeback.
======================================================
WARNING: possible circular locking dependency detected
5.15.110-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor307/3497 is trying to acquire lock:
ffff888074d45da8 (&ea_inode->i_rwsem#9/1){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
ffff888074d45da8 (&ea_inode->i_rwsem#9/1){+.+.}-{3:3}, at: ext4_xattr_inode_iget+0x4a3/0x5e0 fs/ext4/xattr.c:438

but task is already holding lock:
ffff888074d45238 (&ei->i_data_sem){++++}-{3:3}, at: ext4_setattr+0x1322/0x1990 fs/ext4/inode.c:5486

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ei->i_data_sem){++++}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       down_write+0x97/0x170 kernel/locking/rwsem.c:1541
       ext4_update_i_disksize fs/ext4/ext4.h:3407 [inline]
       ext4_xattr_inode_write fs/ext4/xattr.c:1413 [inline]
       ext4_xattr_inode_lookup_create fs/ext4/xattr.c:1562 [inline]
       ext4_xattr_set_entry+0x3187/0x3c00 fs/ext4/xattr.c:1686
       ext4_xattr_ibody_set+0x11d/0x330 fs/ext4/xattr.c:2238
       ext4_xattr_set_handle+0xc72/0x1560 fs/ext4/xattr.c:2395
       ext4_xattr_set+0x231/0x3d0 fs/ext4/xattr.c:2508
       __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x21d/0x420 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x27e/0x2e0 fs/xattr.c:611
       path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __x64_sys_setxattr+0xb7/0xd0 fs/xattr.c:642
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&ea_inode->i_rwsem#9/1){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       down_write+0x97/0x170 kernel/locking/rwsem.c:1541
       inode_lock include/linux/fs.h:787 [inline]
       ext4_xattr_inode_iget+0x4a3/0x5e0 fs/ext4/xattr.c:438
       ext4_xattr_inode_get+0x17d/0x9a0 fs/ext4/xattr.c:501
       ext4_xattr_move_to_block fs/ext4/xattr.c:2589 [inline]
       ext4_xattr_make_inode_space fs/ext4/xattr.c:2691 [inline]
       ext4_expand_extra_isize_ea+0xe77/0x1bc0 fs/ext4/xattr.c:2783
       __ext4_expand_extra_isize+0x2f7/0x3d0 fs/ext4/inode.c:5828
       ext4_try_to_expand_extra_isize fs/ext4/inode.c:5871 [inline]
       __ext4_mark_inode_dirty+0x539/0x860 fs/ext4/inode.c:5949
       ext4_setattr+0x13b0/0x1990 fs/ext4/inode.c:5489
       notify_change+0xd4d/0x1000 fs/attr.c:488
       do_truncate+0x21c/0x300 fs/open.c:65
       handle_truncate fs/namei.c:3195 [inline]
       do_open fs/namei.c:3542 [inline]
       path_openat+0x28a0/0x2f20 fs/namei.c:3672
       do_filp_open+0x21c/0x460 fs/namei.c:3699
       do_sys_openat2+0x13b/0x500 fs/open.c:1211
       do_sys_open fs/open.c:1227 [inline]
       __do_sys_creat fs/open.c:1301 [inline]
       __se_sys_creat fs/open.c:1295 [inline]
       __x64_sys_creat+0x11f/0x160 fs/open.c:1295
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->i_data_sem);
                               lock(&ea_inode->i_rwsem#9/1);
                               lock(&ei->i_data_sem);
  lock(&ea_inode->i_rwsem#9/1);

 *** DEADLOCK ***

5 locks held by syz-executor307/3497:
 #0: ffff888015da6460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff888074d453b0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff888074d453b0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: do_truncate+0x208/0x300 fs/open.c:63
 #2: ffff888074d45550 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:832 [inline]
 #2: ffff888074d45550 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_setattr+0xdaa/0x1990 fs/ext4/inode.c:5446
 #3: ffff888074d45238 (&ei->i_data_sem){++++}-{3:3}, at: ext4_setattr+0x1322/0x1990 fs/ext4/inode.c:5486
 #4: ffff888074d45088 (&ei->xattr_sem){++++}-{3:3}, at: ext4_write_trylock_xattr fs/ext4/xattr.h:162 [inline]
 #4: ffff888074d45088 (&ei->xattr_sem){++++}-{3:3}, at: ext4_try_to_expand_extra_isize fs/ext4/inode.c:5868 [inline]
 #4: ffff888074d45088 (&ei->xattr_sem){++++}-{3:3}, at: __ext4_mark_inode_dirty+0x4a0/0x860 fs/ext4/inode.c:5949

stack backtrace:
CPU: 1 PID: 3497 Comm: syz-executor307 Not tainted 5.15.110-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
 down_write+0x97/0x170 kernel/locking/rwsem.c:1541
 inode_lock include/linux/fs.h:787 [inline]
 ext4_xattr_inode_iget+0x4a3/0x5e0 fs/ext4/xattr.c:438
 ext4_xattr_inode_get+0x17d/0x9a0 fs/ext4/xattr.c:501
 ext4_xattr_move_to_block fs/ext4/xattr.c:2589 [inline]
 ext4_xattr_make_inode_space fs/ext4/xattr.c:2691 [inline]
 ext4_expand_extra_isize_ea+0xe77/0x1bc0 fs/ext4/xattr.c:2783
 __ext4_expand_extra_isize+0x2f7/0x3d0 fs/ext4/inode.c:5828
 ext4_try_to_expand_extra_isize fs/ext4/inode.c:5871 [inline]
 __ext4_mark_inode_dirty+0x539/0x860 fs/ext4/inode.c:5949
 ext4_setattr+0x13b0/0x1990 fs/ext4/inode.c:5489
 notify_change+0xd4d/0x1000 fs/attr.c:488
 do_truncate+0x21c/0x300 fs/open.c:65
 handle_truncate fs/namei.c:3195 [inline]
 do_open fs/namei.c:3542 [inline]
 path_openat+0x28a0/0x2f20 fs/namei.c:3672
 do_filp_open+0x21c/0x460 fs/namei.c:3699
 do_sys_openat2+0x13b/0x500 fs/open.c:1211
 do_sys_open fs/open.c:1227 [inline]
 __do_sys_creat fs/open.c:1301 [inline]
 __se_sys_creat fs/open.c:1295 [inline]
 __x64_sys_creat+0x11f/0x160 fs/open.c:1295
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fb3256a0c29
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc984d49d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda