syzbot

======================================================
WARNING: possible circular locking dependency detected
5.15.156-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/6541 is trying to acquire lock:
ffff8880195e4ef8
 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397

but task is already holding lock:
ffff88801df720b0 (&tree->tree_lock#2/1
){+.+.}-{3:3}, at: hfs_find_init+0x16a/0x1e0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfs_find_init+0x16a/0x1e0
       hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
       hfs_extend_file+0x317/0x1440 fs/hfs/extent.c:401
       hfs_bmap_reserve+0xd5/0x3f0 fs/hfs/btree.c:231
       hfs_cat_create+0x1e7/0xa60 fs/hfs/catalog.c:104
       hfs_create+0x62/0xd0 fs/hfs/dir.c:202
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x130a/0x2f20 fs/namei.c:3739
       do_filp_open+0x21c/0x460 fs/namei.c:3769
       file_open_name fs/open.c:1198 [inline]
       filp_open+0x25d/0x2c0 fs/open.c:1218
       do_coredump+0x2549/0x31e0 fs/coredump.c:767
       get_signal+0xc06/0x14e0 kernel/signal.c:2875
       arch_do_signal_or_restart+0xc3/0x1890 arch/x86/kernel/signal.c:867
       handle_signal_work kernel/entry/common.c:154 [inline]
       exit_to_user_mode_loop+0x97/0x130 kernel/entry/common.c:178
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       irqentry_exit_to_user_mode+0x5/0x30 kernel/entry/common.c:320
       exc_page_fault+0x342/0x740 arch/x86/mm/fault.c:1535
       asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397
       hfs_bmap_reserve+0xd5/0x3f0 fs/hfs/btree.c:231
       __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121
       __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174
       hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
       hfs_extend_file+0x340/0x1440 fs/hfs/extent.c:401
       hfs_get_block+0x3e0/0xb60 fs/hfs/extent.c:353
       __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
       __block_write_begin fs/buffer.c:2062 [inline]
       block_write_begin fs/buffer.c:2122 [inline]
       cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
       hfs_write_begin+0x92/0xd0 fs/hfs/inode.c:59
       generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
       __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
       generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0xacf/0xe50 fs/read_write.c:594
       ksys_write+0x1a2/0x2c0 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock#2/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock#2/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

5 locks held by syz-executor.1/6541:
 #0: ffff8880588134f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2cb/0x380 fs/file.c:1088
 #1: ffff888078998460 (sb_writers#25){.+.+}-{0:0}, at: vfs_write+0x29a/0xe50 fs/read_write.c:590
 #2: ffff8880195e5728 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
 #2: ffff8880195e5728 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: generic_file_write_iter+0x7c/0x1b0 mm/filemap.c:3941
 #3: ffff8880195e5578 (&HFS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397
 #4: ffff88801df720b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x16a/0x1e0

stack backtrace:
CPU: 0 PID: 6541 Comm: syz-executor.1 Not tainted 5.15.156-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfs_extend_file+0xfb/0x1440 fs/hfs/extent.c:397
 hfs_bmap_reserve+0xd5/0x3f0 fs/hfs/btree.c:231
 __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121
 __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174
 hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
 hfs_extend_file+0x340/0x1440 fs/hfs/extent.c:401
 hfs_get_block+0x3e0/0xb60 fs/hfs/extent.c:353
 __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
 __block_write_begin fs/buffer.c:2062 [inline]
 block_write_begin fs/buffer.c:2122 [inline]
 cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
 hfs_write_begin+0x92/0xd0 fs/hfs/inode.c:59
 generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
 __generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3944
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0xacf/0xe50 fs/read_write.c:594
 ksys_write+0x1a2/0x2c0 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f4dc2b64ea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4dc10b60c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f4dc2c93050 RCX: 00007f4dc2b64ea9
RDX: 000000000208e24b RSI: 0000000020000480 RDI: 0000000000000004
RBP: 00007f4dc2bb14a4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000006e R14: 00007f4dc2c93050 R15: 00007ffda81707e8
 </TASK>