syzbot

hfs: continuing without an alternate MDB
======================================================
WARNING: possible circular locking dependency detected
6.5.0-rc7-syzkaller-00018-g89bf6209cad6 #0 Not tainted
------------------------------------------------------
syz-executor.3/20833 is trying to acquire lock:
ffff8880542b2178 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xff/0x1440 fs/hfs/extent.c:397

but task is already holding lock:
ffff8880211400b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x16e/0x1f0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{3:3}:
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       hfs_find_init+0x16e/0x1f0
       hfs_ext_read_extent fs/hfs/extent.c:200 [inline]
       hfs_extend_file+0x31b/0x1440 fs/hfs/extent.c:401
       hfs_bmap_reserve+0xd9/0x3f0 fs/hfs/btree.c:234
       hfs_cat_move+0x1bb/0x1050 fs/hfs/catalog.c:310
       hfs_rename+0x246/0x320 fs/hfs/dir.c:299
       vfs_rename+0xaba/0xde0 fs/namei.c:4857
       do_renameat2+0xd78/0x1660 fs/namei.c:5009
       __do_sys_renameat2 fs/namei.c:5042 [inline]
       __se_sys_renameat2 fs/namei.c:5039 [inline]
       __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:5039
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3142 [inline]
       check_prevs_add kernel/locking/lockdep.c:3261 [inline]
       validate_chain kernel/locking/lockdep.c:3876 [inline]
       __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       hfs_extend_file+0xff/0x1440 fs/hfs/extent.c:397
       hfs_bmap_reserve+0xd9/0x3f0 fs/hfs/btree.c:234
       __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121
       __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174
       hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
       hfs_extend_file+0x344/0x1440 fs/hfs/extent.c:401
       hfs_get_block+0x3e4/0xb60 fs/hfs/extent.c:353
       __block_write_begin_int+0x555/0x1a60 fs/buffer.c:2128
       __block_write_begin fs/buffer.c:2178 [inline]
       block_write_begin+0x9c/0x1f0 fs/buffer.c:2239
       cont_write_begin+0x643/0x880 fs/buffer.c:2597
       hfs_write_begin+0x8a/0xd0 fs/hfs/inode.c:58
       cont_expand_zero fs/buffer.c:2524 [inline]
       cont_write_begin+0x316/0x880 fs/buffer.c:2587
       hfs_write_begin+0x8a/0xd0 fs/hfs/inode.c:58
       hfs_file_truncate+0x1ed/0xa20 fs/hfs/extent.c:494
       hfs_inode_setattr+0x461/0x6a0 fs/hfs/inode.c:656
       notify_change+0xc8b/0xf40 fs/attr.c:483
       do_truncate+0x220/0x300 fs/open.c:66
       do_sys_ftruncate+0x2f3/0x390 fs/open.c:194
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock#2/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock#2/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz-executor.3/20833:
 #0: ffff888063cd0410 (sb_writers#16){.+.+}-{0:0}, at: do_sys_ftruncate+0x258/0x390 fs/open.c:191
 #1: ffff8880542b36a8 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline]
 #1: ffff8880542b36a8 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: do_truncate+0x20c/0x300 fs/open.c:64
 #2: ffff8880542b34f8 (&HFS_I(inode)->extents_lock#2){+.+.}-{3:3}, at: hfs_extend_file+0xff/0x1440 fs/hfs/extent.c:397
 #3: ffff8880211400b0 (&tree->tree_lock#2/1){+.+.}-{3:3}, at: hfs_find_init+0x16e/0x1f0

stack backtrace:
CPU: 1 PID: 20833 Comm: syz-executor.3 Not tainted 6.5.0-rc7-syzkaller-00018-g89bf6209cad6 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2195
 check_prev_add kernel/locking/lockdep.c:3142 [inline]
 check_prevs_add kernel/locking/lockdep.c:3261 [inline]
 validate_chain kernel/locking/lockdep.c:3876 [inline]
 __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761
 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
 hfs_extend_file+0xff/0x1440 fs/hfs/extent.c:397
 hfs_bmap_reserve+0xd9/0x3f0 fs/hfs/btree.c:234
 __hfs_ext_write_extent+0x22e/0x4f0 fs/hfs/extent.c:121
 __hfs_ext_cache_extent+0x6a/0x990 fs/hfs/extent.c:174
 hfs_ext_read_extent fs/hfs/extent.c:202 [inline]
 hfs_extend_file+0x344/0x1440 fs/hfs/extent.c:401
 hfs_get_block+0x3e4/0xb60 fs/hfs/extent.c:353
 __block_write_begin_int+0x555/0x1a60 fs/buffer.c:2128
 __block_write_begin fs/buffer.c:2178 [inline]
 block_write_begin+0x9c/0x1f0 fs/buffer.c:2239
 cont_write_begin+0x643/0x880 fs/buffer.c:2597
 hfs_write_begin+0x8a/0xd0 fs/hfs/inode.c:58
 cont_expand_zero fs/buffer.c:2524 [inline]
 cont_write_begin+0x316/0x880 fs/buffer.c:2587
 hfs_write_begin+0x8a/0xd0 fs/hfs/inode.c:58
 hfs_file_truncate+0x1ed/0xa20 fs/hfs/extent.c:494
 hfs_inode_setattr+0x461/0x6a0 fs/hfs/inode.c:656
 notify_change+0xc8b/0xf40 fs/attr.c:483
 do_truncate+0x220/0x300 fs/open.c:66
 do_sys_ftruncate+0x2f3/0x390 fs/open.c:194
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f742587cae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f74265690c8 EFLAGS: 00000246 ORIG_RAX: 000000000000004d
RAX: ffffffffffffffda RBX: 00007f742599bf80 RCX: 00007f742587cae9
RDX: 0000000000000000 RSI: 0000000000040000 RDI: 0000000000000004
RBP: 00007f74258c847a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f742599bf80 R15: 00007ffe4b94ebd8
 </TASK>