syzbot


possible deadlock in hfsplus_block_allocate (2)

Status: upstream: reported C repro on 2024/12/07 22:33
Bug presence: origin:upstream
[Documentation on labels]
Reported-by: syzbot+03a0802a8f4ab6fd5607@syzkaller.appspotmail.com
First crash: 13d, last: 13d
Bug presence (1)
Date Name Commit Repro Result
2024/12/08 upstream (ToT) 7503345ac5f5 C [report] possible deadlock in hfsplus_block_allocate
Similar bugs (6)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_block_allocate 26 235d 631d 0/3 auto-obsoleted due to no activity on 2024/08/08 03:24
linux-4.14 possible deadlock in hfsplus_block_allocate hfsplus 2 702d 719d 0/1 upstream: reported on 2023/01/02 02:59
upstream possible deadlock in hfsplus_block_allocate hfs C done 251 6h38m 753d 0/28 upstream: reported C repro on 2022/11/29 13:38
linux-5.15 possible deadlock in hfsplus_block_allocate (2) 1 139d 139d 0/3 auto-obsoleted due to no activity on 2024/11/11 18:00
linux-4.19 possible deadlock in hfsplus_block_allocate hfsplus 2 722d 730d 0/1 upstream: reported on 2022/12/22 13:15
linux-5.15 possible deadlock in hfsplus_block_allocate 18 277d 637d 0/3 auto-obsoleted due to no activity on 2024/06/27 07:36

Sample crash report:
loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.1.119-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor161/4354 is trying to acquire lock:
ffff0000dacdd8f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x90/0x818 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff0000def1c488 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:458

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260
       block_read_full_folio+0x2f4/0x98c fs/buffer.c:2271
       hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28
       filemap_read_folio+0x14c/0x39c mm/filemap.c:2489
       do_read_cache_folio+0x24c/0x544 mm/filemap.c:3626
       do_read_cache_page mm/filemap.c:3668 [inline]
       read_cache_page+0x6c/0x180 mm/filemap.c:3677
       read_mapping_page include/linux/pagemap.h:791 [inline]
       hfsplus_block_allocate+0xe0/0x818 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:469
       hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991
       __block_write_begin fs/buffer.c:2041 [inline]
       block_write_begin fs/buffer.c:2102 [inline]
       cont_write_begin+0x5c0/0x7d8 fs/buffer.c:2456
       hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
       cont_expand_zero fs/buffer.c:2416 [inline]
       cont_write_begin+0x640/0x7d8 fs/buffer.c:2446
       hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
       generic_cont_expand_simple+0x160/0x258 fs/buffer.c:2347
       hfsplus_setattr+0x148/0x25c fs/hfsplus/inode.c:263
       notify_change+0xb58/0xe1c fs/attr.c:499
       do_truncate+0x1c0/0x28c fs/open.c:65
       do_sys_ftruncate+0x288/0x31c fs/open.c:193
       __do_sys_ftruncate fs/open.c:204 [inline]
       __se_sys_ftruncate fs/open.c:202 [inline]
       __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_block_allocate+0x90/0x818 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:469
       hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991
       __block_write_begin fs/buffer.c:2041 [inline]
       block_write_begin fs/buffer.c:2102 [inline]
       cont_write_begin+0x5c0/0x7d8 fs/buffer.c:2456
       hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
       cont_expand_zero fs/buffer.c:2383 [inline]
       cont_write_begin+0x2ac/0x7d8 fs/buffer.c:2446
       hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
       generic_perform_write+0x278/0x55c mm/filemap.c:3845
       __generic_file_write_iter+0x168/0x388 mm/filemap.c:3973
       generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:4005
       do_iter_write+0x534/0x964 fs/read_write.c:861
       vfs_writev fs/read_write.c:934 [inline]
       do_pwritev+0x1ec/0x334 fs/read_write.c:1031
       __do_sys_pwritev2 fs/read_write.c:1090 [inline]
       __se_sys_pwritev2 fs/read_write.c:1081 [inline]
       __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

3 locks held by syz-executor161/4354:
 #0: ffff0000db6d8460 (sb_writers#8){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline]
 #0: ffff0000db6d8460 (sb_writers#8){.+.+}-{0:0}, at: do_pwritev+0x1d8/0x334 fs/read_write.c:1031
 #1: ffff0000def1c680 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff0000def1c680 (&sb->s_type->i_mutex_key#17){+.+.}-{3:3}, at: generic_file_write_iter+0x88/0x2b4 mm/filemap.c:4002
 #2: ffff0000def1c488 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:458

stack backtrace:
CPU: 1 PID: 4354 Comm: syz-executor161 Not tainted 6.1.119-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
 hfsplus_block_allocate+0x90/0x818 fs/hfsplus/bitmap.c:35
 hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:469
 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991
 __block_write_begin fs/buffer.c:2041 [inline]
 block_write_begin fs/buffer.c:2102 [inline]
 cont_write_begin+0x5c0/0x7d8 fs/buffer.c:2456
 hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
 cont_expand_zero fs/buffer.c:2383 [inline]
 cont_write_begin+0x2ac/0x7d8 fs/buffer.c:2446
 hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52
 generic_perform_write+0x278/0x55c mm/filemap.c:3845
 __generic_file_write_iter+0x168/0x388 mm/filemap.c:3973
 generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:4005
 do_iter_write+0x534/0x964 fs/read_write.c:861
 vfs_writev fs/read_write.c:934 [inline]
 do_pwritev+0x1ec/0x334 fs/read_write.c:1031
 __do_sys_pwritev2 fs/read_write.c:1090 [inline]
 __se_sys_pwritev2 fs/read_write.c:1081 [inline]
 __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1081
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/12/07 22:33 linux-6.1.y e4d90d63d385 9ac0fdc6 .config console log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro #1] [mounted in repro #2] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_block_allocate
* Struck through repros no longer work on HEAD.