syzbot

loop3: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.4.0-rc4-syzkaller-00204-gc43a6ff9f93f #0 Not tainted
------------------------------------------------------
syz-executor.3/11973 is trying to acquire lock:
ffff88807a4530f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff88802aa00e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d6/0x1b10 fs/hfsplus/extents.c:457

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260
       block_read_full_folio+0x47b/0x1000 fs/buffer.c:2349
       filemap_read_folio+0x19d/0x7a0 mm/filemap.c:2421
       do_read_cache_folio+0x134/0x820 mm/filemap.c:3680
       do_read_cache_page+0x32/0x220 mm/filemap.c:3746
       read_mapping_page include/linux/pagemap.h:772 [inline]
       hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37
       hfsplus_file_extend+0xa50/0x1b10 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x548/0x1a50 fs/buffer.c:2064
       __block_write_begin fs/buffer.c:2114 [inline]
       block_write_begin+0x9c/0x1f0 fs/buffer.c:2175
       cont_write_begin+0x643/0x880 fs/buffer.c:2534
       hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52
       page_symlink+0x2c5/0x4e0 fs/namei.c:5193
       hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449
       vfs_symlink+0x12f/0x2a0 fs/namei.c:4475
       do_symlinkat+0x201/0x610 fs/namei.c:4501
       __do_sys_symlinkat fs/namei.c:4517 [inline]
       __se_sys_symlinkat fs/namei.c:4514 [inline]
       __x64_sys_symlinkat+0x99/0xb0 fs/namei.c:4514
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3113 [inline]
       check_prevs_add kernel/locking/lockdep.c:3232 [inline]
       validate_chain+0x166b/0x58f0 kernel/locking/lockdep.c:3847
       __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088
       lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
       __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
       hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35
       hfsplus_file_extend+0xa50/0x1b10 fs/hfsplus/extents.c:468
       hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245
       __block_write_begin_int+0x548/0x1a50 fs/buffer.c:2064
       __block_write_begin fs/buffer.c:2114 [inline]
       block_write_begin+0x9c/0x1f0 fs/buffer.c:2175
       cont_write_begin+0x643/0x880 fs/buffer.c:2534
       hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52
       generic_perform_write+0x300/0x5e0 mm/filemap.c:3923
       __generic_file_write_iter+0x17a/0x400 mm/filemap.c:4051
       generic_file_write_iter+0xaf/0x310 mm/filemap.c:4083
       call_write_iter include/linux/fs.h:1868 [inline]
       new_sync_write fs/read_write.c:491 [inline]
       vfs_write+0x790/0xb20 fs/read_write.c:584
       ksys_write+0x1a0/0x2c0 fs/read_write.c:637
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&sbi->alloc_mutex);
                               lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&sbi->alloc_mutex);

 *** DEADLOCK ***

4 locks held by syz-executor.3/11973:
 #0: ffff88807c4dd268 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x254/0x2f0 fs/file.c:1047
 #1: ffff888032898460 (sb_writers#17){.+.+}-{0:0}, at: vfs_write+0x223/0xb20 fs/read_write.c:580
 #2: ffff88802aa01080 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:775 [inline]
 #2: ffff88802aa01080 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: generic_file_write_iter+0x83/0x310 mm/filemap.c:4080
 #3: ffff88802aa00e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d6/0x1b10 fs/hfsplus/extents.c:457

stack backtrace:
CPU: 1 PID: 11973 Comm: syz-executor.3 Not tainted 6.4.0-rc4-syzkaller-00204-gc43a6ff9f93f #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3113 [inline]
 check_prevs_add kernel/locking/lockdep.c:3232 [inline]
 validate_chain+0x166b/0x58f0 kernel/locking/lockdep.c:3847
 __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088
 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705
 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799
 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35
 hfsplus_file_extend+0xa50/0x1b10 fs/hfsplus/extents.c:468
 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x548/0x1a50 fs/buffer.c:2064
 __block_write_begin fs/buffer.c:2114 [inline]
 block_write_begin+0x9c/0x1f0 fs/buffer.c:2175
 cont_write_begin+0x643/0x880 fs/buffer.c:2534
 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52
 generic_perform_write+0x300/0x5e0 mm/filemap.c:3923
 __generic_file_write_iter+0x17a/0x400 mm/filemap.c:4051
 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4083
 call_write_iter include/linux/fs.h:1868 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x790/0xb20 fs/read_write.c:584
 ksys_write+0x1a0/0x2c0 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f0a34a8c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0a3574a168 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f0a34babf80 RCX: 00007f0a34a8c169
RDX: 00000000000ffe00 RSI: 0000000020004200 RDI: 0000000000000004
RBP: 00007f0a34ae7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff1c16a5bf R14: 00007f0a3574a300 R15: 0000000000022000
 </TASK>