syzbot

loop0: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.37/4508 is trying to acquire lock:
ffff88802f0fd488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x1a2/0x7b0 fs/ocfs2/sysfile.c:101

but task is already holding lock:
ffff88805f2922e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_wr_get_block+0x8db/0x17a0 fs/ocfs2/aops.c:2225

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x42/0x2d0 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x265/0x950 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x3d1/0x20c0 fs/ocfs2/dir.c:1091
       ocfs2_find_files_on_disk+0x102/0x390 fs/ocfs2/dir.c:1995
       ocfs2_lookup_ino_from_name+0x4f/0xf0 fs/ocfs2/dir.c:2017
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x332/0x7b0 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x316/0x650 fs/ocfs2/super.c:457
       ocfs2_initialize_super fs/ocfs2/super.c:2253 [inline]
       ocfs2_fill_super+0x2a32/0x4d00 fs/ocfs2/super.c:994
       mount_bdev+0x287/0x3c0 fs/super.c:1443
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x24a/0xa40 fs/namespace.c:3078
       do_mount fs/namespace.c:3421 [inline]
       __do_sys_mount fs/namespace.c:3629 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3606
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&osb->system_file_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
       lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
       ocfs2_get_system_file_inode+0x1a2/0x7b0 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_local_alloc_bits+0xfc/0x2670 fs/ocfs2/localalloc.c:626
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
       ocfs2_write_begin_nolock+0x2286/0x4270 fs/ocfs2/aops.c:1740
       ocfs2_dio_wr_get_block+0xb6d/0x17a0 fs/ocfs2/aops.c:2239
       get_more_blocks fs/direct-io.c:665 [inline]
       do_direct_IO fs/direct-io.c:953 [inline]
       __blockdev_direct_IO+0x16a9/0x3450 fs/direct-io.c:1266
       ocfs2_direct_IO+0x23e/0x2b0 fs/ocfs2/aops.c:2468
       generic_file_direct_write+0x3be/0x660 mm/filemap.c:3770
       __generic_file_write_iter+0x1db/0x430 mm/filemap.c:3930
       ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
       do_iter_readv_writev fs/read_write.c:-1 [inline]
       do_iter_write+0x62d/0xaf0 fs/read_write.c:861
       iter_file_splice_write+0x665/0xc50 fs/splice.c:685
       do_splice_from fs/splice.c:763 [inline]
       direct_splice_actor+0xe1/0x130 fs/splice.c:950
       splice_direct_to_actor+0x480/0xb60 fs/splice.c:896
       do_splice_direct+0x1b0/0x2b0 fs/splice.c:1002
       do_sendfile+0x5cc/0xeb0 fs/read_write.c:1255
       __do_sys_sendfile64 fs/read_write.c:1323 [inline]
       __se_sys_sendfile64+0x13b/0x190 fs/read_write.c:1309
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&osb->system_file_mutex);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&osb->system_file_mutex);

 *** DEADLOCK ***

3 locks held by syz.0.37/4508:
 #0: ffff88802eac2460 (sb_writers#13){.+.+}-{0:0}, at: do_sendfile+0x5a9/0xeb0 fs/read_write.c:1254
 #1: ffff88805f292648 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88805f292648 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x438/0x1df0 fs/ocfs2/file.c:2399
 #2: ffff88805f2922e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_wr_get_block+0x8db/0x17a0 fs/ocfs2/aops.c:2225

stack backtrace:
CPU: 1 PID: 4508 Comm: syz.0.37 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x22e lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x2cf8/0x7c50 kernel/locking/lockdep.c:5049
 lock_acquire+0x1b4/0x490 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x120/0xaf0 kernel/locking/mutex.c:747
 ocfs2_get_system_file_inode+0x1a2/0x7b0 fs/ocfs2/sysfile.c:101
 ocfs2_reserve_local_alloc_bits+0xfc/0x2670 fs/ocfs2/localalloc.c:626
 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
 ocfs2_write_begin_nolock+0x2286/0x4270 fs/ocfs2/aops.c:1740
 ocfs2_dio_wr_get_block+0xb6d/0x17a0 fs/ocfs2/aops.c:2239
 get_more_blocks fs/direct-io.c:665 [inline]
 do_direct_IO fs/direct-io.c:953 [inline]
 __blockdev_direct_IO+0x16a9/0x3450 fs/direct-io.c:1266
 ocfs2_direct_IO+0x23e/0x2b0 fs/ocfs2/aops.c:2468
 generic_file_direct_write+0x3be/0x660 mm/filemap.c:3770
 __generic_file_write_iter+0x1db/0x430 mm/filemap.c:3930
 ocfs2_file_write_iter+0x1593/0x1df0 fs/ocfs2/file.c:2469
 do_iter_readv_writev fs/read_write.c:-1 [inline]
 do_iter_write+0x62d/0xaf0 fs/read_write.c:861
 iter_file_splice_write+0x665/0xc50 fs/splice.c:685
 do_splice_from fs/splice.c:763 [inline]
 direct_splice_actor+0xe1/0x130 fs/splice.c:950
 splice_direct_to_actor+0x480/0xb60 fs/splice.c:896
 do_splice_direct+0x1b0/0x2b0 fs/splice.c:1002
 do_sendfile+0x5cc/0xeb0 fs/read_write.c:1255
 __do_sys_sendfile64 fs/read_write.c:1323 [inline]
 __se_sys_sendfile64+0x13b/0x190 fs/read_write.c:1309
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f085e58efc9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffdc5cedb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007f085e7e5fa0 RCX: 00007f085e58efc9
RDX: 0000000000000000 RSI: 0000000000000005 RDI: 0000000000000004
RBP: 00007f085e611f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020fffe82 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f085e7e5fa0 R14: 00007f085e7e5fa0 R15: 0000000000000004
 </TASK>
(syz.0.37,4508,1):ocfs2_dio_end_io:2428 ERROR: Direct IO failed, bytes = -5