syzbot

loop0: detected capacity change from 0 to 32768
ocfs2: Slot 0 on device (7,0) was already allocated to this node!
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.59/4473 is trying to acquire lock:
ffff88807ac25488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x1b5/0x760 fs/ocfs2/sysfile.c:101

but task is already holding lock:
ffff88805e27a2e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x23f/0x8a0 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x3d1/0x1f90 fs/ocfs2/dir.c:1091
       ocfs2_find_files_on_disk+0xdb/0x2f0 fs/ocfs2/dir.c:1995
       ocfs2_lookup_ino_from_name+0x4f/0xf0 fs/ocfs2/dir.c:2017
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x319/0x760 fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x316/0x650 fs/ocfs2/super.c:458
       ocfs2_initialize_super fs/ocfs2/super.c:2279 [inline]
       ocfs2_fill_super+0x3dbf/0x4d80 fs/ocfs2/super.c:995
       mount_bdev+0x287/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3025
       do_mount fs/namespace.c:3368 [inline]
       __do_sys_mount fs/namespace.c:3576 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3553
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&osb->system_file_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       ocfs2_get_system_file_inode+0x1b5/0x760 fs/ocfs2/sysfile.c:101
       ocfs2_reserve_local_alloc_bits+0xfc/0x24c0 fs/ocfs2/localalloc.c:626
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x397/0x1760 fs/ocfs2/file.c:588
       ocfs2_extend_no_holes+0x20b/0x490 fs/ocfs2/file.c:1030
       ocfs2_expand_nonsparse_inode+0x15d/0x440 fs/ocfs2/aops.c:1622
       ocfs2_write_begin_nolock+0x1a34/0x4180 fs/ocfs2/aops.c:1688
       ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905
       generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
       __generic_file_write_iter+0x383/0x4e0 mm/filemap.c:3880
       ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x497/0x600 fs/read_write.c:-1
       do_iter_write+0x205/0x7b0 fs/read_write.c:855
       vfs_writev fs/read_write.c:928 [inline]
       do_pwritev+0x204/0x340 fs/read_write.c:1025
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&osb->system_file_mutex);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&osb->system_file_mutex);

 *** DEADLOCK ***

3 locks held by syz.0.59/4473:
 #0: ffff888077062460 (sb_writers#13){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:927 [inline]
 #0: ffff888077062460 (sb_writers#13){.+.+}-{0:0}, at: do_pwritev+0x1f2/0x340 fs/read_write.c:1025
 #1: ffff88805e27a648 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805e27a648 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x401/0x1cf0 fs/ocfs2/file.c:2402
 #2: ffff88805e27a2e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903

stack backtrace:
CPU: 1 PID: 4473 Comm: syz.0.59 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 ocfs2_get_system_file_inode+0x1b5/0x760 fs/ocfs2/sysfile.c:101
 ocfs2_reserve_local_alloc_bits+0xfc/0x24c0 fs/ocfs2/localalloc.c:626
 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669
 ocfs2_extend_allocation+0x397/0x1760 fs/ocfs2/file.c:588
 ocfs2_extend_no_holes+0x20b/0x490 fs/ocfs2/file.c:1030
 ocfs2_expand_nonsparse_inode+0x15d/0x440 fs/ocfs2/aops.c:1622
 ocfs2_write_begin_nolock+0x1a34/0x4180 fs/ocfs2/aops.c:1688
 ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905
 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
 __generic_file_write_iter+0x383/0x4e0 mm/filemap.c:3880
 ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472
 do_iter_readv_writev+0x497/0x600 fs/read_write.c:-1
 do_iter_write+0x205/0x7b0 fs/read_write.c:855
 vfs_writev fs/read_write.c:928 [inline]
 do_pwritev+0x204/0x340 fs/read_write.c:1025
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f077e466ec9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff3d87c348 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007f077e6bdfa0 RCX: 00007f077e466ec9
RDX: 0000000000000001 RSI: 0000200000000240 RDI: 0000000000000004
RBP: 00007f077e4e9f91 R08: 0000000000000000 R09: 0000000000000003
R10: 0000000000002000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f077e6bdfa0 R14: 00007f077e6bdfa0 R15: 0000000000000006
 </TASK>