syzbot

loop2: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,2) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.146/5112 is trying to acquire lock:
ffff88807e67e650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ffff88807e67e650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ffff88807e67e650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x1c5e/0x4180 fs/ocfs2/aops.c:1671

but task is already holding lock:
ffff88805df022e0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){++++}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x23f/0x8a0 fs/ocfs2/extent_map.c:984
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x3d1/0x1f90 fs/ocfs2/dir.c:1091
       ocfs2_rename+0x1d36/0x3690 fs/ocfs2/namei.c:1568
       vfs_rename+0xbbf/0x10d0 fs/namei.c:4832
       do_renameat2+0xa83/0xf70 fs/namei.c:4985
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0xddd/0x22b0 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4065
       do_mkdirat+0x1d7/0x5a0 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0xddd/0x22b0 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657
       vfs_mkdir+0x387/0x570 fs/namei.c:4065
       do_mkdirat+0x1d7/0x5a0 fs/namei.c:4090
       __do_sys_mkdirat fs/namei.c:4105 [inline]
       __se_sys_mkdirat fs/namei.c:4103 [inline]
       __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (sb_internal#4){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
       ocfs2_write_begin_nolock+0x1c5e/0x4180 fs/ocfs2/aops.c:1671
       ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905
       generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
       __generic_file_write_iter+0x25f/0x4e0 mm/filemap.c:3912
       ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x712/0xd00 fs/read_write.c:594
       ksys_pwrite64 fs/read_write.c:701 [inline]
       __do_sys_pwrite64 fs/read_write.c:711 [inline]
       __se_sys_pwrite64 fs/read_write.c:708 [inline]
       __x64_sys_pwrite64+0x194/0x220 fs/read_write.c:708
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  sb_internal#4 --> jbd2_handle --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_alloc_sem);
  lock(sb_internal#4);

 *** DEADLOCK ***

3 locks held by syz.2.146/5112:
 #0: ffff88807e67e460 (sb_writers#19){.+.+}-{0:0}, at: vfs_write+0x28a/0xd00 fs/read_write.c:590
 #1: ffff88805df02648 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff88805df02648 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x401/0x1cf0 fs/ocfs2/file.c:2402
 #2: ffff88805df022e0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903

stack backtrace:
CPU: 0 PID: 5112 Comm: syz.2.146 Not tainted syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/18/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1811 [inline]
 sb_start_intwrite include/linux/fs.h:1928 [inline]
 ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
 ocfs2_write_begin_nolock+0x1c5e/0x4180 fs/ocfs2/aops.c:1671
 ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905
 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
 __generic_file_write_iter+0x25f/0x4e0 mm/filemap.c:3912
 ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x712/0xd00 fs/read_write.c:594
 ksys_pwrite64 fs/read_write.c:701 [inline]
 __do_sys_pwrite64 fs/read_write.c:711 [inline]
 __se_sys_pwrite64 fs/read_write.c:708 [inline]
 __x64_sys_pwrite64+0x194/0x220 fs/read_write.c:708
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f59195f7ec9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f591785f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000012
RAX: ffffffffffffffda RBX: 00007f591984efa0 RCX: 00007f59195f7ec9
RDX: 0000000000000001 RSI: 0000200000003840 RDI: 0000000000000004
RBP: 00007f591967af91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000006 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f591984f038 R14: 00007f591984efa0 R15: 00007ffe3553e768
 </TASK>