syzbot

loop8: detected capacity change from 0 to 32768
ocfs2: Mounting device (7,8) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.184-syzkaller #0 Not tainted
------------------------------------------------------
syz.8.2394/11071 is trying to acquire lock:
ffff88807520a650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ffff88807520a650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ffff88807520a650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x1c5e/0x4180 fs/ocfs2/aops.c:1671

but task is already holding lock:
ffff888062695be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ocfs2_lock_global_qf+0x1e5/0x270 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_symlink+0xbec/0x25d0 fs/ocfs2/namei.c:1875
       vfs_symlink+0x247/0x3d0 fs/namei.c:4429
       do_symlinkat+0x1be/0x6c0 fs/namei.c:4458
       __do_sys_symlink fs/namei.c:4480 [inline]
       __se_sys_symlink fs/namei.c:4478 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4478
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       inode_lock include/linux/fs.h:787 [inline]
       ocfs2_lock_global_qf+0x1c7/0x270 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x29d/0xaf0 fs/ocfs2/quota_global.c:816
       dqget+0x778/0xeb0 fs/quota/dquot.c:988
       __dquot_initialize+0x3b6/0xcb0 fs/quota/dquot.c:1517
       ocfs2_get_init_inode+0x138/0x1b0 fs/ocfs2/namei.c:202
       ocfs2_symlink+0xbec/0x25d0 fs/ocfs2/namei.c:1875
       vfs_symlink+0x247/0x3d0 fs/namei.c:4429
       do_symlinkat+0x1be/0x6c0 fs/namei.c:4458
       __do_sys_symlink fs/namei.c:4480 [inline]
       __se_sys_symlink fs/namei.c:4478 [inline]
       __x64_sys_symlink+0x7a/0x90 fs/namei.c:4478
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x1eb/0x2390 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       dquot_commit+0x5a/0x410 fs/quota/dquot.c:507
       ext4_write_dquot+0x1f0/0x360 fs/ext4/super.c:6180
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x1e3/0x400 fs/quota/dquot.c:412
       __dquot_free_space+0x7ca/0xb90 fs/quota/dquot.c:1942
       dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
       dquot_free_space include/linux/quotaops.h:381 [inline]
       dquot_free_block include/linux/quotaops.h:392 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6156 [inline]
       ext4_free_blocks+0x1af5/0x2480 fs/ext4/mballoc.c:6286
       ext4_remove_blocks fs/ext4/extents.c:2523 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2689 [inline]
       ext4_ext_remove_space+0x1eaa/0x4390 fs/ext4/extents.c:2937
       ext4_ext_truncate+0x192/0x240 fs/ext4/extents.c:4471
       ext4_truncate+0x9f1/0x10d0 fs/ext4/inode.c:4250
       ext4_evict_inode+0xb43/0x1080 fs/ext4/inode.c:289
       evict+0x485/0x870 fs/inode.c:647
       ext4_orphan_cleanup+0xaa9/0x12e0 fs/ext4/orphan.c:474
       ext4_fill_super+0x9288/0x9a00 fs/ext4/super.c:4975
       mount_bdev+0x287/0x3c0 fs/super.c:1400
       legacy_get_tree+0xe6/0x180 fs/fs_context.c:611
       vfs_get_tree+0x88/0x270 fs/super.c:1530
       do_new_mount+0x24a/0xa40 fs/namespace.c:3014
       do_mount fs/namespace.c:3357 [inline]
       __do_sys_mount fs/namespace.c:3565 [inline]
       __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3542
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x38/0x60 kernel/locking/rwsem.c:1551
       ext4_truncate+0x96d/0x10d0 fs/ext4/inode.c:4245
       ext4_setattr+0xffe/0x19e0 fs/ext4/inode.c:5582
       notify_change+0xbcd/0xee0 fs/attr.c:505
       do_truncate+0x197/0x220 fs/open.c:65
       do_sys_ftruncate+0x31b/0x3d0 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376
       ocfs2_shutdown_local_alloc+0x1fd/0xa10 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1de/0x880 fs/ocfs2/super.c:1885
       generic_shutdown_super+0x130/0x300 fs/super.c:475
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x418/0x4d0 fs/namespace.c:1143
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374
       ocfs2_shutdown_local_alloc+0x1fd/0xa10 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1de/0x880 fs/ocfs2/super.c:1885
       generic_shutdown_super+0x130/0x300 fs/super.c:475
       kill_block_super+0x7c/0xe0 fs/super.c:1427
       deactivate_locked_super+0x93/0xf0 fs/super.c:335
       cleanup_mnt+0x418/0x4d0 fs/namespace.c:1143
       task_work_run+0x125/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x10f/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x16/0x40 kernel/entry/common.c:307
       do_syscall_64+0x58/0xa0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (sb_internal#3){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
       lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
       ocfs2_write_begin_nolock+0x1c5e/0x4180 fs/ocfs2/aops.c:1671
       ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905
       generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
       __generic_file_write_iter+0x25f/0x4e0 mm/filemap.c:3912
       ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472
       call_write_iter include/linux/fs.h:2172 [inline]
       new_sync_write fs/read_write.c:507 [inline]
       vfs_write+0x712/0xd00 fs/read_write.c:594
       ksys_write+0x14d/0x250 fs/read_write.c:647
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  sb_internal#3 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(sb_internal#3);

 *** DEADLOCK ***

4 locks held by syz.8.2394/11071:
 #0: ffff888075b5b770 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2bf/0x370 fs/file.c:1058
 #1: ffff88807520a460 (sb_writers#21){.+.+}-{0:0}, at: vfs_write+0x28a/0xd00 fs/read_write.c:590
 #2: ffff888062695f48 (&sb->s_type->i_mutex_key#48){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #2: ffff888062695f48 (&sb->s_type->i_mutex_key#48){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x401/0x1cf0 fs/ocfs2/file.c:2402
 #3: ffff888062695be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903

stack backtrace:
CPU: 1 PID: 11071 Comm: syz.8.2394 Not tainted 5.15.184-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106
 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012
 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623
 percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
 __sb_start_write include/linux/fs.h:1811 [inline]
 sb_start_intwrite include/linux/fs.h:1928 [inline]
 ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
 ocfs2_write_begin_nolock+0x1c5e/0x4180 fs/ocfs2/aops.c:1671
 ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905
 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785
 __generic_file_write_iter+0x25f/0x4e0 mm/filemap.c:3912
 ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472
 call_write_iter include/linux/fs.h:2172 [inline]
 new_sync_write fs/read_write.c:507 [inline]
 vfs_write+0x712/0xd00 fs/read_write.c:594
 ksys_write+0x14d/0x250 fs/read_write.c:647
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7fe6236a3969
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe62150b038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fe6238cafa0 RCX: 00007fe6236a3969
RDX: 0000000000000048 RSI: 00002000000000c0 RDI: 0000000000000004
RBP: 00007fe623725ab1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fe6238cafa0 R15: 00007fffa95b4f98
 </TASK>