syzbot

JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/6762 is trying to acquire lock:
ffff0000c99d8610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1459 [inline]
ffff0000c99d8610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1563 [inline]
ffff0000c99d8610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x8cc/0x3868 fs/ocfs2/aops.c:1649

but task is already holding lock:
ffff0000ef4fcda0 (&oi->ip_alloc_sem){++++}-{4:4}, at: ocfs2_write_begin+0x190/0x30c fs/ocfs2/aops.c:1882

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){++++}-{4:4}:
       down_read+0x58/0x308 kernel/locking/rwsem.c:1537
       ocfs2_xattr_ibody_find+0x100/0x668 fs/ocfs2/xattr.c:2719
       ocfs2_xattr_set_handle+0x2bc/0x5e4 fs/ocfs2/xattr.c:3533
       ocfs2_init_security_set+0xb4/0xd8 fs/ocfs2/xattr.c:7337
       ocfs2_mknod+0x104c/0x1cf0 fs/ocfs2/namei.c:423
       ocfs2_create+0x178/0x474 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4440 [inline]
       open_last_lookups fs/namei.c:4540 [inline]
       path_openat+0x143c/0x3114 fs/namei.c:4784
       do_filp_open+0x18c/0x36c fs/namei.c:4814
       do_sys_openat2+0x11c/0x1f0 fs/open.c:1430
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_openat fs/open.c:1452 [inline]
       __se_sys_openat fs/open.c:1447 [inline]
       __arm64_sys_openat+0x120/0x158 fs/open.c:1447
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x254 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0xe8/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x5c/0x26c arch/arm64/kernel/entry-common.c:724
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:743
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:596

-> #2 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x58/0x308 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x258/0x63c fs/ocfs2/acl.c:367
       ocfs2_mknod+0x1008/0x1cf0 fs/ocfs2/namei.c:414
       ocfs2_create+0x178/0x474 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4440 [inline]
       open_last_lookups fs/namei.c:4540 [inline]
       path_openat+0x143c/0x3114 fs/namei.c:4784
       do_filp_open+0x18c/0x36c fs/namei.c:4814
       do_sys_openat2+0x11c/0x1f0 fs/open.c:1430
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_openat fs/open.c:1452 [inline]
       __se_sys_openat fs/open.c:1447 [inline]
       __arm64_sys_openat+0x120/0x158 fs/open.c:1447
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x254 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0xe8/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x5c/0x26c arch/arm64/kernel/entry-common.c:724
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:743
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:596

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x58/0x308 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x35c/0x6b0 fs/ocfs2/journal.c:372
       ocfs2_mknod+0xc30/0x1cf0 fs/ocfs2/namei.c:365
       ocfs2_create+0x178/0x474 fs/ocfs2/namei.c:677
       lookup_open fs/namei.c:4440 [inline]
       open_last_lookups fs/namei.c:4540 [inline]
       path_openat+0x143c/0x3114 fs/namei.c:4784
       do_filp_open+0x18c/0x36c fs/namei.c:4814
       do_sys_openat2+0x11c/0x1f0 fs/open.c:1430
       do_sys_open fs/open.c:1436 [inline]
       __do_sys_openat fs/open.c:1452 [inline]
       __se_sys_openat fs/open.c:1447 [inline]
       __arm64_sys_openat+0x120/0x158 fs/open.c:1447
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x254 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0xe8/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x5c/0x26c arch/arm64/kernel/entry-common.c:724
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:743
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:596

-> #0 (sb_internal#2){.+.+}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5237
       lock_acquire+0x140/0x2e0 kernel/locking/lockdep.c:5868
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_intwrite include/linux/fs/super.h:177 [inline]
       ocfs2_start_trans+0x1f4/0x6b0 fs/ocfs2/journal.c:370
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1459 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1563 [inline]
       ocfs2_write_begin_nolock+0x8cc/0x3868 fs/ocfs2/aops.c:1649
       ocfs2_write_begin+0x1b4/0x30c fs/ocfs2/aops.c:1884
       generic_perform_write+0x244/0x7bc mm/filemap.c:4314
       __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4431
       ocfs2_file_write_iter+0x12f8/0x1b8c fs/ocfs2/file.c:2475
       new_sync_write fs/read_write.c:593 [inline]
       vfs_write+0x540/0xa3c fs/read_write.c:686
       ksys_write+0x120/0x210 fs/read_write.c:738
       __do_sys_write fs/read_write.c:749 [inline]
       __se_sys_write fs/read_write.c:746 [inline]
       __arm64_sys_write+0x7c/0x90 fs/read_write.c:746
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x254 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0xe8/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x5c/0x26c arch/arm64/kernel/entry-common.c:724
       el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:743
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:596

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#2);

 *** DEADLOCK ***

3 locks held by syz.0.17/6762:
 #0: ffff0000c99d8420 (sb_writers#11){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2681 [inline]
 #0: ffff0000c99d8420 (sb_writers#11){.+.+}-{0:0}, at: vfs_write+0x24c/0xa3c fs/read_write.c:682
 #1: ffff0000ef4fd100 (&sb->s_type->i_mutex_key#22){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline]
 #1: ffff0000ef4fd100 (&sb->s_type->i_mutex_key#22){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x388/0x1b8c fs/ocfs2/file.c:2405
 #2: ffff0000ef4fcda0 (&oi->ip_alloc_sem){++++}-{4:4}, at: ocfs2_write_begin+0x190/0x30c fs/ocfs2/aops.c:1882

stack backtrace:
CPU: 0 UID: 0 PID: 6762 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/03/2025
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:499 (C)
 __dump_stack+0x30/0x40 lib/dump_stack.c:94
 dump_stack_lvl+0xd8/0x12c lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x324/0x32c kernel/locking/lockdep.c:2043
 check_noncircular+0x154/0x174 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x1774/0x30a4 kernel/locking/lockdep.c:5237
 lock_acquire+0x140/0x2e0 kernel/locking/lockdep.c:5868
 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
 percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
 __sb_start_write include/linux/fs/super.h:19 [inline]
 sb_start_intwrite include/linux/fs/super.h:177 [inline]
 ocfs2_start_trans+0x1f4/0x6b0 fs/ocfs2/journal.c:370
 ocfs2_write_begin_inline fs/ocfs2/aops.c:1459 [inline]
 ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1563 [inline]
 ocfs2_write_begin_nolock+0x8cc/0x3868 fs/ocfs2/aops.c:1649
 ocfs2_write_begin+0x1b4/0x30c fs/ocfs2/aops.c:1884
 generic_perform_write+0x244/0x7bc mm/filemap.c:4314
 __generic_file_write_iter+0xfc/0x204 mm/filemap.c:4431
 ocfs2_file_write_iter+0x12f8/0x1b8c fs/ocfs2/file.c:2475
 new_sync_write fs/read_write.c:593 [inline]
 vfs_write+0x540/0xa3c fs/read_write.c:686
 ksys_write+0x120/0x210 fs/read_write.c:738
 __do_sys_write fs/read_write.c:749 [inline]
 __se_sys_write fs/read_write.c:746 [inline]
 __arm64_sys_write+0x7c/0x90 fs/read_write.c:746
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x254 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0xe8/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x5c/0x26c arch/arm64/kernel/entry-common.c:724
 el0t_64_sync_handler+0x84/0x12c arch/arm64/kernel/entry-common.c:743
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:596