syzbot

======================================================
WARNING: possible circular locking dependency detected
6.1.123-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor341/4316 is trying to acquire lock:
ffff8880610acda0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976

but task is already holding lock:
ffff888079d9e990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f51/0x21b0 fs/jbd2/transaction.c:463

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xc4c/0x29d0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0x15b5/0x2e20 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdir fs/namei.c:4151 [inline]
       __se_sys_mkdir fs/namei.c:4149 [inline]
       __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4149
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
       ocfs2_reserve_local_alloc_bits+0xc4c/0x29d0 fs/ocfs2/localalloc.c:668
       ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
       ocfs2_mknod+0x15b5/0x2e20 fs/ocfs2/namei.c:354
       ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:657
       vfs_mkdir+0x3b6/0x590 fs/namei.c:4106
       do_mkdirat+0x225/0x360 fs/namei.c:4131
       __do_sys_mkdir fs/namei.c:4151 [inline]
       __se_sys_mkdir fs/namei.c:4149 [inline]
       __x64_sys_mkdir+0x6a/0x80 fs/namei.c:4149
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#2){.+.+}-{0:0}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_setattr+0xa89/0x1e60 fs/ocfs2/file.c:1263
       notify_change+0xce3/0xfc0 fs/attr.c:499
       ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline]
       ovl_workdir_create+0x78b/0x9d0 fs/overlayfs/super.c:833
       ovl_make_workdir fs/overlayfs/super.c:1389 [inline]
       ovl_get_workdir+0x3b7/0x17b0 fs/overlayfs/super.c:1539
       ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2095
       mount_nodev+0x52/0xe0 fs/super.c:1489
       legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
       vfs_get_tree+0x88/0x270 fs/super.c:1573
       do_new_mount+0x2ba/0xb40 fs/namespace.c:3056
       do_mount fs/namespace.c:3399 [inline]
       __do_sys_mount fs/namespace.c:3607 [inline]
       __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3584
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_alloc_sem){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
       ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block+0x102/0x5b0 fs/ocfs2/dir.c:508
       ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1829 [inline]
       ocfs2_dir_foreach_blk+0x2a1/0x1e10 fs/ocfs2/dir.c:1915
       ocfs2_dir_foreach+0x20c/0x270 fs/ocfs2/dir.c:1925
       ocfs2_empty_dir+0x446/0x7b0 fs/ocfs2/dir.c:2139
       ocfs2_rename+0x26c2/0x4000 fs/ocfs2/namei.c:1499
       vfs_rename+0xd32/0x10f0 fs/namei.c:4874
       do_renameat2+0xde0/0x1440 fs/namei.c:5027
       __do_sys_rename fs/namei.c:5073 [inline]
       __se_sys_rename fs/namei.c:5071 [inline]
       __x64_sys_rename+0x82/0x90 fs/namei.c:5071
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
  &oi->ip_alloc_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  lock(&oi->ip_alloc_sem);

 *** DEADLOCK ***

7 locks held by syz-executor341/4316:
 #0: ffff888079d34460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
 #1: ffff888061011808 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: do_renameat2+0x65a/0x1440 fs/namei.c:4966
 #2: ffff8880610ad108 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff8880610ad108 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: vfs_rename+0x814/0x10f0 fs/namei.c:4839
 #3: ffff888061043488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff888061043488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_lookup_lock_orphan_dir+0xfe/0x340 fs/ocfs2/namei.c:2116
 #4: ffff888079d34650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_rename+0x1eed/0x4000 fs/ocfs2/namei.c:1488
 #5: ffff888144f038e8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
 #6: ffff888079d9e990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f51/0x21b0 fs/jbd2/transaction.c:463

stack backtrace:
CPU: 1 PID: 4316 Comm: syz-executor341 Not tainted 6.1.123-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
 ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976
 ocfs2_read_dir_block+0x102/0x5b0 fs/ocfs2/dir.c:508
 ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1829 [inline]
 ocfs2_dir_foreach_blk+0x2a1/0x1e10 fs/ocfs2/dir.c:1915
 ocfs2_dir_foreach+0x20c/0x270 fs/ocfs2/dir.c:1925
 ocfs2_empty_dir+0x446/0x7b0 fs/ocfs2/dir.c:2139
 ocfs2_rename+0x26c2/0x4000 fs/ocfs2/namei.c:1499
 vfs_rename+0xd32/0x10f0 fs/namei.c:4874
 do_renameat2+0xde0/0x1440 fs/namei.c:5027
 __do_sys_rename fs/namei.c:5073 [inline]
 __se_sys_rename fs/namei.c:5071 [inline]
 __x64_sys_rename+0x82/0x90 fs/namei.c:5071
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fbd0ef4a409
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 1f 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fbd0eeb80d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007fbd0efd54a8 RCX: 00007fbd0ef4a409
RDX: 00007fbd0ef4a409 RSI: 00000000200001c0 RDI: 0000000020000080
RBP: 00007fbd0efd54a0 R08: 00007fbd0eeb86c0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fbd0efd54ac
R13: 000000000000006e R14: 00007ffd79ca8e10 R15: 00007ffd79ca8ef8
 </TASK>