syzbot

ocfs2: Mounting device (7,9) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.179-syzkaller #0 Not tainted
------------------------------------------------------
syz.9.1915/11398 is trying to acquire lock:
ffff88805478dbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_read_virt_blocks+0x2b3/0xa10 fs/ocfs2/extent_map.c:976

but task is already holding lock:
ffff888070e18990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12b9/0x1570 fs/jbd2/transaction.c:462

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
       ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
       generic_shutdown_super+0x130/0x310 fs/super.c:475
       kill_block_super+0x7a/0xe0 fs/super.c:1427
       deactivate_locked_super+0xa0/0x110 fs/super.c:335
       cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
       task_work_run+0x129/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
       ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
       generic_shutdown_super+0x130/0x310 fs/super.c:475
       kill_block_super+0x7a/0xe0 fs/super.c:1427
       deactivate_locked_super+0xa0/0x110 fs/super.c:335
       cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
       task_work_run+0x129/0x1a0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
       exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
       __syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
       syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
       do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (sb_internal#5){.+.+}-{0:0}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
       ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266
       notify_change+0xc6d/0xf50 fs/attr.c:505
       do_truncate+0x21c/0x300 fs/open.c:65
       do_sys_ftruncate+0x2eb/0x390 fs/open.c:193
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x2b3/0xa10 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x433/0x2550 fs/ocfs2/dir.c:1091
       ocfs2_rename+0x22fb/0x3ea0 fs/ocfs2/namei.c:1568
       vfs_rename+0xd32/0x10f0 fs/namei.c:4832
       do_renameat2+0xe0f/0x1700 fs/namei.c:4985
       __do_sys_renameat2 fs/namei.c:5018 [inline]
       __se_sys_renameat2 fs/namei.c:5015 [inline]
       __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  lock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

8 locks held by syz.9.1915/11398:
 #0: ffff88807c9b6460 (sb_writers#34){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff88807c9b6748 (&type->s_vfs_rename_key#11){+.+.}-{3:3}, at: lock_rename fs/namei.c:3016 [inline]
 #1: ffff88807c9b6748 (&type->s_vfs_rename_key#11){+.+.}-{3:3}, at: do_renameat2+0x5b7/0x1700 fs/namei.c:4924
 #2: ffff88805456ed88 (&type->i_mutex_dir_key#18/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3017 [inline]
 #2: ffff88805456ed88 (&type->i_mutex_dir_key#18/1){+.+.}-{3:3}, at: do_renameat2+0x644/0x1700 fs/namei.c:4924
 #3: ffff88805478df48 (&sb->s_type->i_mutex_key#44/5){+.+.}-{3:3}, at: do_renameat2+0x67e/0x1700 fs/namei.c:4924
 #4: ffff888051c542c8 (&sb->s_type->i_mutex_key#44/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:822 [inline]
 #4: ffff888051c542c8 (&sb->s_type->i_mutex_key#44/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4795
 #5: ffff88807c9b6650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_rename+0x1e36/0x3ea0 fs/ocfs2/namei.c:1488
 #6: ffff888061a7dce8 (&journal->j_trans_barrier){.+.+}-{3:3}, at: ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
 #7: ffff888070e18990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12b9/0x1570 fs/jbd2/transaction.c:462

stack backtrace:
CPU: 0 PID: 11398 Comm: syz.9.1915 Not tainted 5.15.179-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
 ocfs2_read_virt_blocks+0x2b3/0xa10 fs/ocfs2/extent_map.c:976
 ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
 ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
 ocfs2_find_entry+0x433/0x2550 fs/ocfs2/dir.c:1091
 ocfs2_rename+0x22fb/0x3ea0 fs/ocfs2/namei.c:1568
 vfs_rename+0xd32/0x10f0 fs/namei.c:4832
 do_renameat2+0xe0f/0x1700 fs/namei.c:4985
 __do_sys_renameat2 fs/namei.c:5018 [inline]
 __se_sys_renameat2 fs/namei.c:5015 [inline]
 __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5015
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f0dfbf91169
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f0df9dfa038 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007f0dfc1a9fa0 RCX: 00007f0dfbf91169
RDX: 0000000000000004 RSI: 0000200000000240 RDI: 0000000000000004
RBP: 00007f0dfc0122a0 R08: 0000000000000000 R09: 0000000000000000
R10: 00002000000001c0 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f0dfc1a9fa0 R15: 00007ffe073aa878
 </TASK>