syzbot


possible deadlock in ocfs2_reserve_local_alloc_bits

Status: upstream: reported on 2024/09/28 04:05
Reported-by: syzbot+315109f6cd4d9034e8ae@syzkaller.appspotmail.com
First crash: 8h11m, last: 8h11m
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in ocfs2_reserve_local_alloc_bits ocfs2 C done 309 1h18m 36d 0/28 upstream: reported C repro on 2024/08/22 12:35
linux-5.15 possible deadlock in ocfs2_reserve_local_alloc_bits 4 11h14m 18h30m 0/3 upstream: reported on 2024/09/27 17:46

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.111-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.190/5626 is trying to acquire lock:
ffff0000e15cc2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff0000e15cc2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635

but task is already holding lock:
ffff0000f14a8660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
       dqget+0x660/0xcec fs/quota/dquot.c:986
       ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
       notify_change+0xb58/0xe1c fs/attr.c:499
       chown_common+0x4e8/0x7d8 fs/open.c:736
       vfs_fchown fs/open.c:804 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:815
       __do_sys_fchown fs/open.c:823 [inline]
       __se_sys_fchown fs/open.c:821 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:821
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
       dqget+0x660/0xcec fs/quota/dquot.c:986
       ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
       notify_change+0xb58/0xe1c fs/attr.c:499
       chown_common+0x4e8/0x7d8 fs/open.c:736
       vfs_fchown fs/open.c:804 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:815
       __do_sys_fchown fs/open.c:823 [inline]
       __se_sys_fchown fs/open.c:821 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:821
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       dquot_commit+0x54/0x240 fs/quota/dquot.c:507
       ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6776
       ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6836
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
       __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1750
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5730
       ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4318
       ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678
       ext4_getblk+0x198/0x6ec fs/ext4/inode.c:889
       ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:945
       ext4_append+0x260/0x4cc fs/ext4/namei.c:83
       ext4_init_new_dir+0x294/0x8e4 fs/ext4/namei.c:3028
       ext4_mkdir+0x3d4/0xa64 fs/ext4/namei.c:3074
       vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
       do_mkdirat+0x220/0x510 fs/namei.c:4133
       __do_sys_mkdirat fs/namei.c:4148 [inline]
       __se_sys_mkdirat fs/namei.c:4146 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
       ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5598
       notify_change+0xb58/0xe1c fs/attr.c:499
       do_truncate+0x1c0/0x28c fs/open.c:65
       do_sys_ftruncate+0x288/0x31c fs/open.c:193
       __do_sys_ftruncate fs/open.c:204 [inline]
       __se_sys_ftruncate fs/open.c:202 [inline]
       __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463
       jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354
       ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
       vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
       do_mkdirat+0x220/0x510 fs/namei.c:4133
       __do_sys_mkdirat fs/namei.c:4148 [inline]
       __se_sys_mkdirat fs/namei.c:4146 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352
       ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
       vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
       do_mkdirat+0x220/0x510 fs/namei.c:4133
       __do_sys_mkdirat fs/namei.c:4148 [inline]
       __se_sys_mkdirat fs/namei.c:4146 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (sb_internal#3){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
       ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
       ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
       vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
       do_mkdirat+0x220/0x510 fs/namei.c:4133
       __do_sys_mkdirat fs/namei.c:4148 [inline]
       __se_sys_mkdirat fs/namei.c:4146 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585
       ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
       ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836
       dqget+0x660/0xcec fs/quota/dquot.c:986
       ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
       notify_change+0xb58/0xe1c fs/attr.c:499
       chown_common+0x4e8/0x7d8 fs/open.c:736
       vfs_fchown fs/open.c:804 [inline]
       ksys_fchown+0xe0/0x158 fs/open.c:815
       __do_sys_fchown fs/open.c:823 [inline]
       __se_sys_fchown fs/open.c:821 [inline]
       __arm64_sys_fchown+0x7c/0x94 fs/open.c:821
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);

 *** DEADLOCK ***

5 locks held by syz.1.190/5626:
 #0: ffff0000f190a460 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437
 #1: ffff0000f14ab488 (&type->i_mutex_dir_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff0000f14ab488 (&type->i_mutex_dir_key#20){+.+.}-{3:3}, at: chown_common+0x358/0x7d8 fs/open.c:726
 #2: ffff0000e17780a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806
 #3: ffff0000f14a89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #3: ffff0000f14a89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
 #4: ffff0000f14a8660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 1 PID: 5626 Comm: syz.1.190 Not tainted 6.1.111-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
 ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585
 ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
 ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836
 dqget+0x660/0xcec fs/quota/dquot.c:986
 ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
 notify_change+0xb58/0xe1c fs/attr.c:499
 chown_common+0x4e8/0x7d8 fs/open.c:736
 vfs_fchown fs/open.c:804 [inline]
 ksys_fchown+0xe0/0x158 fs/open.c:815
 __do_sys_fchown fs/open.c:823 [inline]
 __se_sys_fchown fs/open.c:821 [inline]
 __arm64_sys_fchown+0x7c/0x94 fs/open.c:821
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/28 04:05 linux-6.1.y e526b12bf916 440b26ec .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in ocfs2_reserve_local_alloc_bits
* Struck through repros no longer work on HEAD.